Skip to contentSkip to conversation

Fix a race condition in the target driver

PATCH Superseded Maurizio Lombardi 4 participants 4 messages Mar 13, 2020 – Mar 18, 2020 SCSI target

lore
Share & tools
lore
#0 lore raw

cover Fix a race condition in the target driver

Multiple threads may try to destroy the same iscsi session structure by calling iscsit_close_session() and then end up hanging.

This patchset modifies the driver so the session structure is destroyed by iscsit_close_connection() when the last connection gets closed, thus preventing the race condition.

Maurizio Lombardi (3):
target: remove boilerplate code
target: fix target hang when multiple threads try to destroy the same
iscsi session.
iscsi target: calling iscsit_stop_session() inside
iscsit_close_session() has no effect

 drivers/target/iscsi/iscsi_target.c          | 82 ++++++--------------
 drivers/target/iscsi/iscsi_target.h          |  1 -
 drivers/target/iscsi/iscsi_target_configfs.c |  5 +-
 drivers/target/iscsi/iscsi_target_login.c    |  5 +-
 include/target/iscsi/iscsi_target_core.h     |  2 +-
 5 files changed, 32 insertions(+), 63 deletions(-)
Signature · 1 line
2.21.0
#1 lore raw
Quoted 16 lines · Maurizio Lombardi

Multiple threads may try to destroy the same iscsi session structure by calling iscsit_close_session() and then end up hanging.

This patchset modifies the driver so the session structure is destroyed by iscsit_close_connection() when the last connection gets closed, thus preventing the race condition.

Maurizio Lombardi (3):
target: remove boilerplate code
target: fix target hang when multiple threads try to destroy the same
iscsi session.
iscsi target: calling iscsit_stop_session() inside
iscsit_close_session() has no effect

Quoted 7 lines
  drivers/target/iscsi/iscsi_target.c          | 82 ++++++--------------
  drivers/target/iscsi/iscsi_target.h          |  1 -
  drivers/target/iscsi/iscsi_target_configfs.c |  5 +-
  drivers/target/iscsi/iscsi_target_login.c    |  5 +-
  include/target/iscsi/iscsi_target_core.h     |  2 +-
  5 files changed, 32 insertions(+), 63 deletions(-)

Hi Mike, Varun and Rahul,

This patch series may affect the iSER target driver so you may want to verify this patch series on your test setups.

Thanks,

Bart.

#2 lore raw
In reply to Maurizio Lombardi

SGkgQmFydCwNCg0KUGF0Y2ggc2VyaWVzIGlzIHRlc3RlZCBnb29kLg0KDQpUaGFua3MsDQpSYWh1 bCBLdW5kdS4NCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEJhcnQgVmFuIEFz c2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPiANClNlbnQ6IEZyaWRheSwgTWFyY2ggMTMsIDIwMjAg MTE6MDkgUE0NClRvOiBNYXVyaXppbyBMb21iYXJkaSA8bWxvbWJhcmRAcmVkaGF0LmNvbT47IHRh cmdldC1kZXZlbEB2Z2VyLmtlcm5lbC5vcmcNCkNjOiBtYXJ0aW4ucGV0ZXJzZW5Ab3JhY2xlLmNv bTsgZGRpc3NAc3VzZS5kZTsgbWNvbGVtYW5AZGF0dG8uY29tOyBWYXJ1biBQcmFrYXNoIDx2YXJ1 bkBjaGVsc2lvLmNvbT47IFJhaHVsIEt1bmR1IDxyYWh1bC5rdW5kdUBjaGVsc2lvLmNvbT47IE1p a2UgTWFyY2luaXN6eW4gPG1pa2UubWFyY2luaXN6eW5AaW50ZWwuY29tPg0KU3ViamVjdDogUmU6 IFtQQVRDSCAwLzNdIEZpeCBhIHJhY2UgY29uZGl0aW9uIGluIHRoZSB0YXJnZXQgZHJpdmVyDQoN Ck9uIDMvMTMvMjAgOToxMiBBTSwgTWF1cml6aW8gTG9tYmFyZGkgd3JvdGU6DQo+IE11bHRpcGxl IHRocmVhZHMgbWF5IHRyeSB0byBkZXN0cm95IHRoZSBzYW1lIGlzY3NpIHNlc3Npb24gc3RydWN0 dXJlIA0KPiBieSBjYWxsaW5nIGlzY3NpdF9jbG9zZV9zZXNzaW9uKCkgYW5kIHRoZW4gZW5kIHVw IGhhbmdpbmcuDQo+IA0KPiBUaGlzIHBhdGNoc2V0IG1vZGlmaWVzIHRoZSBkcml2ZXIgc28gdGhl IHNlc3Npb24gc3RydWN0dXJlIGlzIA0KPiBkZXN0cm95ZWQgYnkgaXNjc2l0X2Nsb3NlX2Nvbm5l Y3Rpb24oKSB3aGVuIHRoZSBsYXN0IGNvbm5lY3Rpb24gZ2V0cyANCj4gY2xvc2VkLCB0aHVzIHBy ZXZlbnRpbmcgdGhlIHJhY2UgY29uZGl0aW9uLg0KPiANCj4gTWF1cml6aW8gTG9tYmFyZGkgKDMp Og0KPiAgICB0YXJnZXQ6IHJlbW92ZSBib2lsZXJwbGF0ZSBjb2RlDQo+ICAgIHRhcmdldDogZml4 IHRhcmdldCBoYW5nIHdoZW4gbXVsdGlwbGUgdGhyZWFkcyB0cnkgdG8gZGVzdHJveSB0aGUgc2Ft ZQ0KPiAgICAgIGlzY3NpIHNlc3Npb24uDQo+ICAgIGlzY3NpIHRhcmdldDogY2FsbGluZyBpc2Nz aXRfc3RvcF9zZXNzaW9uKCkgaW5zaWRlDQo+ICAgICAgaXNjc2l0X2Nsb3NlX3Nlc3Npb24oKSBo YXMgbm8gZWZmZWN0DQo+IA0KPiAgIGRyaXZlcnMvdGFyZ2V0L2lzY3NpL2lzY3NpX3RhcmdldC5j ICAgICAgICAgIHwgODIgKysrKysrLS0tLS0tLS0tLS0tLS0NCj4gICBkcml2ZXJzL3RhcmdldC9p c2NzaS9pc2NzaV90YXJnZXQuaCAgICAgICAgICB8ICAxIC0NCj4gICBkcml2ZXJzL3RhcmdldC9p c2NzaS9pc2NzaV90YXJnZXRfY29uZmlnZnMuYyB8ICA1ICstDQo+ICAgZHJpdmVycy90YXJnZXQv aXNjc2kvaXNjc2lfdGFyZ2V0X2xvZ2luLmMgICAgfCAgNSArLQ0KPiAgIGluY2x1ZGUvdGFyZ2V0 L2lzY3NpL2lzY3NpX3RhcmdldF9jb3JlLmggICAgIHwgIDIgKy0NCj4gICA1IGZpbGVzIGNoYW5n ZWQsIDMyIGluc2VydGlvbnMoKyksIDYzIGRlbGV0aW9ucygtKQ0KPiANCg0KSGkgTWlrZSwgVmFy dW4gYW5kIFJhaHVsLA0KDQpUaGlzIHBhdGNoIHNlcmllcyBtYXkgYWZmZWN0IHRoZSBpU0VSIHRh cmdldCBkcml2ZXIgc28geW91IG1heSB3YW50IHRvIHZlcmlmeSB0aGlzIHBhdGNoIHNlcmllcyBv biB5b3VyIHRlc3Qgc2V0dXBzLg0KDQpUaGFua3MsDQoNCkJhcnQuDQo

#3 lore raw
In reply to Maurizio Lombardi

PiBIaSBNaWtlLCBWYXJ1biBhbmQgUmFodWwsDQo+IA0KPiBUaGlzIHBhdGNoIHNlcmllcyBtYXkg YWZmZWN0IHRoZSBpU0VSIHRhcmdldCBkcml2ZXIgc28geW91IG1heSB3YW50IHRvIHZlcmlmeQ0K PiB0aGlzIHBhdGNoIHNlcmllcyBvbiB5b3VyIHRlc3Qgc2V0dXBzLg0KPiANCj4gVGhhbmtzLA0K PiANCj4gQmFydC4NCg0KV2hhdCBpcyB0aGUgYmFzZSBmb3IgdGhpcyBzZXJpZXMuDQoNCkkgY2Fu IGVhc2lseSB0ZXN0Lg0KDQpNaWtlDQo