Skip to contentSkip to conversation

Staging: media: imx: eliminate unused code

PATCH Superseded Enrique Vargas 2 participants 3 messages Mar 13, 2020

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: media: imx: eliminate unused code

Eliminate code that is never used inside #ifdef 0 / #endif. This eliminates WARNING found using checkpatch.

---
 drivers/staging/media/imx/imx-media-csi.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/media/imx/imx-media-csi.c +1 -7
index b60ed4f22f6d..2001f7851e90 100644
@@ -1131,13 +1131,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
 		 * enters the CSI's however, they are treated internally
 		 * in the IPU as virtual channel 0.
 		 */
-#if 0
-		mutex_unlock(&priv->lock);
-		vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
-		if (vc_num < 0)
-			return vc_num;
-		mutex_lock(&priv->lock);
-#endif
+
 		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
 					  &priv->format_mbus[CSI_SINK_PAD]);
 	}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Enrique Vargas

Eliminate code that is never used inside #ifdef 0 / #endif. This eliminates WARNING found using checkpatch.

---
 drivers/staging/media/imx/imx-media-csi.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

What changed from v1?

Always put that below the --- line.

Please fix up and send a v3.

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg Kroah-Hartman
Quoted 6 lines · Enrique Vargas

Eliminate code that is never used inside #ifdef 0 / #endif. This eliminates WARNING found using checkpatch.

---
 drivers/staging/media/imx/imx-media-csi.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

What changed from v1?

Quoted 7 lines

Always put that below the --- line.

Please fix up and send a v3.

thanks,

greg k-h

Thanks, I sent v3.