Input: Allocate keycode for "Selective Screenshot" key
Subsystems (2)
PATCH v3 1/1 Input: Allocate keycode for "Selective Screenshot" key
New chromeos keyboards have a "snip" key that is basically a selective screenshot (allows a user to select an area of screen to be copied). Allocate a keycode for it.
---
v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
include/uapi/linux/input-event-codes.h | 2 ++ 1 file changed, 2 insertions(+)
include/uapi/linux/input-event-codes.h +2 -0
@@ -652,6 +652,8 @@/* Electronic privacy screen control */ #define KEY_PRIVACY_SCREEN_TOGGLE 0x279 +#define KEY_SELECTIVE_SCREENSHOT 0x280 +/* * Some keyboards have keys which do not have a defined meaning, these keys * are intended to be programmed / bound to macros by the user. For most
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
Quoted 6 lines · Rajat Jain
New chromeos keyboards have a "snip" key that is basically a selective screenshot (allows a user to select an area of screen to be copied). Allocate a keycode for it.
Signed-off-by Rajat Jain <[email protected]>
Harry Cutts
Chrome OS Touch/Input team
Quoted 23 lines
---
v3: RenameKEY_SNIPtoKEY_SELECTIVE_SNAPSHOT
V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.include/uapi/linux/input-event-codes.h | 2 ++ 1 file changed, 2 insertions(+)include/uapi/linux/input-event-codes.h +2
-1@@ -652,6 +652,8 @@/* Electronic privacy screen control */ #define KEY_PRIVACY_SCREEN_TOGGLE 0x279 +#define KEY_SELECTIVE_SCREENSHOT 0x280 +/* * Some keyboards have keys which do not have a defined meaning, these keys * are intended to be programmed / bound to macros by the user. For most -- 2.25.1.481.gfbce0eb801-goog
Quoted 5 lines · Rajat Jain
New chromeos keyboards have a "snip" key that is basically a selective screenshot (allows a user to select an area of screen to be copied). Allocate a keycode for it.
Signed-off-by Rajat Jain <[email protected]>
Applied, thank you.
Quoted 23 lines
---
v3: RenameKEY_SNIPtoKEY_SELECTIVE_SNAPSHOT
V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.include/uapi/linux/input-event-codes.h | 2 ++ 1 file changed, 2 insertions(+)include/uapi/linux/input-event-codes.h +2
-0@@ -652,6 +652,8 @@/* Electronic privacy screen control */ #define KEY_PRIVACY_SCREEN_TOGGLE 0x279 +#define KEY_SELECTIVE_SCREENSHOT 0x280 +/* * Some keyboards have keys which do not have a defined meaning, these keys * are intended to be programmed / bound to macros by the user. For most Signature · 1 line
2.25.1.481.gfbce0eb801-goog
Signature · 1 line
Dmitry
Quoted 9 lines · Dmitry Torokhov
Quoted 5 lines · Rajat Jain
New chromeos keyboards have a "snip" key that is basically a selective screenshot (allows a user to select an area of screen to be copied). Allocate a keycode for it.
Signed-off-by Rajat Jain <[email protected]>Applied, thank you.
I just noticed that I had by mistake used KEY_SELECTIVE_SNAPSHOT instead of intended KEY_SELECTIVE_SCREENSHOT in the commit message. My apologies. Can you please fix the commit message if not already pushed. Otherwise I can send a follow up patch if you'd like.
Thanks & Best Regards,
Rajat
Quoted 27 lines
Quoted 22 lines
---
v3: RenameKEY_SNIPtoKEY_SELECTIVE_SNAPSHOT
V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.include/uapi/linux/input-event-codes.h | 2 ++ 1 file changed, 2 insertions(+)include/uapi/linux/input-event-codes.h +2
-1@@ -652,6 +652,8 @@/* Electronic privacy screen control */ #define KEY_PRIVACY_SCREEN_TOGGLE 0x279 +#define KEY_SELECTIVE_SCREENSHOT 0x280 +/* * Some keyboards have keys which do not have a defined meaning, these keys * are intended to be programmed / bound to macros by the user. For most -- Quoted 2 lines
2.25.1.481.gfbce0eb801-goog
--
Dmitry
Quoted 9 lines · Rajat Jain
Quoted 6 lines · Dmitry Torokhov
Quoted 4 lines · Rajat Jain
New chromeos keyboards have a "snip" key that is basically a selective screenshot (allows a user to select an area of screen to be copied). Allocate a keycode for it.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Rajat Jain <[email protected]>Applied, thank you.
I just noticed that I had by mistake used
KEY_SELECTIVE_SNAPSHOTinstead of intendedKEY_SELECTIVE_SCREENSHOTin the commit message. My apologies. Can you please fix the commit message if not already pushed. Otherwise I can send a follow up patch if you'd like.
Arghhh..... please disregard. I was looking at the wrong place. The patch was correct. No need to do anything.
Thanks! :-)
Best Regards,
Rajat
Quoted 32 lines
Thanks & Best Regards,
Rajat
Quoted 27 lines
Quoted 22 lines
---
v3: RenameKEY_SNIPtoKEY_SELECTIVE_SNAPSHOT
V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.include/uapi/linux/input-event-codes.h | 2 ++ 1 file changed, 2 insertions(+)include/uapi/linux/input-event-codes.h +2
-1@@ -652,6 +652,8 @@/* Electronic privacy screen control */ #define KEY_PRIVACY_SCREEN_TOGGLE 0x279 +#define KEY_SELECTIVE_SCREENSHOT 0x280 +/* * Some keyboards have keys which do not have a defined meaning, these keys * are intended to be programmed / bound to macros by the user. For most -- Quoted 2 lines
2.25.1.481.gfbce0eb801-goog
--
Dmitry