Skip to contentSkip to conversation

media: staging/intel-ipu3: Reformat pointer definition

PATCH Superseded Deepak R Varma 2 participants 2 messages Mar 13, 2020 – Mar 17, 2020

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: staging/intel-ipu3: Reformat pointer definition

Reformat pointer definition to make it more readable as per the coding standards. Problem detected by checkpatch.

---
 drivers/staging/media/ipu3/ipu3-v4l2.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/media/ipu3/ipu3-v4l2.c +3 -3
index 569e27b824c8..52826fad6f42 100644
@@ -485,7 +485,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
 	if (r < 0)
 		goto fail_return_bufs;
 
-
 	if (!imgu_all_nodes_streaming(imgu, node))
 		return 0;
 
@@ -1013,8 +1012,9 @@ static const struct v4l2_ioctl_ops imgu_v4l2_meta_ioctl_ops = {
 
 static int imgu_sd_s_ctrl(struct v4l2_ctrl *ctrl)
 {
-	struct imgu_v4l2_subdev *imgu_sd =
-		container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
+	struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
+							struct imgu_v4l2_subdev,
+							ctrl_handler);
 	struct imgu_device *imgu = v4l2_get_subdevdata(&imgu_sd->subdev);
 	struct device *dev = &imgu->pci_dev->dev;
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · On Sat, 14 Mar 2020 00:08:30 +0530 Deepak R Varma <[email protected]> wrote:

Reformat pointer definition to make it more readable as per the coding standards. Problem detected by checkpatch.

What you're actually changing here is the assignment or initialisation, not the definition.

Can you please re-send this with adjusted description and title? The rest looks good to me, except for the unrelated change:

Quoted 11 lines
---
 drivers/staging/media/ipu3/ipu3-v4l2.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/media/ipu3/ipu3-v4l2.c +0 -0
index 569e27b824c8..52826fad6f42 100644

drivers/staging/media/ipu3/ipu3-v4l2.c static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count) · line 488

Quoted 4 lines
drivers/staging/media/ipu3/ipu3-v4l2.c +0 -1
@@ -485,7 +485,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
 	if (r < 0)
 		goto fail_return_bufs;
 
-

here.

Signature · 1 line
Stefano