Skip to contentSkip to conversation

edid-decode: Fix decoing of DispID physical enclosure bit

PATCH In review Ville Syrjala 2 participants 2 messages Mar 13, 2020 – Mar 15, 2020 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 edid-decode: Fix decoing of DispID physical enclosure bit

From: Ville Syrjälä <[email protected]>

The interpretation of the physucal enclosure bit is backwards. Fix it to match the spec.

---
 parse-displayid-block.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
parse-displayid-block.cpp +2 -2
index e6c8d95dcaa1..b436f343fa63 100644
@@ -913,9 +913,9 @@ static void parse_displayid_tiled_display_topology(const unsigned char *x, bool
 	default: printf("Reserved\n"); break;
 	}
 	if (caps & 0x80)
-		printf("    Tiled display consists of multiple physical display enclosures\n");
-	else
 		printf("    Tiled display consists of a single physical display enclosure\n");
+	else
+		printf("    Tiled display consists of multiple physical display enclosures\n");
 	printf("    Num horizontal tiles: %u Num vertical tiles: %u\n",
 	       num_h_tile + 1, num_v_tile + 1);
 	printf("    Tile location: %u, %u\n", tile_h_location, tile_v_location);
Signature · 1 line
2.24.1
#1 lore raw
Quoted 4 lines · Ville Syrjala

From: Ville Syrjälä <[email protected]>

The interpretation of the physucal enclosure bit is backwards. Fix it to match the spec.

Thank you, it's been applied.

Regards,

Hans

Quoted 23 lines
---
 parse-displayid-block.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
parse-displayid-block.cpp +2 -2
index e6c8d95dcaa1..b436f343fa63 100644
@@ -913,9 +913,9 @@ static void parse_displayid_tiled_display_topology(const unsigned char *x, bool
 	default: printf("Reserved\n"); break;
 	}
 	if (caps & 0x80)
-		printf("    Tiled display consists of multiple physical display enclosures\n");
-	else
 		printf("    Tiled display consists of a single physical display enclosure\n");
+	else
+		printf("    Tiled display consists of multiple physical display enclosures\n");
 	printf("    Num horizontal tiles: %u Num vertical tiles: %u\n",
 	       num_h_tile + 1, num_v_tile + 1);
 	printf("    Tile location: %u, %u\n", tile_h_location, tile_v_location);