Skip to contentSkip to conversation

chcr: remove set but not used variable 'status'

PATCH In review YueHaibing 1 participant 2 messages Mar 15, 2020

Subsystems (2)
lore
Share & tools
lore

YueHaibing

author
#0 lore raw

PATCH 1/1 chcr: remove set but not used variable 'status'

drivers/crypto/chelsio/chcr_ktls.c: In function chcr_ktls_cpl_set_tcb_rpl:
drivers/crypto/chelsio/chcr_ktls.c:662:11: warning:
variable status set but not used [-Wunused-but-set-variable]

commit 8a30923e1598 ("cxgb4/chcr: Save tx keys and handle HW response") involved this unused variable, remove it.

---
 drivers/crypto/chelsio/chcr_ktls.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/crypto/chelsio/chcr_ktls.c +1 -2
index f0c3834eda4f..00099e793e63 100644
@@ -659,10 +659,9 @@ int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input)
 	const struct cpl_set_tcb_rpl *p = (void *)input;
 	struct chcr_ktls_info *tx_info = NULL;
 	struct tid_info *t;
-	u32 tid, status;
+	u32 tid;
 
 	tid = GET_TID(p);
-	status = p->status;
 
 	t = &adap->tids;
 	tx_info = lookup_tid(t, tid);
Signature · 1 line
2.20.1
author
#1 lore raw

This should apply to net-next, will resend.

Quoted 30 lines · YueHaibing

drivers/crypto/chelsio/chcr_ktls.c: In function chcr_ktls_cpl_set_tcb_rpl:
drivers/crypto/chelsio/chcr_ktls.c:662:11: warning:
variable status set but not used [-Wunused-but-set-variable]

commit 8a30923e1598 ("cxgb4/chcr: Save tx keys and handle HW response") involved this unused variable, remove it.

---
 drivers/crypto/chelsio/chcr_ktls.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/crypto/chelsio/chcr_ktls.c +1 -2
index f0c3834eda4f..00099e793e63 100644
@@ -659,10 +659,9 @@ int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input)
 	const struct cpl_set_tcb_rpl *p = (void *)input;
 	struct chcr_ktls_info *tx_info = NULL;
 	struct tid_info *t;
-	u32 tid, status;
+	u32 tid;
 
 	tid = GET_TID(p);
-	status = p->status;
 
 	t = &adap->tids;
 	tx_info = lookup_tid(t, tid);