Skip to contentSkip to conversation

staging: comedi: dt3000: Reformat multiple line dereference

PATCH In review Deepak R Varma 2 participants 2 messages Mar 14, 2020 – Mar 17, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: comedi: dt3000: Reformat multiple line dereference

Reformat multiple line dereferences for &cmd->scan_begin_arg. Problem detected by checkpatch.

---
 drivers/staging/comedi/drivers/dt3000.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/dt3000.c +2 -3
index f7c365b70106..011e19161b78 100644
@@ -439,9 +439,8 @@ static int dt3k_ai_cmdtest(struct comedi_device *dev,
 
 		if (cmd->scan_begin_src == TRIG_TIMER) {
 			arg = cmd->convert_arg * cmd->scan_end_arg;
-			err |= comedi_check_trigger_arg_min(&cmd->
-							    scan_begin_arg,
-							    arg);
+			err |= comedi_check_trigger_arg_min(
+				&cmd->scan_begin_arg, arg);
 		}
 	}
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · On Sat, 14 Mar 2020 19:28:57 +0530 Deepak R Varma <[email protected]> wrote:

Reformat multiple line dereferences for &cmd->scan_begin_arg. Problem detected by checkpatch.

---
 drivers/staging/comedi/drivers/dt3000.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/dt3000.c +0 -0
index f7c365b70106..011e19161b78 100644

drivers/staging/comedi/drivers/dt3000.c static int dt3k_ai_cmdtest(struct comedi_device *dev, · line 443

Quoted 8 lines
drivers/staging/comedi/drivers/dt3000.c +2 -3
@@ -439,9 +439,8 @@ static int dt3k_ai_cmdtest(struct comedi_device *dev,
 
 		if (cmd->scan_begin_src == TRIG_TIMER) {
 			arg = cmd->convert_arg * cmd->scan_end_arg;
-			err |= comedi_check_trigger_arg_min(&cmd->
-							    scan_begin_arg,
-							    arg);
+			err |= comedi_check_trigger_arg_min(
+				&cmd->scan_begin_arg, arg);

Isn't this introducing an equivalent issue to the one you're fixing in:
[PATCH] staging: comedi: s626: Reformat function arguments
?

That is, I think this should be more indented than that.

Signature · 1 line
Stefano