Skip to contentSkip to conversation

staging: wfx: remove unneeded spaces

PATCH In review Lourdes Pedrajas 3 participants 3 messages Mar 15, 2020 – Mar 17, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wfx: remove unneeded spaces

Remove spaces after type casting operators in order to comply codding standards.
Issue found with checkpatch.

---
 drivers/staging/wfx/queue.c | 2 +-
 drivers/staging/wfx/sta.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wfx/queue.c +1 -1
index ed6dc8297738..39d9127ce4b9 100644
@@ -540,7 +540,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
 		skb = wfx_tx_queue_get(wdev, queue, tx_allowed_mask);
 		if (!skb)
 			continue;
-		hif = (struct hif_msg *) skb->data;
+		hif = (struct hif_msg *)skb->data;
 		wvif = wdev_to_wvif(wdev, hif->interface);
 		WARN_ON(!wvif);
 
drivers/staging/wfx/sta.c +1 -1
index a60ac03fa73d..07a9991929fd 100644
@@ -903,7 +903,7 @@ static void wfx_update_tim_work(struct work_struct *work)
 int wfx_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set)
 {
 	struct wfx_dev *wdev = hw->priv;
-	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *) &sta->drv_priv;
+	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *)&sta->drv_priv;
 	struct wfx_vif *wvif = wdev_to_wvif(wdev, sta_dev->vif_id);
 
 	schedule_work(&wvif->update_tim_work);
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · On Sun, 15 Mar 2020 05:49:22 +0100 Lourdes Pedrajas <[email protected]> wrote:

Remove spaces after type casting operators in order to comply codding

with coding...

Quoted 5 lines

standards.

Issue found with checkpatch.

By the way, question for Greg:

drivers/staging/wfx/sta.c static void wfx_update_tim_work(struct work_struct *work) · line 907

Quoted 12 lines

[...]

index a60ac03fa73d..07a9991929fd 100644

drivers/staging/wfx/sta.c +1 -1
@@ -903,7 +903,7 @@ static void wfx_update_tim_work(struct work_struct *work)
 int wfx_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set)
 {
 	struct wfx_dev *wdev = hw->priv;
-	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *) &sta->drv_priv;
+	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *)&sta->drv_priv;
 	struct wfx_vif *wvif = wdev_to_wvif(wdev, sta_dev->vif_id);

Will this eventually have to conform to networking coding style? At what point in time is this stuff checked, if at all?

Signature · 1 line
Stefano
maintainer
#2 lore raw
Quoted 19 lines · Stefano Brivio
Quoted 1 line · On Sun, 15 Mar 2020 05:49:22 +0100 Lourdes Pedrajas <[email protected]> wrote:

Remove spaces after type casting operators in order to comply codding

with coding...

Quoted 5 lines

standards.

Issue found with checkpatch.

By the way, question for Greg:

Quoted 2 lines

[...]

Quoted 13 lines

drivers/staging/wfx/sta.c static void wfx_update_tim_work(struct work_struct *work) · line 907

Quoted 10 lines

index a60ac03fa73d..07a9991929fd 100644

drivers/staging/wfx/sta.c +1 -1
@@ -903,7 +903,7 @@ static void wfx_update_tim_work(struct work_struct *work)
 int wfx_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set)
 {
 	struct wfx_dev *wdev = hw->priv;
-	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *) &sta->drv_priv;
+	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *)&sta->drv_priv;
 	struct wfx_vif *wvif = wdev_to_wvif(wdev, sta_dev->vif_id);

Will this eventually have to conform to networking coding style? At what point in time is this stuff checked, if at all?

When the maintainer wants it merged to the "real" part of the kernel, that will be needed to be checked.

thanks,

greg k-h