Skip to contentSkip to conversation

package/python-markdown: fix Python version dependency

PATCH New yegorslists at googlemail.com 5 participants 10 messages Mar 10, 2020 – Apr 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/python-markdown/Config.in +2 -2
index 6706684142..454c2729bd 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_MARKDOWN
 	bool "python-markdown"
+	depends on BR2_PACKAGE_PYTHON3
 	# runtime dependency on Python's xml module
-	select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+	select BR2_PACKAGE_PYTHON3_PYEXPAT
 	help
 	  This is a Python implementation of John Gruber's Markdown
 
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

Quoted 29 lines · On Tue, Mar 10, 2020 at 1:41 PM <[email protected]> wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/python-markdown/Config.in +2 -3
index 6706684142..454c2729bd 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_MARKDOWN
        bool "python-markdown"
+       depends on BR2_PACKAGE_PYTHON3
        # runtime dependency on Python's xml module
-       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+       select BR2_PACKAGE_PYTHON3_PYEXPAT
        help
          This is a Python implementation of John Gruber's Markdown
 
--
Quoted 2 lines

2.17.0

Regards,
Asaf.

#2 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

Hi all,

Quoted 30 lines · Asaf Kahlon
Quoted 28 lines · On Tue, Mar 10, 2020 at 1:41 PM <[email protected]> wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/python-markdown/Config.in +2 -2
index 6706684142..454c2729bd 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_MARKDOWN
        bool "python-markdown"
+       depends on BR2_PACKAGE_PYTHON3
        # runtime dependency on Python's xml module
-       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+       select BR2_PACKAGE_PYTHON3_PYEXPAT
        help
          This is a Python implementation of John Gruber's Markdown
 
Quoted 5 lines
Quoted 3 lines

--
2.17.0

The issue is more complicated than I thought at the beginning.

First of all, python-cheetah package that depends on python-markdown was abandoned. The new fork is Cheetah3 [1]. What should we do? Just replace the download location? Though the project is Py2/Py3 compatible because of python-markdown we would restrict it to Py3 only?

mongodb and gr-osmosdr both depend on python-cheetah. So they must be touched as well. Fabrice and Gwenhael could you take care of this?

Because of this dependencies hell, a CI test for at least mongodb would be very welcome.

[1] https://pypi.org/project/Cheetah3/

Thanks.

Yegor

#3 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

Hi Yegor,

Le mer. 11 mars 2020 ? 10:14, Yegor Yefremov
<[email protected]> a ?crit :

Quoted 40 lines

Hi all,

Quoted 30 lines · Asaf Kahlon
Quoted 28 lines · On Tue, Mar 10, 2020 at 1:41 PM <[email protected]> wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/python-markdown/Config.in +2 -2
index 6706684142..454c2729bd 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_MARKDOWN
        bool "python-markdown"
+       depends on BR2_PACKAGE_PYTHON3
        # runtime dependency on Python's xml module
-       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+       select BR2_PACKAGE_PYTHON3_PYEXPAT
        help
          This is a Python implementation of John Gruber's Markdown
 
Quoted 5 lines
Quoted 3 lines

--
2.17.0

Quoted 7 lines

The issue is more complicated than I thought at the beginning.

First of all, python-cheetah package that depends on python-markdown was abandoned. The new fork is Cheetah3 [1]. What should we do? Just replace the download location? Though the project is Py2/Py3 compatible because of python-markdown we would restrict it to Py3 only?

I sent a python-cheetah3 package nearly one year ago and Titouan sent a v2 6 months ago: https://patchwork.ozlabs.org/patch/1184747.

Quoted 3 lines

mongodb and gr-osmosdr both depend on python-cheetah. So they must be touched as well. Fabrice and Gwenhael could you take care of this?

Again, a patch to bump mongodb and switch dependency to cheetah3 is waiting in patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/?series=138894
Thomas wanted your feedback on the third patch of this serie about making python3-pyyaml and python3-psutil packages.

Quoted 9 lines

Because of this dependencies hell, a CI test for at least mongodb would be very welcome.

[1] https://pypi.org/project/Cheetah3/

Thanks.

Yegor

Best Regards,

Fabrice

#4 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

Quoted 55 lines · Fabrice Fontaine

Hi Yegor,

Le mer. 11 mars 2020 ? 10:14, Yegor Yefremov
<[email protected]> a ?crit :

Quoted 40 lines

Hi all,

Quoted 30 lines · Asaf Kahlon
Quoted 28 lines · On Tue, Mar 10, 2020 at 1:41 PM <[email protected]> wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/python-markdown/Config.in +2 -2
index 6706684142..454c2729bd 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_MARKDOWN
        bool "python-markdown"
+       depends on BR2_PACKAGE_PYTHON3
        # runtime dependency on Python's xml module
-       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+       select BR2_PACKAGE_PYTHON3_PYEXPAT
        help
          This is a Python implementation of John Gruber's Markdown
 
Quoted 5 lines
Quoted 3 lines

--
2.17.0

Quoted 7 lines

The issue is more complicated than I thought at the beginning.

First of all, python-cheetah package that depends on python-markdown was abandoned. The new fork is Cheetah3 [1]. What should we do? Just replace the download location? Though the project is Py2/Py3 compatible because of python-markdown we would restrict it to Py3 only?

I sent a python-cheetah3 package nearly one year ago and Titouan sent a v2 6 months ago: https://patchwork.ozlabs.org/patch/1184747.

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

mongodb and gr-osmosdr both depend on python-cheetah. So they must be touched as well. Fabrice and Gwenhael could you take care of this?

Again, a patch to bump mongodb and switch dependency to cheetah3 is waiting in patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/?series=138894
Thomas wanted your feedback on the third patch of this serie about making python3-pyyaml and python3-psutil packages.

I have responded to those e-mails.

Oops! Sorry for delay.

Yegor

Quoted 12 lines
Quoted 9 lines

Because of this dependencies hell, a CI test for at least mongodb would be very welcome.

[1] https://pypi.org/project/Cheetah3/

Thanks.

Yegor

Best Regards,

Fabrice

#5 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

In reply to yegorslists at googlemail.com
Quoted 8 lines · On Tue, 10 Mar 2020 12:41:01 +0100 yegorslists at googlemail.com wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

So, should this patch be marked as Rejected ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

Hi Thomas,

Quoted 6 lines · Thomas Petazzoni
Quoted 2 lines · On Tue, 10 Mar 2020 12:41:01 +0100 yegorslists at googlemail.com wrote:

From: Yegor Yefremov <[email protected]>

Quoted 8 lines
Quoted 6 lines

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

So, should this patch be marked as Rejected ?

Basically, the patch is eligible as is. But it depends on the above mentioned patch series that also touches python-cheetah. As soon as it is reworked and merged, python-markdown is only an optional dependency of the python-cheetah package and can be applied.

Yegor

#7 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

In reply to yegorslists at googlemail.com

Hi,

Quoted 30 lines · On Tue, 10 Mar 2020 12:41:01 +0100 yegorslists at googlemail.com wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/package/python-markdown/Config.in index 6706684142..454c2729bd 100644

package/python-markdown/Config.in +2 -2
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_MARKDOWN
 	bool "python-markdown"
+	depends on BR2_PACKAGE_PYTHON3
 	# runtime dependency on Python's xml module
-	select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+	select BR2_PACKAGE_PYTHON3_PYEXPAT
 	help
 	  This is a Python implementation of John Gruber's Markdown
 
Signature · 1 line
2.17.0

Gwen

#8 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

Hi Thomas,

Quoted 32 lines · Gwenhael Goavec-Merou

Hi,

Quoted 27 lines · On Tue, 10 Mar 2020 12:41:01 +0100 yegorslists at googlemail.com wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/package/python-markdown/Config.in index 6706684142..454c2729bd 100644

package/python-markdown/Config.in +2 -2
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_MARKDOWN
      bool "python-markdown"
+     depends on BR2_PACKAGE_PYTHON3
      # runtime dependency on Python's xml module
-     select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-     select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+     select BR2_PACKAGE_PYTHON3_PYEXPAT
      help
        This is a Python implementation of John Gruber's Markdown
 
Quoted 5 lines
Quoted 3 lines

--
2.17.0

It is now safe to merge this patch as python-cheetah doesn't depend on it anymore and also supports both Py2 and Py3.

Yegor

#9 lore raw

PATCH 1/1 package/python-markdown: fix Python version dependency

In reply to yegorslists at googlemail.com
Quoted 3 lines · On Tue, 10 Mar 2020 12:41:01 +0100 yegorslists at googlemail.com wrote:

From: Yegor Yefremov <[email protected]>

The latest version has dropped Python 2 support.

"The latest version" is very vague. Read this statement in 6 months, and it no longer makes sense. I've extended the commit log quite a bit:

https://git.buildroot.org/buildroot/commit/?id=1e5723ee589e8d205883c15ca863c01f94b8854f

and applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com