Skip to contentSkip to conversation

package/gssdp: explicitly disable vapi

PATCH New aduskett at gmail.com 3 participants 4 messages Mar 15, 2020 – Mar 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gssdp: explicitly disable vapi

From: Adam Duskett <[email protected]>

Currently, vapi support does not work with meson due to meson calling vapigen directly instead of the vala wrapper. As such, when building typelib files for gobject-introspection, vapigen fails to find the proper .gir files and fails to build.

Explicitly disable vapi until a fix for vapi is made.

---
 package/gssdp/gssdp.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/gssdp/gssdp.mk +2 -1
index 4589517691..071ad00109 100644
@@ -14,7 +14,8 @@ GSSDP_INSTALL_STAGING = YES
 GSSDP_DEPENDENCIES = host-pkgconf libglib2 libsoup
 GSSDP_CONF_OPTS = \
 	-Dexamples=false \
-	-Dintrospection=false
+	-Dintrospection=false \
+	-Dvapi=false
 
 ifeq ($(BR2_PACKAGE_LIBGTK3),y)
 GSSDP_DEPENDENCIES += libgtk3
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 package/gssdp: explicitly disable vapi

Adam, All,

On 2020-03-15 09:41 -0700, aduskett at gmail.com spake thusly:

Quoted 19 lines

From: Adam Duskett <[email protected]>

Currently, vapi support does not work with meson due to meson calling vapigen directly instead of the vala wrapper. As such, when building typelib files for gobject-introspection, vapigen fails to find the proper .gir files and fails to build.

Explicitly disable vapi until a fix for vapi is made.

---
 package/gssdp/gssdp.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/gssdp/gssdp.mk +0 -0
index 4589517691..071ad00109 100644

package/gssdp/gssdp.mk GSSDP_INSTALL_STAGING = YES · line 18

Quoted 6 lines
package/gssdp/gssdp.mk +2 -1
@@ -14,7 +14,8 @@ GSSDP_INSTALL_STAGING = YES
 GSSDP_DEPENDENCIES = host-pkgconf libglib2 libsoup
 GSSDP_CONF_OPTS = \
 	-Dexamples=false \
-	-Dintrospection=false
+	-Dintrospection=false \
+	-Dvapi=false

Sorry, no: that's two different fixes, so should be two different patches:
- one to explicitly disable vapi support
- one to enable instrospection

Regards,
Yann E. MORIN.

Quoted 9 lines
package/gssdp/gssdp.mk +0 -0
 ifeq ($(BR2_PACKAGE_LIBGTK3),y)
 GSSDP_DEPENDENCIES += libgtk3
Signature · 6 lines
2.24.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/gssdp: explicitly disable vapi

Adam, All,

On 2020-03-15 17:47 +0100, Yann E. MORIN spake thusly:

Quoted 14 lines

On 2020-03-15 09:41 -0700, aduskett at gmail.com spake thusly:

Quoted 13 lines

From: Adam Duskett <[email protected]>
Currently, vapi support does not work with meson due to meson calling vapigen directly instead of the vala wrapper. As such, when building typelib files for gobject-introspection, vapigen fails to find the proper .gir files and fails to build.

Explicitly disable vapi until a fix for vapi is made.

---
 package/gssdp/gssdp.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines

package/gssdp/gssdp.mk GSSDP_INSTALL_STAGING = YES · line 18

Quoted 11 lines
package/gssdp/gssdp.mk +2 -1
index 4589517691..071ad00109 100644
@@ -14,7 +14,8 @@ GSSDP_INSTALL_STAGING = YES
 GSSDP_DEPENDENCIES = host-pkgconf libglib2 libsoup
 GSSDP_CONF_OPTS = \
 	-Dexamples=false \
-	-Dintrospection=false
+	-Dintrospection=false \
+	-Dvapi=false

Sorry, no: that's two different fixes, so should be two different patches:
- one to explicitly disable vapi support
- one to enable instrospection

And I was being stupid here: the patch does not enable introspection, so it is good...

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 24 lines

Regards,
Yann E. MORIN.

Quoted 9 lines
package/gssdp/gssdp.mk +0 -0
 ifeq ($(BR2_PACKAGE_LIBGTK3),y)
 GSSDP_DEPENDENCIES += libgtk3
Signature · 6 lines
2.24.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/gssdp: explicitly disable vapi

In reply to aduskett at gmail.com
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"aduskett" == aduskett <[email protected]> writes:

From: Adam Duskett <[email protected]>
Currently, vapi support does not work with meson due to meson calling vapigen directly instead of the vala wrapper. As such, when building typelib files for gobject-introspection, vapigen fails to find the proper .gir files and fails to build.

Explicitly disable vapi until a fix for vapi is made.

Committed to 2020.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard