Skip to contentSkip to conversation

staging: rtl8712: Fixes for simple typos in C comments

PATCH In review R Veera Kumar 3 participants 4 messages Mar 12, 2020 – Mar 16, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8712: Fixes for simple typos in C comments

Fixes for simple typos in C comments.
Found using checkpatch.pl.

---
 drivers/staging/rtl8712/rtl871x_cmd.h  | 2 +-
 drivers/staging/rtl8712/rtl871x_recv.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8712/rtl871x_cmd.h +1 -1
index 98d7fbfce1a5..254182a6ce8e 100644
@@ -478,7 +478,7 @@ struct drvint_cmd_parm {
 	unsigned char *pbuf;
 };
 
-/*------------------- Below are used for RF/BB tunning ---------------------*/
+/*------------------- Below are used for RF/BB tuning ---------------------*/
 
 struct	setantenna_parm {
 	u8	tx_antset;
drivers/staging/rtl8712/rtl871x_recv.h +2 -2
index 0146a774e19d..e93f356ed2b0 100644
@@ -53,7 +53,7 @@ struct rx_pkt_attrib {
 	u8	privacy; /* in frame_ctrl field */
 	u8	bdecrypted;
 	int	hdrlen;	 /* the WLAN Header Len */
-	int	encrypt; /* 0 no encrypt. != 0 encrypt algorith */
+	int	encrypt; /* 0 no encrypt. != 0 encrypt algorithm */
 	int	iv_len;
 	int	icv_len;
 	int	priority;
@@ -105,7 +105,7 @@ struct recv_priv {
 	u8 *precv_buf;    /* 4 alignment */
 	struct  __queue	free_recv_buf_queue;
 	u32	free_recv_buf_queue_cnt;
-	/* For the phy informatiom */
+	/* For the phy information */
 	s8 rssi;
 	u8 signal;
 	u8 noise;
Signature · 1 line
2.20.1
#1 lore raw

Hi,

Quoted 2 lines · On Thu, 12 Mar 2020 14:40:48 +0530 R Veera Kumar <[email protected]> wrote:

Fixes for simple typos in C comments.
Found using checkpatch.pl.

This looks good to me, except for the same points Julia had on your
patch:
"[Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument"

Can you please fix that up (title and description) and resend?

Signature · 1 line
Stefano
#2 lore raw
Quoted 5 lines · Stefano Brivio

Hi,

On Thu, 12 Mar 2020 14:40:48 +0530
R Veera Kumar <[email protected]> wrote:

Quoted 9 lines
Quoted 2 lines

Fixes for simple typos in C comments.
Found using checkpatch.pl.

This looks good to me, except for the same points Julia had on your
patch:
"[Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument"

Can you please fix that up (title and description) and resend?

But, this patch has already been accepted by Greg KH and is in staging-testing and staging-next branch. May be late.

Regards,
Veera

Quoted 3 lines
Signature · 1 line
Stefano
#3 lore raw
Quoted 13 lines · R Veera Kumar
Quoted 12 lines · Stefano Brivio

Hi,

Quoted 2 lines · On Thu, 12 Mar 2020 14:40:48 +0530 R Veera Kumar <[email protected]> wrote:

Fixes for simple typos in C comments.
Found using checkpatch.pl.

This looks good to me, except for the same points Julia had on your
patch:
"[Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument"

Quoted 5 lines
Quoted 2 lines

Can you please fix that up (title and description) and resend?

But, this patch has already been accepted by Greg KH and is in staging-testing and staging-next branch. May be late.

Yes, you can let it go.

julia

Quoted 13 lines

Regards,
Veera

Quoted 3 lines

--
Stefano

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200316012751.GA608%40tulip.local.