Skip to contentSkip to conversation

counter: 104-quad-8: Add lock guards - filter clock prescaler

PATCH Applied Syed Nayyar Waris 3 participants 4 messages Mar 16, 2020 – Jun 14, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v5 3/3 counter: 104-quad-8: Add lock guards - filter clock prescaler

Add lock protection from race conditions to the 104-quad-8 counter driver for filter clock prescaler code changes. Mutex calls used for protection.

---
Changes in v5:
- Change spin lock calls to mutex lock calls.
- Modify the title description.

 drivers/counter/104-quad-8.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/counter/104-quad-8.c +4 -0
index 9dab190..b268165 100644
@@ -1230,6 +1230,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	if (ret)
 		return ret;
 
+	mutex_lock(&priv->lock);
+
 	priv->fck_prescaler[channel_id] = prescaler;
 
 	/* Reset Byte Pointer */
@@ -1240,6 +1242,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	outb(QUAD8_CTR_RLD | QUAD8_RLD_RESET_BP | QUAD8_RLD_PRESET_PSC,
 	     base_offset + 1);
 
+	mutex_unlock(&priv->lock);
+
 	return len;
 }
 
Signature · 1 line
2.7.4
#2 lore raw
Quoted 6 lines · William Breathitt Gray
Quoted 4 lines · Syed Nayyar Waris

Add lock protection from race conditions to the 104-quad-8 counter driver for filter clock prescaler code changes. Mutex calls used for protection.

Quoted 7 lines
Quoted 5 lines

---
Changes in v5:
- Change spin lock calls to mutex lock calls.
- Modify the title description.

Adding the 'Fixes' tag:

Fixes 9b74dddf79be ("counter: 104-quad-8: Support Filter Clock Prescaler")

Regards
Syed Nayyar Waris

maintainer
#3 lore raw
Quoted 14 lines · On Sun, 7 Jun 2020 10:55:08 +0530 Syed Nayyar Waris <[email protected]>…
Quoted 12 lines · William Breathitt Gray
Quoted 9 lines · Syed Nayyar Waris

Add lock protection from race conditions to the 104-quad-8 counter driver for filter clock prescaler code changes. Mutex calls used for protection.

---
Changes in v5:
- Change spin lock calls to mutex lock calls.
- Modify the title description.

Quoted 5 lines
Quoted 1 line

Adding the 'Fixes' tag:

Fixes 9b74dddf79be ("counter: 104-quad-8: Support Filter Clock Prescaler")

Replace hash with upstream one and applied to the fixes-togreg branch of iio.git Thanks,

Jonathan

Quoted 3 lines

Regards
Syed Nayyar Waris