package/syslog-ng: fix build if net-snmp is installed on the host
PATCH 1/1 package/syslog-ng: fix build if net-snmp is installed on the host
From: Thomas De Schampheleire <[email protected]>
If syslog-ng is selected in Buildroot and net-snmp is not, but net-snmp is found on the host machine (at least its net-snmp-config script) then compilation of syslog-ng fails with:
CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo
arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17397: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo] Error 1 make[3]: *** Waiting for unfinished jobs....
arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17404: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo] Error 1 arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17411: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo] Error 1 make[2]: *** [Makefile:21428: all-recursive] Error 1
make[1]: *** [Makefile:8740: all] Error 2
make[1]: Leaving directory '.../buildroot/output/build/syslog-ng-3.25.1'
make: *** [package/pkg-generic.mk:269: .../buildroot/output/build/syslog-ng-3.25.1/.stamp_built] Error 2
The path /usr/include is obtained via /usr/bin/net-snmp-config.
The fix comprises two parts:
1. only enable net-snmp support in syslog-ng if the net-snmp package is enabled in Buildroot
2. for the case where net-snmp is selected in Buildroot, fix the configure script of syslog-ng to allow parsing --with-netsnmp=<path> correctly.
--- .../0002-configure.ac-fix-with-netsnmp.patch | 41 +++++++++++++++++++ package/syslog-ng/syslog-ng.mk | 8 ++++ 2 files changed, 49 insertions(+) create mode 100644 package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch
package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch new file +41 -0
@@ -0,0 +1,41 @@ +From 39ab118a7e79b223941b50b372c8ed51f0e21f4b Mon Sep 17 00:00:00 2001 +From: Thomas De Schampheleire <[email protected]> +Date: Mon, 16 Mar 2020 15:41:03 +0100 +Subject: [PATCH] configure.ac: fix --with-netsnmp + +The option '--with-net-snmp' did not work, because later checks were using +the variable '$with_netsnmp' rather than '$with_net_snmp'. + +There are two possible solutions: +- make the option '--with-netsnmp' +- change the internal variables + +Taking into account that latest upstream has moved away from autotools and +towards cmake, we opt for the first option that has the least amount of +changes. + +Signed-off-by: Thomas De Schampheleire <[email protected]> +Upstream-status: not applicable (latest upstream moved to cmake) + +--- + configure.ac | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/configure.ac b/configure.ac +index bfc85c32d..392ab8bf3 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -148,8 +148,8 @@ AC_ARG_WITH(libnet, + , + [with_libnet=""]) + +-AC_ARG_WITH(net-snmp, +- [ --with-net-snmp=path use path to net-snmp-config script], ++AC_ARG_WITH(netsnmp, ++ [ --with-netsnmp=path use path to net-snmp-config script], + , + [with_netsnmp=""]) + +-- +2.24.1 +
package/syslog-ng/syslog-ng.mk +8 -0
@@ -97,6 +97,14 @@ else SYSLOG_NG_CONF_OPTS += --disable-systemd endif +ifeq ($(BR2_PACKAGE_NETSNMP),y) +SYSLOG_NG_DEPENDENCIES += netsnmp +SYSLOG_NG_CONF_OPTS += --enable-snmp-dest +SYSLOG_NG_CONF_OPTS += --with-netsnmp="$(STAGING_DIR)/usr/bin" +else +SYSLOG_NG_CONF_OPTS += --disable-snmp-dest +endif + define SYSLOG_NG_INSTALL_INIT_SYSV $(INSTALL) -m 0755 -D package/syslog-ng/S01syslog-ng \ $(TARGET_DIR)/etc/init.d/S01syslog-ng
Signature · 1 line
2.24.1
PATCH 1/1 package/syslog-ng: fix build if net-snmp is installed on the host
Hi Thomas,
Quoted 24 lines · Thomas De Schampheleire
From: Thomas De Schampheleire <[email protected]>
If syslog-ng is selected in Buildroot and net-snmp is not, but net-snmp is found on the host machine (at least its net-snmp-config script) then compilation of syslog-ng fails with:
CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.loarm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17397: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo] Error 1 make[3]: *** Waiting for unfinished jobs....
arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17404: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo] Error 1 arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17411: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo] Error 1 make[2]: *** [Makefile:21428: all-recursive] Error 1
make[1]: *** [Makefile:8740: all] Error 2
make[1]: Leaving directory '.../buildroot/output/build/syslog-ng-3.25.1'
make: *** [package/pkg-generic.mk:269: .../buildroot/output/build/syslog-ng-3.25.1/.stamp_built] Error 2The path
/usr/includeis obtained via/usr/bin/net-snmp-config.
Quoted 7 lines
The fix comprises two parts:
1. only enable net-snmp support in syslog-ng if the net-snmp package is enabled in Buildroot
2. for the case where net-snmp is selected in Buildroot, fix the configure script of syslog-ng to allow parsing --with-netsnmp=<path> correctly.Signed-off-by Thomas De Schampheleire <[email protected]>
One comment below, regardless
Quoted 20 lines
--- .../0002-configure.ac-fix-with-netsnmp.patch | 41 +++++++++++++++++++ package/syslog-ng/syslog-ng.mk | 8 ++++ 2 files changed, 49 insertions(+) create mode 100644 package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patchpackage/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch new file +8
-0@@ -0,0 +1,41 @@ +From 39ab118a7e79b223941b50b372c8ed51f0e21f4b Mon Sep 17 00:00:00 2001 +From: Thomas De Schampheleire <[email protected]> +Date: Mon, 16 Mar 2020 15:41:03 +0100 +Subject: [PATCH] configure.ac: fix --with-netsnmp + +The option '--with-net-snmp' did not work, because later checks were using +the variable '$with_netsnmp' rather than '$with_net_snmp'. +
package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch line 18
Quoted 10 lines
package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch new file +10
-0+There are two possible solutions: +- make the option '--with-netsnmp' +- change the internal variables + +Taking into account that latest upstream has moved away from autotools and +towards cmake, we opt for the first option that has the least amount of +changes. + +Signed-off-by: Thomas De Schampheleire <[email protected]> +Upstream-status: not applicable (latest upstream moved to cmake)
Actually upstream are supporting both cmake and autotools so it's probably worth submitting.
Quoted 45 lines
package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch new file +23
-0+ +--- + configure.ac | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/configure.ac b/configure.ac +index bfc85c32d..392ab8bf3 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -148,8 +148,8 @@ AC_ARG_WITH(libnet, + , + [with_libnet=""]) + +-AC_ARG_WITH(net-snmp, +- [ --with-net-snmp=path use path to net-snmp-config script], ++AC_ARG_WITH(netsnmp, ++ [ --with-netsnmp=path use path to net-snmp-config script], + , + [with_netsnmp=""]) + +-- +2.24.1 +package/syslog-ng/syslog-ng.mk +8
-1@@ -97,6 +97,14 @@ else SYSLOG_NG_CONF_OPTS += --disable-systemd endif +ifeq ($(BR2_PACKAGE_NETSNMP),y) +SYSLOG_NG_DEPENDENCIES += netsnmp +SYSLOG_NG_CONF_OPTS += --enable-snmp-dest +SYSLOG_NG_CONF_OPTS += --with-netsnmp="$(STAGING_DIR)/usr/bin" +else +SYSLOG_NG_CONF_OPTS += --disable-snmp-dest +endif + define SYSLOG_NG_INSTALL_INIT_SYSV $(INSTALL) -m 0755 -D package/syslog-ng/S01syslog-ng \ $(TARGET_DIR)/etc/init.d/S01syslog-ng --2.24.1
PATCH 1/1 package/syslog-ng: fix build if net-snmp is installed on the host
El mar., 17 mar. 2020 a las 0:23, Chris Packham
(<[email protected]>) escribi?:
Quoted 66 lines
Hi Thomas,
Quoted 24 lines · Thomas De Schampheleire
From: Thomas De Schampheleire <[email protected]>
If syslog-ng is selected in Buildroot and net-snmp is not, but net-snmp is found on the host machine (at least its net-snmp-config script) then compilation of syslog-ng fails with:
CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.loarm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17397: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo] Error 1 make[3]: *** Waiting for unfinished jobs....
arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17404: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo] Error 1 arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17411: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo] Error 1 make[2]: *** [Makefile:21428: all-recursive] Error 1
make[1]: *** [Makefile:8740: all] Error 2
make[1]: Leaving directory '.../buildroot/output/build/syslog-ng-3.25.1'
make: *** [package/pkg-generic.mk:269: .../buildroot/output/build/syslog-ng-3.25.1/.stamp_built] Error 2The path
/usr/includeis obtained via/usr/bin/net-snmp-config.Quoted 7 lines
The fix comprises two parts:
1. only enable net-snmp support in syslog-ng if the net-snmp package is enabled in Buildroot
2. for the case where net-snmp is selected in Buildroot, fix the configure script of syslog-ng to allow parsing --with-netsnmp=<path> correctly.Signed-off-by Thomas De Schampheleire <[email protected]>One comment below, regardless
Reviewed-by Chris Packham <[email protected]>Quoted 25 lines
--- .../0002-configure.ac-fix-with-netsnmp.patch | 41 +++++++++++++++++++ package/syslog-ng/syslog-ng.mk | 8 ++++ 2 files changed, 49 insertions(+) create mode 100644 package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patchpackage/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch new file +13
-0@@ -0,0 +1,41 @@ +From 39ab118a7e79b223941b50b372c8ed51f0e21f4b Mon Sep 17 00:00:00 2001 +From: Thomas De Schampheleire <[email protected]> +Date: Mon, 16 Mar 2020 15:41:03 +0100 +Subject: [PATCH] configure.ac: fix --with-netsnmp + +The option '--with-net-snmp' did not work, because later checks were using +the variable '$with_netsnmp' rather than '$with_net_snmp'. + +There are two possible solutions: +- make the option '--with-netsnmp' +- change the internal variables + +Taking into account that latest upstream has moved away from autotools and
Quoted 9 lines
package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch line 18
Quoted 5 lines
package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch new file +5
-0+towards cmake, we opt for the first option that has the least amount of +changes. + +Signed-off-by: Thomas De Schampheleire <[email protected]> +Upstream-status: not applicable (latest upstream moved to cmake)Actually upstream are supporting both cmake and autotools so it's probably worth submitting.
Thanks, I had misunderstood it.
I now sent a patch upstream, although in light of this misunderstanding I opted to fix the --with-net-snmp option instead of renaming it to --with-netsnmp. As a result, if the patch is accepted upstream, we'll have to update Buildroot accordingly too.
Yann E. MORIN
AppliedPATCH 1/1 package/syslog-ng: fix build if net-snmp is installed on the host
In reply to Thomas De SchampheleireThomas, All,
On 2020-03-16 16:01 +0100, Thomas De Schampheleire spake thusly:
Quoted 23 lines
From: Thomas De Schampheleire <[email protected]>
If syslog-ng is selected in Buildroot and net-snmp is not, but net-snmp is found on the host machine (at least its net-snmp-config script) then compilation of syslog-ng fails with:
CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.loarm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17397: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo] Error 1 make[3]: *** Waiting for unfinished jobs....
arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17404: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo] Error 1 arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17411: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo] Error 1 make[2]: *** [Makefile:21428: all-recursive] Error 1
make[1]: *** [Makefile:8740: all] Error 2
make[1]: Leaving directory '.../buildroot/output/build/syslog-ng-3.25.1'
make: *** [package/pkg-generic.mk:269: .../buildroot/output/build/syslog-ng-3.25.1/.stamp_built] Error 2The path
/usr/includeis obtained via/usr/bin/net-snmp-config.
Quoted 7 lines
The fix comprises two parts:
1. only enable net-snmp support in syslog-ng if the net-snmp package is enabled in Buildroot
2. for the case where net-snmp is selected in Buildroot, fix the configure script of syslog-ng to allow parsing --with-netsnmp=<path> correctly.Signed-off-by Thomas De Schampheleire <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 79 lines
--- .../0002-configure.ac-fix-with-netsnmp.patch | 41 +++++++++++++++++++ package/syslog-ng/syslog-ng.mk | 8 ++++ 2 files changed, 49 insertions(+) create mode 100644 package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patchpackage/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch new file +41
-0@@ -0,0 +1,41 @@ +From 39ab118a7e79b223941b50b372c8ed51f0e21f4b Mon Sep 17 00:00:00 2001 +From: Thomas De Schampheleire <[email protected]> +Date: Mon, 16 Mar 2020 15:41:03 +0100 +Subject: [PATCH] configure.ac: fix --with-netsnmp + +The option '--with-net-snmp' did not work, because later checks were using +the variable '$with_netsnmp' rather than '$with_net_snmp'. + +There are two possible solutions: +- make the option '--with-netsnmp' +- change the internal variables + +Taking into account that latest upstream has moved away from autotools and +towards cmake, we opt for the first option that has the least amount of +changes. + +Signed-off-by: Thomas De Schampheleire <[email protected]> +Upstream-status: not applicable (latest upstream moved to cmake) + +--- + configure.ac | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/configure.ac b/configure.ac +index bfc85c32d..392ab8bf3 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -148,8 +148,8 @@ AC_ARG_WITH(libnet, + , + [with_libnet=""]) + +-AC_ARG_WITH(net-snmp, +- [ --with-net-snmp=path use path to net-snmp-config script], ++AC_ARG_WITH(netsnmp, ++ [ --with-netsnmp=path use path to net-snmp-config script], + , + [with_netsnmp=""]) + +-- +2.24.1 +package/syslog-ng/syslog-ng.mk +8
-0@@ -97,6 +97,14 @@ else SYSLOG_NG_CONF_OPTS += --disable-systemd endif +ifeq ($(BR2_PACKAGE_NETSNMP),y) +SYSLOG_NG_DEPENDENCIES += netsnmp +SYSLOG_NG_CONF_OPTS += --enable-snmp-dest +SYSLOG_NG_CONF_OPTS += --with-netsnmp="$(STAGING_DIR)/usr/bin" +else +SYSLOG_NG_CONF_OPTS += --disable-snmp-dest +endif + define SYSLOG_NG_INSTALL_INIT_SYSV $(INSTALL) -m 0755 -D package/syslog-ng/S01syslog-ng \ $(TARGET_DIR)/etc/init.d/S01syslog-ngSignature · 6 lines
2.24.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/syslog-ng: fix build if net-snmp is installed on the host
In reply to Thomas De SchampheleireQuoted 24 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> If syslog-ng is selected in Buildroot and net-snmp is not, but net-snmp is found on the host machine (at least its net-snmp-config script) then compilation of syslog-ng fails with:
CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo CC modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.loarm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17397: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo] Error 1 make[3]: *** Waiting for unfinished jobs....
arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17404: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo] Error 1 arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include' make[3]: *** [Makefile:17411: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo] Error 1 make[2]: *** [Makefile:21428: all-recursive] Error 1
make[1]: *** [Makefile:8740: all] Error 2
make[1]: Leaving directory '.../buildroot/output/build/syslog-ng-3.25.1'
make: *** [package/pkg-generic.mk:269: .../buildroot/output/build/syslog-ng-3.25.1/.stamp_built] Error 2The path
/usr/includeis obtained via/usr/bin/net-snmp-config.
Quoted 7 lines
The fix comprises two parts:
1. only enable net-snmp support in syslog-ng if the net-snmp package is enabled in Buildroot
2. for the case where net-snmp is selected in Buildroot, fix the configure script of syslog-ng to allow parsing --with-netsnmp=<path> correctly.Signed-off-by Thomas De Schampheleire <[email protected]>
Committed to 2019.11.x and 2020.02.x, thanks. 2019.02.x uses an older syslog-ng version and the patch does not apply as is.
Signature · 1 line
Bye, Peter Korsgaard