support/testing/: change python-gobject to use prebuilt kernel
PATCH 1/1 support/testing/: change python-gobject to use prebuilt kernel
From: Adam Duskett <[email protected]>
This change significantly reduces the ammount of time needed to run the test.
Select a cortext_a9 and a external linaro toolchain due to the need for a glibc based toolchain, as the default TestPythonPackageBase.config toolchain is a uClibc toolchain.
--- .../tests/package/test_python_gobject.py | 25 +++++++------------ 1 file changed, 9 insertions(+), 16 deletions(-)
support/testing/tests/package/test_python_gobject.py +9 -16
@@ -3,31 +3,24 @@ from tests.package.test_python import TestPythonPackageBase class TestPythonPy3Gobject(TestPythonPackageBase): __test__ = True - config = \ + config = TestPythonPackageBase.config + \ """ - BR2_aarch64=y BR2_TOOLCHAIN_EXTERNAL=y - BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0" - BR2_LINUX_KERNEL=y - BR2_LINUX_KERNEL_CUSTOM_VERSION=y - BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.7" - BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y - BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config" - BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y BR2_TARGET_ROOTFS_CPIO=y - BR2_TARGET_ROOTFS_CPIO_GZIP=y + BR2_cortex_a9=y + BR2_ARM_ENABLE_VFP=y + BR2_ARM_EABIHF=y + BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y BR2_PACKAGE_GOBJECT_INTROSPECTION=y BR2_PACKAGE_PYTHON3=y BR2_PACKAGE_PYTHON_GOBJECT=y """ def login(self): - img = os.path.join(self.builddir, "images", "rootfs.cpio.gz") - kern = os.path.join(self.builddir, "images", "Image") - self.emulator.boot(arch="aarch64", - kernel=kern, - kernel_cmdline=["console=ttyAMA0"], - options=["-M", "virt", "-cpu", "cortex-a57", "-m", "512M", "-initrd", img]) + img = os.path.join(self.builddir, "images", "rootfs.cpio") + self.emulator.boot(arch="armv7", + kernel="builtin", + options=["-initrd", img]) self.emulator.login() sample_scripts = ["tests/package/sample_python_gobject.py"]
Signature · 1 line
2.24.1
PATCH 1/1 support/testing/: change python-gobject to use prebuilt kernel
Hello Adam,
Quoted 6 lines · On Mon, 16 Mar 2020 08:34:59 -0700 aduskett at gmail.com wrote:
From: Adam Duskett <[email protected]>
This change significantly reduces the ammount of time needed to run the test.
Select a
cortext_a9and a external linaro toolchain due to the need for a
cortext -> cortex
Quoted 4 lines
glibc based toolchain, as the default TestPythonPackageBase.config toolchain is a uClibc toolchain.
Signed-off-by Adam Duskett <[email protected]>
The idea is good, but I have some comment below.
support/testing/tests/package/test_python_gobject.py from tests.package.test_python import TestPythonPackageBase · line 6
Quoted 10 lines
support/testing/tests/package/test_python_gobject.py +1
-1@@ -3,31 +3,24 @@ from tests.package.test_python import TestPythonPackageBase class TestPythonPy3Gobject(TestPythonPackageBase): __test__ = True - config = \ + config = TestPythonPackageBase.config + \
I don't think it makes much sense to re-use TestPythonPackageBase.config. Indeed, what is does is:
config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
"""
BR2_TARGET_ROOTFS_CPIO=y
# BR2_TARGET_ROOTFS_TAR is not set
"""and infra.basetest.BASIC_TOOLCHAIN_CONFIG only defines the toolchain options.
So could instead just use a configuration that is completely defined here ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Yann E. MORIN
AppliedPATCH 1/1 support/testing/: change python-gobject to use prebuilt kernel
In reply to aduskett at gmail.comAdam, All,
On 2020-03-16 08:34 -0700, aduskett at gmail.com spake thusly:
Quoted 10 lines
From: Adam Duskett <[email protected]>
This change significantly reduces the ammount of time needed to run the test.
Select a
cortext_a9and a external linaro toolchain due to the need for a glibc based toolchain, as the default TestPythonPackageBase.config toolchain is a uClibc toolchain.Signed-off-by Adam Duskett <[email protected]>
Applied to master, thanks.
Thomas and I arrived at the same conclusion each on our side, to change the config to be entirely defined in the test case, so I just did that I pushed.
Regards,
Yann E. MORIN.
Quoted 56 lines
--- .../tests/package/test_python_gobject.py | 25 +++++++------------ 1 file changed, 9 insertions(+), 16 deletions(-)support/testing/tests/package/test_python_gobject.py +9
-16@@ -3,31 +3,24 @@ from tests.package.test_python import TestPythonPackageBase class TestPythonPy3Gobject(TestPythonPackageBase): __test__ = True - config = \ + config = TestPythonPackageBase.config + \ """ - BR2_aarch64=y BR2_TOOLCHAIN_EXTERNAL=y - BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0" - BR2_LINUX_KERNEL=y - BR2_LINUX_KERNEL_CUSTOM_VERSION=y - BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.7" - BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y - BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config" - BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y BR2_TARGET_ROOTFS_CPIO=y - BR2_TARGET_ROOTFS_CPIO_GZIP=y + BR2_cortex_a9=y + BR2_ARM_ENABLE_VFP=y + BR2_ARM_EABIHF=y + BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y BR2_PACKAGE_GOBJECT_INTROSPECTION=y BR2_PACKAGE_PYTHON3=y BR2_PACKAGE_PYTHON_GOBJECT=y """ def login(self): - img = os.path.join(self.builddir, "images", "rootfs.cpio.gz") - kern = os.path.join(self.builddir, "images", "Image") - self.emulator.boot(arch="aarch64", - kernel=kern, - kernel_cmdline=["console=ttyAMA0"], - options=["-M", "virt", "-cpu", "cortex-a57", "-m", "512M", "-initrd", img]) + img = os.path.join(self.builddir, "images", "rootfs.cpio") + self.emulator.boot(arch="armv7", + kernel="builtin", + options=["-initrd", img]) self.emulator.login() sample_scripts = ["tests/package/sample_python_gobject.py"]Signature · 6 lines
2.24.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'