mlx5: Remove uninitialized use of key in mlx5_core_create_mkey
Subsystems (4)
PATCH 1/1 mlx5: Remove uninitialized use of key in mlx5_core_create_mkey
Clang warns:
../drivers/net/ethernet/mellanox/mlx5/core/mr.c:63:21: warning: variable 'key' is uninitialized when used here [-Wuninitialized]
mkey_index, key, mkey->key);
^~~
../drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h:54:6: note:
expanded from macro 'mlx5_core_dbg'
##__VA_ARGS__)
^~~~~~~~~~~
../include/linux/dev_printk.h:114:39: note: expanded from macro
'dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
../include/linux/dynamic_debug.h:158:19: note: expanded from macro
'dynamic_dev_dbg'
dev, fmt, ##__VA_ARGS__)
^~~~~~~~~~~
../include/linux/dynamic_debug.h:143:56: note: expanded from macro
'_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
../include/linux/dynamic_debug.h:125:15: note: expanded from macro
'__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
../drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:8: note: initialize
the variable 'key' to silence this warning
u8 key;
^
= '\0'1 warning generated.
key's initialization was removed in commit fc6a9f86f08a ("{IB,net}/mlx5:
Assign mkey variant in mlx5_ib only") but its use was not fully removed. Remove it now so that there is no more warning.
--- drivers/net/ethernet/mellanox/mlx5/core/mr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/mr.c +1 -3
@@ -44,7 +44,6 @@ int mlx5_core_create_mkey(struct mlx5_core_dev *dev,u32 mkey_index;void *mkc;int err; -u8 key;MLX5_SET (create_mkey_in, in, opcode,MLX5_CMD_OP_CREATE_MKEY );
@@ -59,8 +58,7 @@ int mlx5_core_create_mkey(struct mlx5_core_dev *dev, mkey->key |=mlx5_idx_to_mkey (mkey_index); mkey->pd =MLX5_GET (mkc, mkc, pd); -mlx5_core_dbg (dev,"out 0x%x, key 0x%x, mkey 0x%x\n" , - mkey_index, key, mkey->key); +mlx5_core_dbg (dev,"out 0x%x, mkey 0x%x\n" , mkey_index, mkey->key);return 0 ; }EXPORT_SYMBOL (mlx5_core_create_mkey);
Signature · 1 line
2.26.0.rc1
Quoted 34 lines · Nathan Chancellor
Clang warns:
../drivers/net/ethernet/mellanox/mlx5/core/mr.c:63:21: warning: variable 'key' is uninitialized when used here [-Wuninitialized]mkey_index, key, mkey->key); ^~~ ../drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h:54:6: note: expanded from macro 'mlx5_core_dbg' ##__VA_ARGS__) ^~~~~~~~~~~ ../include/linux/dev_printk.h:114:39: note: expanded from macro 'dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ ../include/linux/dynamic_debug.h:158:19: note: expanded from macro 'dynamic_dev_dbg' dev, fmt, ##__VA_ARGS__) ^~~~~~~~~~~ ../include/linux/dynamic_debug.h:143:56: note: expanded from macro '_dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~ ../include/linux/dynamic_debug.h:125:15: note: expanded from macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ ../drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:8: note: initialize the variable 'key' to silence this warning u8 key; ^ = '\0'1 warning generated.
Quoted 7 lines
key's initialization was removed in commit
fc6a9f86f08a("{IB,net}/mlx5:
Assign mkey variant inmlx5_ibonly") but its use was not fully removed. Remove it now so that there is no more warning.Fixes fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib only")Signed-off-by Nathan Chancellor <[email protected]>
Thanks for the patch and analysis, looks good to me!
Quoted 30 lines
--- drivers/net/ethernet/mellanox/mlx5/core/mr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/net/ethernet/mellanox/mlx5/core/mr.c +1
-4@@ -44,7 +44,6 @@ int mlx5_core_create_mkey(struct mlx5_core_dev *dev,u32 mkey_index;void *mkc;int err; -u8 key;MLX5_SET (create_mkey_in, in, opcode,MLX5_CMD_OP_CREATE_MKEY );@@ -59,8 +58,7 @@ int mlx5_core_create_mkey(struct mlx5_core_dev *dev, mkey->key |=mlx5_idx_to_mkey (mkey_index); mkey->pd =MLX5_GET (mkc, mkc, pd); -mlx5_core_dbg (dev,"out 0x%x, key 0x%x, mkey 0x%x\n" , - mkey_index, key, mkey->key); +mlx5_core_dbg (dev,"out 0x%x, mkey 0x%x\n" , mkey_index, mkey->key);return 0 ; }EXPORT_SYMBOL (mlx5_core_create_mkey); --2.26.0.rc1
--
Signature · 2 lines
Thanks, ~Nick Desaulniers
Saeed Mahameed
AppliedQuoted 43 lines · Nathan Chancellor
Clang warns:
../drivers/net/ethernet/mellanox/mlx5/core/mr.c:63:21: warning:
variable
'key' is uninitialized when used here [-Wuninitialized]mkey_index, key, mkey->key); ^~~ ../drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h:54:6: note: expanded from macro 'mlx5_core_dbg' ##__VA_ARGS__) ^~~~~~~~~~~ ../include/linux/dev_printk.h:114:39: note: expanded from macro 'dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ ../include/linux/dynamic_debug.h:158:19: note: expanded from macro 'dynamic_dev_dbg' dev, fmt, ##__VA_ARGS__) ^~~~~~~~~~~ ../include/linux/dynamic_debug.h:143:56: note: expanded from macro '_dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~ ~~~~ ../include/linux/dynamic_debug.h:125:15: note: expanded from macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ ../drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:8: note: initialize the variable 'key' to silence this warning u8 key; ^ = '\0'1 warning generated.
key's initialization was removed in commit
fc6a9f86f08a("{IB,net}/mlx5:
Assign mkey variant inmlx5_ibonly") but its use was not fully removed.
Remove it now so that there is no more warning.
Quoted 5 lines
Fixes fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ibonly")
LGTM
applied to mlx5-next
Thanks,
Saeed.