pci: restore access to RTE_VERIFY for Power builds
PATCH 1/1 pci: restore access to RTE_VERIFY for Power builds
The include file rte_debug.h is pulled into x86 builds through the following callchain:
lib/librte_eal/common/include/generic/rte_cycles.h:17, lib/librte_eal/common/include/arch/x86/rte_cycles.h:13, lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18, lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
The PPC specific version of the same callchain does not include rte_debug.h. Add rte_debug.h back into the C files that require it.
--- drivers/bus/ifpga/ifpga_bus.c | 1 + lib/librte_pci/rte_pci.c | 1 + 2 files changed, 2 insertions(+)
drivers/bus/ifpga/ifpga_bus.c +1 -0
@@ -24,6 +24,7 @@#include <rte_kvargs.h> #include <rte_alarm.h> #include <rte_string_fns.h> +#include <rte_debug.h> #include "rte_rawdev.h" #include "rte_rawdev_pmd.h"
lib/librte_pci/rte_pci.c +1 -0
@@ -20,6 +20,7 @@#include <rte_eal.h> #include <rte_string_fns.h> #include <rte_common.h> +#include <rte_debug.h> #include "rte_pci.h"
Signature · 1 line
2.18.1
Quoted 8 lines · David Christensen
The include file
rte_debug.his pulled into x86 builds through the following callchain:
lib/librte_eal/common/include/generic/rte_cycles.h:17,lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
Quoted 8 lines
The PPC specific version of the same callchain does not include
rte_debug.h. Addrte_debug.hback into the C files that require it.Fixes 0dcba5256287 ("pci: remove unneeded includes in public header file")Signed-off-by David Christensen <[email protected]>---
...
Ran ci against this patch (with my ppc64le ci patches included), it ran clean. Results are here:
https://travis-ci.org/github/djlwilder/dpdk/builds/663247710
Quoted 9 lines · David Christensen
The include file
rte_debug.his pulled into x86 builds through the following callchain:
lib/librte_eal/common/include/generic/rte_cycles.h:17,lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
Quoted 4 lines
The PPC specific version of the same callchain does not include
rte_debug.h. Addrte_debug.hback into the C files that require it.Fixes 0dcba5256287 ("pci: remove unneeded includes in public header file")
Quoted 2 lines
Signed-off-by David Christensen <[email protected]>
Signature · 1 line
David Marchand
David Marchand
AppliedQuoted 14 lines · David Marchand
Quoted 12 lines · David Christensen
The include file
rte_debug.his pulled into x86 builds through the following callchain:
lib/librte_eal/common/include/generic/rte_cycles.h:17,lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,The PPC specific version of the same callchain does not include
rte_debug.h. Addrte_debug.hback into the C files that require it.
Quoted 7 lines
Quoted 1 line
Fixes 0dcba5256287 ("pci: remove unneeded includes in public header file")Quoted 2 lines
Signed-off-by David Christensen <[email protected]>Tested-by David Wilder <[email protected]>Acked-by David Marchand <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand
Thanks David.
Quoted 40 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Wednesday, March 18, 2020 3:39
To: David Christensen <[email protected]>
Cc: Xu, Rosen <[email protected]>; Gaetan Rivet <[email protected]>; dev <[email protected]>; Richardson, Bruce <[email protected]>; David Wilder <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] pci: restore access toRTE_VERIFYfor Power buildsQuoted 14 lines · David Marchand
Quoted 12 lines · David Christensen
The include file
rte_debug.his pulled into x86 builds through the following callchain:
lib/librte_eal/common/include/generic/rte_cycles.h:17,lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,The PPC specific version of the same callchain does not include
rte_debug.h. Addrte_debug.hback into the C files that require it.Quoted 8 lines
Quoted 2 lines
Fixes 0dcba5256287 ("pci: remove unneeded includes in public headerfile")
Quoted 2 lines
Signed-off-by David Christensen <[email protected]>Tested-by David Wilder <[email protected]>Acked-by David Marchand <[email protected]>Applied, thanks.
--
David Marchand