Skip to contentSkip to conversation

EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d"

PATCH In review [email protected] 2 participants 2 messages Mar 17, 2020 – Mar 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d"

From: Amy Shih <[email protected]>

Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to register device with error %d", since it is not the error message but the information to notice the user.

---
 drivers/edac/pnd2_edac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/edac/pnd2_edac.c +2 -1
index 933f772..f15d3b4 100644
@@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
 
 	rc = pnd2_probe();
 	if (rc < 0) {
-		pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
+		pnd2_printk(KERN_INFO,
+			    "Failed to register device with error %d.\n", rc);
 		return rc;
 	}
 
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 5 lines · On Tue, 2020-03-17 at 06:28 +0000, [email protected] wrote:

From: Amy Shih <[email protected]>

Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to register device with error %d", since it is not the error message but the information to notice the user.

[]

drivers/edac/pnd2_edac.c

Quoted 1 line
drivers/edac/pnd2_edac.c +0 -0

[]

drivers/edac/pnd2_edac.c static int __init pnd2_init(void) · line 1576

Quoted 7 lines
drivers/edac/pnd2_edac.c +2 -1
@@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
 
 	rc = pnd2_probe();
 	if (rc < 0) {
-		pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
+		pnd2_printk(KERN_INFO,
+			    "Failed to register device with error %d.\n", rc);

So there's no need to use the word "error"
in the output message either.

"Failed to register device - %d\n", rc

would be enough.