Skip to contentSkip to conversation

ASoC: rt5682: remove noisy debug messages

PATCH In review [email protected] 3 participants 4 messages Mar 17, 2020 – Mar 18, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 ASoC: rt5682: remove noisy debug messages

From: Shuming Fan <[email protected]>

Some debug messages are too noisy.
This patch removes it.

---
 sound/soc/codecs/rt5682.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/rt5682.c +2 -2
index 023bc672274b..2ee01e782fe0 100644
@@ -1197,11 +1197,11 @@ static int rt5682_div_sel(struct rt5682_priv *rt5682,
 	}
 
 	for (i = 0; i < size - 1; i++) {
-		pr_info("div[%d]=%d\n", i, div[i]);
+		dev_dbg(rt5682->component->dev, "div[%d]=%d\n", i, div[i]);
 		if (target * div[i] == rt5682->sysclk)
 			return i;
 		if (target * div[i + 1] > rt5682->sysclk) {
-			pr_err("can't find div for sysclk %d\n",
+			dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
 				rt5682->sysclk);
 			return i;
 		}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · On Tue, Mar 17, 2020 at 3:35 PM <[email protected]> wrote:

Some debug messages are too noisy.
This patch removes it.

Suggest to use other words. For example, title: "ASoC: rt5682: make output message less verbose"; message: "Makes output message less verbose by reducing the log severity".

sound/soc/codecs/rt5682.c static int rt5682_div_sel(struct rt5682_priv *rt5682, · line 1205

Quoted 9 lines
        for (i = 0; i < size - 1; i++) {
sound/soc/codecs/rt5682.c +2 -2
-               pr_info("div[%d]=%d\n", i, div[i]);
+               dev_dbg(rt5682->component->dev, "div[%d]=%d\n", i, div[i]);
                if (target * div[i] == rt5682->sysclk)
                        return i;
                if (target * div[i + 1] > rt5682->sysclk) {
-                       pr_err("can't find div for sysclk %d\n",
+                       dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
                                rt5682->sysclk);

Looking at around of the file, use pr_debug( ) here could be more consistent.

maintainer
#2 lore raw
Quoted 6 lines · Tzung-Bi Shih
Quoted 2 lines · On Tue, Mar 17, 2020 at 3:35 PM <[email protected]> wrote:

+ dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",

                                rt5682->sysclk);

Looking at around of the file, use pr_debug( ) here could be more consistent.

It'd be better convert those pr_debug() to dev_dbg()s TBH.

maintainer
#3 lore raw

Applied "ASoC: rt5682: remove noisy debug messages" to the asoc tree

In reply to [email protected]

The patch

ASoC: rt5682: remove noisy debug messages

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

From 243de01deb545e9c288459458e28e5ff0656ca1f Mon Sep 17 00:00:00 2001
From: Shuming Fan <[email protected]>
Date: Tue, 17 Mar 2020 15:33:21 +0800
Subject: [PATCH] ASoC: rt5682: remove noisy debug messages

Some debug messages are too noisy.
This patch removes it.

---
 sound/soc/codecs/rt5682.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/rt5682.c +2 -2
index 7ca02a5e52e9..513429478d27 100644
@@ -1197,11 +1197,11 @@ static int rt5682_div_sel(struct rt5682_priv *rt5682,
 	}
 
 	for (i = 0; i < size - 1; i++) {
-		pr_info("div[%d]=%d\n", i, div[i]);
+		dev_dbg(rt5682->component->dev, "div[%d]=%d\n", i, div[i]);
 		if (target * div[i] == rt5682->sysclk)
 			return i;
 		if (target * div[i + 1] > rt5682->sysclk) {
-			pr_err("can't find div for sysclk %d\n",
+			dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
 				rt5682->sysclk);
 			return i;
 		}
Signature · 1 line
2.20.1