rbd: don't mess with a page vector in rbd_notify_op_lock()
Subsystems (2)
Ilya Dryomov
maintainerPATCH 1/1 rbd: don't mess with a page vector in rbd_notify_op_lock()
rbd_notify_op_lock() isn't interested in a notify reply. Instead of accepting that page vector just to free it, have watch-notify code take care of it.
Signed-off-by Ilya Dryomov <[email protected]>
--- drivers/block/rbd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/block/rbd.c +1 -5
@@ -3754,11 +3754,7 @@ static int __rbd_notify_op_lock(struct rbd_device *rbd_dev,static void rbd_notify_op_lock (struct rbd_device *rbd_dev,enum rbd_notify_op notify_op) { -struct page **reply_pages; -size_t reply_len; - -__rbd_notify_op_lock (rbd_dev, notify_op, &reply_pages, &reply_len); -ceph_release_page_vector (reply_pages,calc_pages_for (0 , reply_len)); +__rbd_notify_op_lock (rbd_dev, notify_op,NULL ,NULL ); }static void rbd_notify_acquired_lock (struct work_struct *work)
Signature · 1 line
2.19.2
Quoted 28 lines · Ilya Dryomov
rbd_notify_op_lock()isn't interested in a notify reply. Instead of accepting that page vector just to free it, have watch-notify code take care of it.Signed-off-by Ilya Dryomov <[email protected]>--- drivers/block/rbd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)drivers/block/rbd.c +1
-6@@ -3754,11 +3754,7 @@ static int __rbd_notify_op_lock(struct rbd_device *rbd_dev,static void rbd_notify_op_lock (struct rbd_device *rbd_dev,enum rbd_notify_op notify_op) { -struct page **reply_pages; -size_t reply_len; - -__rbd_notify_op_lock (rbd_dev, notify_op, &reply_pages, &reply_len); -ceph_release_page_vector (reply_pages,calc_pages_for (0 , reply_len)); +__rbd_notify_op_lock (rbd_dev, notify_op,NULL ,NULL ); }static void rbd_notify_acquired_lock (struct work_struct *work) --
Quoted 2 lines
2.19.2
Reviewed-by Jason Dillaman <[email protected]>
Signature · 1 line
Jason