global_data.h: make <asm-generic/global_data.h> self-contained
PATCH 1/1 global_data.h: make <asm-generic/global_data.h> self-contained
The compiler never knows what 'bd_t' is without including <asm/u-boot.h>.
By changing it to (struct bd_info), the compiler learns it is struct.
Signed-off-by Masahiro Yamada <[email protected]>
---
Maybe, we should replace 'bd_t' with 'struct bd_info' globally by using coccinelle or something.
Linux coding style (Documentation/process/coding-style.rst) apparently discourages typedef for cases like this.
include/asm-generic/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/asm-generic/global_data.h +1 -1
@@ -25,7 +25,7 @@#include <linux/list.h> typedef struct global_data { - bd_t *bd; + struct bd_info *bd; unsigned long flags; unsigned int baudrate; unsigned long cpu_clk; /* CPU clock in Hz! */
Signature · 1 line
2.17.1
PATCH 1/1 global_data.h: make <asm-generic/global_data.h> self-contained
Quoted 5 lines · Masahiro Yamada
The compiler never knows what '
bd_t' is without including <asm/u-boot.h>.By changing it to (struct
bd_info), the compiler learns it is struct.Signed-off-by Masahiro Yamada <[email protected]>
Applied to u-boot/next, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/29bb983c/attachment.sig>