open_posix_testsuite: Enable the testsuite
PATCH 1/1 open_posix_testsuite: Enable the testsuite
Enable open posix testsuite compilation by default
--- testcases/Makefile | 4 ---- 1 file changed, 4 deletions(-)
testcases/Makefile +0 -4
@@ -30,10 +30,6 @@ include $(top_srcdir)/include/mk/env_pre.mk # run). FILTER_OUT_DIRS := kdump -ifneq ($(WITH_OPEN_POSIX_TESTSUITE),yes) -FILTER_OUT_DIRS += open_posix_testsuite -endif - ifneq ($(WITH_REALTIME_TESTSUITE),yes) FILTER_OUT_DIRS += realtime endif
--
2.6.2
PATCH 1/1 open_posix_testsuite: Enable the testsuite
Hi Zou & Xiao,
Do we really need to enable the open_posix_testsuite explicitly? By default, LTP uses "--with-open-posix-testsuite" as the configure parameter to enabling it, is that work for you?
i.e you can include the open_posix_testsuite build by perform ./build.sh
Quoted 30 lines · Zou Wei
Enable open posix testsuite compilation by default
Signed-off-by Zou Wei <[email protected]>--- testcases/Makefile | 4 ---- 1 file changed, 4 deletions(-)testcases/Makefile +0
-5@@ -30,10 +30,6 @@ include $(top_srcdir)/include/mk/env_pre.mk # run). FILTER_OUT_DIRS := kdump -ifneq ($(WITH_OPEN_POSIX_TESTSUITE),yes) -FILTER_OUT_DIRS += open_posix_testsuite -endif - ifneq ($(WITH_REALTIME_TESTSUITE),yes) FILTER_OUT_DIRS += realtime endif --2.6.2
--
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20200317/6a1ba799/attachment-0001.htm>
PATCH 1/1 open_posix_testsuite: Enable the testsuite
Quoted 5 lines · Li Wang
Hi Zou & Xiao,
Do we really need to enable the
open_posix_testsuiteexplicitly? By default, LTP uses "--with-open-posix-testsuite" as the configure parameter to enabling it, is that work for you?
Hi Li,
Agreed. We don't need to enable the open_posix_testsuite unconditionally.
We can enable open_posix_testsuite by ./configure
--with-open-posix-testsuite or ./build.sh.
Thanks,
Xiao Yang
Quoted 2 lines
i.e you can include the
open_posix_testsuitebuild by perform./build.sh
PATCH 1/1 open_posix_testsuite: Enable the testsuite
In reply to Li WangHi!
Quoted 3 lines
Do we really need to enable the
open_posix_testsuiteexplicitly? By default, LTP uses "--with-open-posix-testsuite" as the configure parameter to enabling it, is that work for you?
Even if we wanted to enable openposix by default, which may be a good idea, we should change the default in configure.ac instead with:
configure.ac +1 -1
@@ -256,7 +256,7 @@ AC_ARG_WITH([open-posix-testsuite], [AC_HELP_STRING([--with-open-posix-testsuite], [compile and install the open posix testsuite])], [with_open_posix_testsuite=$withval], - [with_open_posix_testsuite=no] + [with_open_posix_testsuite=yes] ) if test "x$with_open_posix_testsuite" = xyes; then AC_SUBST([WITH_OPEN_POSIX_TESTSUITE],["yes"])
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 open_posix_testsuite: Enable the testsuite
Quoted 9 lines · Cyril Hrubis
Hi!
Quoted 2 lines
Do we really need to enable the
open_posix_testsuiteexplicitly? By default, LTP uses "--with-open-posix-testsuite" as the configureparameter
Quoted 1 line
to enabling it, is that work for you?
Even if we wanted to enable openposix by default, which may be a good idea, we should change the default in configure.ac instead with:
Yes, your method looks better. But I'd suggest giving more time on bug fixing before enabling open_posix_testsuit explicitly, other than publishing that with many build issues. Seems Zou and Xu are working on this part recently, that would be appreciated if more patches work out.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20200317/14fe14f9/attachment.htm>
Enji Cooper
NAKPATCH 1/1 open_posix_testsuite: Enable the testsuite
In reply to Zou WeiNAK.
This will build the suite on the build host, which includes a number of build time tests, which will slow down hosts and
It?s better to flip the default in configure, but I think the build machinery needs to be reworked so runtime tests and build and installed and build time tests are just installed.
-Enji
Quoted 30 lines · Zou Wei
?Enable open posix testsuite compilation by default
Signed-off-by Zou Wei <[email protected]>---
testcases/Makefile | 4 ----1 file changed, 4 deletions(-)testcases/Makefile +0
-0@@ -30,10 +30,6 @@ include $(top_srcdir)/include/mk/env_pre.mk # run).
FILTER_OUT_DIRS:= kdumptestcases/Makefile +0
-4-ifneq ($(WITH_OPEN_POSIX_TESTSUITE),yes) -FILTER_OUT_DIRS += open_posix_testsuite -endif -ifneq ($(WITH_REALTIME_TESTSUITE),yes)
FILTER_OUT_DIRS+= realtime
endif
--
2.6.2Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp