Skip to contentSkip to conversation

package/localedef: fix dependencies

PATCH Superseded Yann E. MORIN 3 participants 4 messages Mar 17, 2020 – Mar 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/localedef: fix dependencies

localedef needs bison to satisfy a .y.c rule to generate a parser for plural forms, to ultimately generate data for the target. So we do not want to depend on the host-provided bison; we want to build our own (for reproducibility).

localedef is a host-only package, and dependencies are not inherited from the target variant, so we need to make them explicit host dependencies.

And move the assignment after all the download-related variables.

---
Changes v1 -> v2:
- do not depend on the host provided bison

---
 package/localedef/localedef.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/localedef/localedef.mk +4 -1
index 10a1929044..3e22f68039 100644
@@ -10,9 +10,12 @@
 LOCALEDEF_VERSION = 2.30-20-g50f20fe506abb8853641006a7b90a81af21d7b91
 LOCALEDEF_SOURCE = glibc-$(LOCALEDEF_VERSION).tar.gz
 LOCALEDEF_SITE = $(call github,bminor,glibc,$(LOCALEDEF_VERSION))
-LOCALEDEF_DEPENDENCIES = $(BR2_MAKE_HOST_DEPENDENCY)
 HOST_LOCALEDEF_DL_SUBDIR = glibc
 
+HOST_LOCALEDEF_DEPENDENCIES = \
+	$(BR2_MAKE_HOST_DEPENDENCY) \
+	host-bison
+
 HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
 
 # Even though we use the autotools-package infrastructure, we have to override
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 package/localedef: fix dependencies

Hi Yann,

Le 17/03/2020 ? 22:11, Yann E. MORIN a ?crit?:

Quoted 26 lines

localedef needs bison to satisfy a .y.c rule to generate a parser for plural forms, to ultimately generate data for the target. So we do not want to depend on the host-provided bison; we want to build our own (for reproducibility).

localedef is a host-only package, and dependencies are not inherited from the target variant, so we need to make them explicit host dependencies.

And move the assignment after all the download-related variables.

---
Changes v1 -> v2:
- do not depend on the host provided bison

---
 package/localedef/localedef.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/localedef/localedef.mk +0 -0
index 10a1929044..3e22f68039 100644

package/localedef/localedef.mk line 13

Quoted 4 lines
package/localedef/localedef.mk +0 -1
@@ -10,9 +10,12 @@
 LOCALEDEF_VERSION = 2.30-20-g50f20fe506abb8853641006a7b90a81af21d7b91
 LOCALEDEF_SOURCE = glibc-$(LOCALEDEF_VERSION).tar.gz
 LOCALEDEF_SITE = $(call github,bminor,glibc,$(LOCALEDEF_VERSION))
-LOCALEDEF_DEPENDENCIES = $(BR2_MAKE_HOST_DEPENDENCY)

I believe this line come from the glibc package [1] that requires GNU Make >= 4.0 since version 2.28. Indeed glibc is a target package not a host package.

[1] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38

Best regards,
Romain

Quoted 10 lines
package/localedef/localedef.mk +4 -0
 HOST_LOCALEDEF_DL_SUBDIR = glibc
 
+HOST_LOCALEDEF_DEPENDENCIES = \
+	$(BR2_MAKE_HOST_DEPENDENCY) \
+	host-bison
+
 HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
 
 # Even though we use the autotools-package infrastructure, we have to override
author Applied
#2 lore raw

PATCH v2 1/1 package/localedef: fix dependencies

Romain., all,

On 2020-03-17 22:31 +0100, Romain Naour spake thusly:

Quoted 35 lines

Le 17/03/2020 ? 22:11, Yann E. MORIN a ?crit?:

Quoted 26 lines

localedef needs bison to satisfy a .y.c rule to generate a parser for plural forms, to ultimately generate data for the target. So we do not want to depend on the host-provided bison; we want to build our own (for reproducibility).

localedef is a host-only package, and dependencies are not inherited from the target variant, so we need to make them explicit host dependencies.

And move the assignment after all the download-related variables.

---
Changes v1 -> v2:
- do not depend on the host provided bison

---
 package/localedef/localedef.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/localedef/localedef.mk +0 -0
index 10a1929044..3e22f68039 100644

package/localedef/localedef.mk line 13

Quoted 4 lines
package/localedef/localedef.mk +0 -1
@@ -10,9 +10,12 @@
 LOCALEDEF_VERSION = 2.30-20-g50f20fe506abb8853641006a7b90a81af21d7b91
 LOCALEDEF_SOURCE = glibc-$(LOCALEDEF_VERSION).tar.gz
 LOCALEDEF_SITE = $(call github,bminor,glibc,$(LOCALEDEF_VERSION))
-LOCALEDEF_DEPENDENCIES = $(BR2_MAKE_HOST_DEPENDENCY)

I believe this line come from the glibc package [1] that requires GNU Make >= 4.0 since version 2.28. Indeed glibc is a target package not a host package.

Quoted 3 lines

[1] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38

Applied to master with your review tag, thanks! :-)

Regards,
Yann E. MORIN.

Quoted 15 lines

Best regards,
Romain

Quoted 10 lines
package/localedef/localedef.mk +4 -0
 HOST_LOCALEDEF_DL_SUBDIR = glibc
 
+HOST_LOCALEDEF_DEPENDENCIES = \
+	$(BR2_MAKE_HOST_DEPENDENCY) \
+	host-bison
+
 HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
 
 # Even though we use the autotools-package infrastructure, we have to override
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH v2 1/1 package/localedef: fix dependencies

In reply to Yann E. MORIN
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

localedef needs bison to satisfy a .y.c rule to generate a parser for plural forms, to ultimately generate data for the target. So we do not want to depend on the host-provided bison; we want to build our own (for reproducibility).

localedef is a host-only package, and dependencies are not inherited from the target variant, so we need to make them explicit host dependencies.

Quoted 8 lines

And move the assignment after all the download-related variables.

---
Changes v1 -> v2:
- do not depend on the host provided bison

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard