Skip to contentSkip to conversation

netfilter: nf_tables: fix double-free on set expression from the error path

PATCH New Pablo Neira Ayuso 1 participant 1 message Mar 18, 2020

Subsystems (2)
lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 netfilter: nf_tables: fix double-free on set expression from the error path

After copying the expression to the set element extension, release the expression and reset the pointer to avoid a double-free from the error path.

Fixes 409444522976 ("netfilter: nf_tables: add elements with stateful expressions")
---
 net/netfilter/nf_tables_api.c | 1 +
 1 file changed, 1 insertion(+)
net/netfilter/nf_tables_api.c +1 -0
index f92fb6003745..042ffc612cc1 100644
@@ -5079,6 +5079,7 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,
 	if (expr) {
 		memcpy(nft_set_ext_expr(ext), expr, expr->ops->size);
 		kfree(expr);
+		expr = NULL;
 	}
 
 	trans = nft_trans_elem_alloc(ctx, NFT_MSG_NEWSETELEM, set);
Signature · 1 line
2.11.0