Skip to contentSkip to conversation

rtw88: 8822c: config RF table path B before path A

PATCH In review [email protected] 2 participants 2 messages Mar 18, 2020 – Mar 23, 2020 Realtek wireless driver (rtw88)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtw88: 8822c: config RF table path B before path A

From: Yan-Hsuan Chuang <[email protected]>

After MAC switched power, the hardware's RF registers will have its default value, but the default value for path B is incorrect. So, load RF path B first, to decrease the period between MAC on and RF path B config.

By test, if we load path A first, then there's ~300ms that the path B is incorrect, it could lead to BT coex's A2DP glitch. But if we configure path B first, there will only have ~3ms, significantly lower possibility to have A2DP sound glitch.

---
 drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw88/rtw8822c.c +1 -1
index 146f693c7592..d2469f91976b 100644
@@ -4128,7 +4128,7 @@ struct rtw_chip_info rtw8822c_hw_spec = {
 	.agc_tbl = &rtw8822c_agc_tbl,
 	.bb_tbl = &rtw8822c_bb_tbl,
 	.rfk_init_tbl = &rtw8822c_array_mp_cal_init_tbl,
-	.rf_tbl = {&rtw8822c_rf_a_tbl, &rtw8822c_rf_b_tbl},
+	.rf_tbl = {&rtw8822c_rf_b_tbl, &rtw8822c_rf_a_tbl},
 	.rfe_defs = rtw8822c_rfe_defs,
 	.rfe_defs_size = ARRAY_SIZE(rtw8822c_rfe_defs),
 	.en_dis_dpd = true,
Signature · 1 line
2.17.1
#1 lore raw
Quoted 7 lines · <[email protected]> wrote:

From: Yan-Hsuan Chuang <[email protected]>

After MAC switched power, the hardware's RF registers will have its default value, but the default value for path B is incorrect. So, load RF path B first, to decrease the period between MAC on and RF path B config.

Quoted 6 lines

By test, if we load path A first, then there's ~300ms that the path B is incorrect, it could lead to BT coex's A2DP glitch. But if we configure path B first, there will only have ~3ms, significantly lower possibility to have A2DP sound glitch.

Patch applied to wireless-drivers-next.git, thanks.

11a64888c79b rtw88: 8822c: config RF table path B before path A

Signature · 3 lines
https://patchwork.kernel.org/patch/11444805/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches