Skip to contentSkip to conversation

RDMA/mlx5: Block delay drop to unprivileged users

PATCH In review Leon Romanovsky 1 participant 2 messages Mar 18, 2020 – Mar 19, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/mlx5: Block delay drop to unprivileged users

From: Maor Gottlieb <[email protected]>

Since this feature can globally block the RX port, it should be allowed to privileged users only.

Fixes 03404e8ae652("IB/mlx5: Add support to dropless RQ")

---
We didn't put this check in IB/core because it is unclear if it can be applicable to all vendors, but for the mlx5 it is clear, due to how wq is created.

---
 drivers/infiniband/hw/mlx5/qp.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/infiniband/hw/mlx5/qp.c +4 -0
index d3055f3eb0b6..88db580f7272 100644
@@ -6247,6 +6247,10 @@ struct ib_wq *mlx5_ib_create_wq(struct ib_pd *pd,
 	if (udata->outlen && udata->outlen < min_resp_len)
 		return ERR_PTR(-EINVAL);
 
+	if (!capable(CAP_NET_RAW) &&
+	    init_attr->create_flags & IB_WQ_FLAGS_DELAY_DROP)
+		return ERR_PTR(-EPERM);
+
 	dev = to_mdev(pd->device);
 	switch (init_attr->wq_type) {
 	case IB_WQT_RQ:

--
2.24.1

#1 lore raw
Quoted 8 lines · Leon Romanovsky

From: Maor Gottlieb <[email protected]>

Since this feature can globally block the RX port, it should be allowed to privileged users only.

Fixes 03404e8ae652("IB/mlx5: Add support to dropless RQ")
Quoted 8 lines

---
We didn't put this check in IB/core because it is unclear if it can be applicable to all vendors, but for the mlx5 it is clear, due to how wq is created.

---
 drivers/infiniband/hw/mlx5/qp.c | 4 ++++
 1 file changed, 4 insertions(+)

Please drop this patch, it needs to be resent.

Thanks