vxlan: check return value of gro_cells_init()
Subsystems (2)
PATCH 1/1 vxlan: check return value of gro_cells_init()
gro_cells_init() returns error if memory allocation is failed. But the vxlan module doesn't check the return value of gro_cells_init().
Fixes 58ce31cca1ff ("vxlan: GRO support at tunnel layer")`
Signed-off-by Taehee Yoo <[email protected]>
--- drivers/net/vxlan.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/net/vxlan.c +9 -2
@@ -2779,10 +2779,19 @@ static void vxlan_vs_add_dev(struct vxlan_sock *vs, struct vxlan_dev *vxlan,/* Setup stats when device is created */ static int vxlan_init (struct net_device *dev) { +struct vxlan_dev *vxlan =netdev_priv (dev); +int err; + dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);if (!dev->tstats)return -ENOMEM ; + err =gro_cells_init (&vxlan->gro_cells, dev); +if (err) { +free_percpu (dev->tstats); +return err; + } +return 0 ; }
@@ -3043,8 +3052,6 @@ static void vxlan_setup(struct net_device *dev) vxlan->dev = dev; -gro_cells_init (&vxlan->gro_cells, dev); -for (h =0 ; h <FDB_HASH_SIZE ; ++h) {spin_lock_init (&vxlan->hash_lock[h]);INIT_HLIST_HEAD (&vxlan->fdb_head[h]);
Signature · 1 line
2.17.1
David Miller
maintainerFrom: Taehee Yoo <[email protected]>
Date: Wed, 18 Mar 2020 13:28:09 +0000
Quoted 5 lines
gro_cells_init()returns error if memory allocation is failed. But the vxlan module doesn't check the return value ofgro_cells_init().Fixes 58ce31cca1ff ("vxlan: GRO support at tunnel layer")`Signed-off-by Taehee Yoo <[email protected]>
Applied and queued up for -stable, thank you.