Skip to contentSkip to conversation

FAILED: patch "[PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug" failed to apply to 5.5-stable tree

PATCH [email protected] 2 participants 2 messages Mar 16, 2020 – Mar 18, 2020

Subsystems (5)
Stable branch Arm Qualcomm mailing list Pin control Pin controller - Qualcomm +1 more subsystems
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.5-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From f98371476f36359da2285d1807b43e5b17fd18de Mon Sep 17 00:00:00 2001
From: Linus Walleij <[email protected]>
Date: Fri, 6 Mar 2020 15:34:15 +0100
Subject: [PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug

We are parsing SSBI gpios as fourcell fwspecs but they are twocell. Probably a simple copy-and-paste bug.

Tested on the APQ8060 DragonBoard and after this ethernet and MMC card detection works again.

Cc Bjorn Andersson <[email protected]>
Cc [email protected]
Reviewed-by Brian Masney <[email protected]>
Fixes ae436fe81053 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Linus Walleij <[email protected]>
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +1 -1
index fba1d41d20ec..338a15d08629 100644
@@ -794,7 +794,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev)
 	girq->fwnode = of_node_to_fwnode(pctrl->dev->of_node);
 	girq->parent_domain = parent_domain;
 	girq->child_to_parent_hwirq = pm8xxx_child_to_parent_hwirq;
-	girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;
+	girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_twocell;
 	girq->child_offset_to_irq = pm8xxx_child_offset_to_irq;
 	girq->child_irq_domain_ops.translate = pm8xxx_domain_translate;
maintainer
#1 lore raw
Quoted 23 lines · On Mon, Mar 16, 2020 at 12:34:23PM +0100, [email protected] wrote:

The patch below does not apply to the 5.5-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From f98371476f36359da2285d1807b43e5b17fd18de Mon Sep 17 00:00:00 2001
From: Linus Walleij <[email protected]>
Date: Fri, 6 Mar 2020 15:34:15 +0100
Subject: [PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug

We are parsing SSBI gpios as fourcell fwspecs but they are twocell. Probably a simple copy-and-paste bug.

Tested on the APQ8060 DragonBoard and after this ethernet and MMC card detection works again.

Quoted 6 lines
Cc Bjorn Andersson <[email protected]>
Cc [email protected]
Reviewed-by Brian Masney <[email protected]>
Fixes ae436fe81053 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Linus Walleij <[email protected]>

I've also grabbed 242587616710 ("gpiolib: Add support for the irqdomain which doesn't use irq_fwspec as arg") and queued both for 5.5.

Signature · 2 lines
Thanks,
Sasha