Skip to contentSkip to conversation

libxl: Fix xl shutdown for HVM without PV drivers

PATCH In review Olaf Hering 2 participants 2 messages Mar 18, 2020 – Mar 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxl: Fix xl shutdown for HVM without PV drivers

A return value of zero means no PV drivers. Restore a hunk which was removed.

Fixes commit b183e180bce93037d3ef385a8c2338bbfb7f23d9

---
 tools/libxl/libxl_domain.c | 3 +++
 1 file changed, 3 insertions(+)
tools/libxl/libxl_domain.c +3 -0
index 41d08394f3..fef2cd4e13 100644
@@ -774,6 +774,9 @@ int libxl__domain_pvcontrol(libxl__egc *egc, libxl__xswait_state *pvcontrol,
     if (rc < 0)
         return rc;
 
+    if (!rc)
+        return ERROR_NOPARAVIRT;
+
     shutdown_path = libxl__domain_pvcontrol_xspath(gc, domid);
     if (!shutdown_path)
         return ERROR_FAIL;

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Olaf Hering

A return value of zero means no PV drivers. Restore a hunk which was removed.

Fixes commit b183e180bce93037d3ef385a8c2338bbfb7f23d9

And applied.

Quoted 9 lines
---
 tools/libxl/libxl_domain.c | 3 +++
 1 file changed, 3 insertions(+)
tools/libxl/libxl_domain.c +0 -0
index 41d08394f3..fef2cd4e13 100644

tools/libxl/libxl_domain.c int libxl__domain_pvcontrol(libxl__egc *egc, libxl__xswait_state *pvcontrol, · line 782

Quoted 9 lines
tools/libxl/libxl_domain.c +3 -0
@@ -774,6 +774,9 @@ int libxl__domain_pvcontrol(libxl__egc *egc, libxl__xswait_state *pvcontrol,
     if (rc < 0)
         return rc;
 
+    if (!rc)
+        return ERROR_NOPARAVIRT;
+
     shutdown_path = libxl__domain_pvcontrol_xspath(gc, domid);
     if (!shutdown_path)
         return ERROR_FAIL;

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel