Skip to contentSkip to conversation

spec: RPM spec file changes for liburing-0.5

PATCH Applied Stefan Hajnoczi 2 participants 4 messages Mar 19, 2020 Block layer

lore
Share & tools
lore
#0 lore raw

cover spec: RPM spec file changes for liburing-0.5

These patches fix issues with the liburing-0.5 RPM spec file. I encountered them when packaging it for Fedora.

Stefan Hajnoczi (2):
spec: use "or" instead of "/" in License line
spec: add ./configure --libdevdir= for development package files

 liburing.spec | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/2 spec: use "or" instead of "/" in License line

rpmlint on Fedora 31 complains about "LGPLv2+ / MIT" because "/" is not allowed. Use "or" instead.

Fixes 783831a0548d3c702bd18746b5f425106f10e090

("Include MIT notice in rpm spec and debian package file")

---
 liburing.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
liburing.spec +1 -1
index b09c6e1..987946d 100644
@@ -2,7 +2,7 @@ Name: liburing
 Version: 0.6
 Release: 1%{?dist}
 Summary: Linux-native io_uring I/O access library
-License: LGPLv2+ / MIT
+License: LGPLv2+ or MIT
 Source0: https://brick.kernel.dk/snaps/%{name}-%{version}.tar.gz
 Source1: https://brick.kernel.dk/snaps/%{name}-%{version}.tar.gz.asc
 URL: https://git.kernel.dk/cgit/liburing/
Signature · 1 line
2.24.1
#2 lore raw

PATCH 2/2 spec: add ./configure --libdevdir= for development package files

In reply to Stefan Hajnoczi

The development package files (--libdevdir=) have been separated from the library runtime package files (--libdir=). Make sure to set --libdevdir= so x86_64 Fedora RPMs are built for /usr/lib64 instead of /usr/lib.

Cc Stefan Metzmacher <[email protected]>
Fixes 3e63af4f252e1dfc2cb736863d8db4a3821f48e4
       ("Fix liburing.so symlink source if libdir != libdevdir")
---
 liburing.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
liburing.spec +1 -1
index 987946d..1665c7c 100644
@@ -26,7 +26,7 @@ for the Linux-native io_uring.
 
 %build
 %set_build_flags
-./configure --prefix=%{_prefix} --libdir=/%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir}
+./configure --prefix=%{_prefix} --libdir=/%{_libdir} --libdevdir=/%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir}
 
 %make_build
 
Signature · 1 line
2.24.1
maintainer Applied
#3 lore raw
In reply to Stefan Hajnoczi
Quoted 9 lines · Stefan Hajnoczi

These patches fix issues with the liburing-0.5 RPM spec file. I encountered them when packaging it for Fedora.

Stefan Hajnoczi (2):
spec: use "or" instead of "/" in License line
spec: add ./configure --libdevdir= for development package files

 liburing.spec | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

BTW, we have [email protected], that's probably a better list to use going forward.

Signature · 1 line
Jens Axboe