dt-bindings: sram: convert rockchip-pmu-sram bindings to yaml
Subsystems (2)
RFC PATCH v2 1/2 dt-bindings: sram: convert rockchip-pmu-sram bindings to yaml
Current dts files with 'rockchip-pmu-sram' compatible nodes are now verified with sram.yaml, although the original text document still exists. Merge rockchip-pmu-sram.txt with sram.yaml by adding it as description with an example.
---
Not tested with hardware.
Changed v2:
Merge with sram.yaml
--- .../devicetree/bindings/sram/rockchip-pmu-sram.txt | 16 ---------------- Documentation/devicetree/bindings/sram/sram.yaml | 13 +++++++++++++ 2 files changed, 13 insertions(+), 16 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sram/rockchip-pmu-sram.txt
Documentation/devicetree/bindings/sram/rockchip-pmu-sram.txt deleted +0 -16
@@ -1,16 +0,0 @@ -Rockchip SRAM for pmu: ------------------------------- - -The sram of pmu is used to store the function of resume from maskrom(the 1st -level loader). This is a common use of the "pmu-sram" because it keeps power -even in low power states in the system. - -Required node properties: -- compatible : should be "rockchip,rk3288-pmu-sram" -- reg : physical base address and the size of the registers window - -Example: - sram@ff720000 { - compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; - reg = <0xff720000 0x1000>; - };
Documentation/devicetree/bindings/sram/sram.yaml +13 -0
@@ -224,6 +224,19 @@ examples: }; - | + // Rockchip's rk3288 SoC uses the sram of pmu to store the function of + // resume from maskrom(the 1st level loader). This is a common use of + // the "pmu-sram" because it keeps power even in low power states + // in the system. + sram@ff720000 { + compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; + reg = <0xff720000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0xff720000 0x1000>; + }; + + - | // Allwinner's A80 SoC uses part of the secure sram for hotplugging of the // primary core (cpu0). Once the core gets powered up it checks if a magic // value is set at a specific location. If it is then the BROM will jump
Signature · 1 line
2.11.0
RFC PATCH v2 2/2 ARM: dts: rockchip: fix yaml warnings for rk3288-pmu-sram compatible nodes
A test with the command below gives for example these warnings:
arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000:
'#address-cells' is a required property arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000:
'#size-cells' is a required property arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000:
'ranges' is a required property
Fix this error by adding '#address-cells', '#size-cells' and 'ranges' to the 'rockchip,rk3288-pmu-sram' compatible node in rk3288.dtsi.
make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sram/sram.yaml
---
Not tested with hardware.
Changed v2:
Fix dtsi.
--- arch/arm/boot/dts/rk3288.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm/boot/dts/rk3288.dtsi +3 -0
@@ -731,6 +731,9 @@ pmu_sram: sram@ff720000 { compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; reg = <0x0 0xff720000 0x0 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x0 0xff720000 0x1000>; }; pmu: power-management@ff730000 {
Signature · 1 line
2.11.0
Rob Herring
maintainerQuoted 44 lines · Johan Jonker
Current dts files with 'rockchip-pmu-sram' compatible nodes are now verified with
sram.yaml, although the original text document still exists. Merge rockchip-pmu-sram.txt withsram.yamlby adding it as description with an example.Signed-off-by Johan Jonker <[email protected]>---
Not tested with hardware.Changed v2:
Merge withsram.yaml--- .../devicetree/bindings/sram/rockchip-pmu-sram.txt | 16 ---------------- Documentation/devicetree/bindings/sram/sram.yaml | 13 +++++++++++++ 2 files changed, 13 insertions(+), 16 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sram/rockchip-pmu-sram.txtDocumentation/devicetree/bindings/sram/rockchip-pmu-sram.txt deleted +0
-16@@ -1,16 +0,0 @@ -Rockchip SRAM for pmu: ------------------------------- - -The sram of pmu is used to store the function of resume from maskrom(the 1st -level loader). This is a common use of the "pmu-sram" because it keeps power -even in low power states in the system. - -Required node properties: -- compatible : should be "rockchip,rk3288-pmu-sram" -- reg : physical base address and the size of the registers window - -Example: - sram@ff720000 { - compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; - reg = <0xff720000 0x1000>; - };Documentation/devicetree/bindings/sram/sram.yaml +0
-0
Documentation/devicetree/bindings/sram/sram.yaml examples: · line 232
Quoted 9 lines
Documentation/devicetree/bindings/sram/sram.yaml +6
-0@@ -224,6 +224,19 @@ examples: }; - | + // Rockchip's rk3288 SoC uses the sram of pmu to store the function of + // resume from maskrom(the 1st level loader). This is a common use of + // the "pmu-sram" because it keeps power even in low power states + // in the system. + sram@ff720000 { + compatible = "rockchip,rk3288-pmu-sram", "mmio-sram";
You need to document the compatible.
Quoted 13 lines
Documentation/devicetree/bindings/sram/sram.yaml +7
-0+ reg = <0xff720000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0xff720000 0x1000>; + }; + + - | // Allwinner's A80 SoC uses part of the secure sram for hotplugging of the // primary core (cpu0). Once the core gets powered up it checks if a magic // value is set at a specific location. If it is then the BROM will jumpSignature · 1 line
2.11.0