Skip to contentSkip to conversation

ASoC: Intel: broadwell: Revert SSP0 link to use dummy components

PATCH In review Cezary Rojewski 3 participants 5 messages Mar 19, 2020 – Mar 25, 2020

Subsystems (3)
lore
Share & tools
lore

Cezary Rojewski

author maintainer
#0 lore raw

PATCH 1/1 ASoC: Intel: broadwell: Revert SSP0 link to use dummy components

Commit:
"ASoC: Intel: broadwell: change cpu_dai and platform components for SOF

while enabling bdw on SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.

While harmless so far, this flow ain't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.

Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54

Fixes 64df6afa0dab ("ASoC: Intel: broadwell: change cpu_dai and platform components for SOF")
---
 sound/soc/intel/boards/broadwell.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/broadwell.c +4 -3
index 0776ea2d4f36..9b639475e99f 100644
@@ -167,9 +167,6 @@ SND_SOC_DAILINK_DEF(codec,
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
 SND_SOC_DAILINK_DEF(ssp0_port,
 	    DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));
-#else
-SND_SOC_DAILINK_DEF(ssp0_port,
-	    DAILINK_COMP_ARRAY(COMP_DUMMY()));
 #endif
 
 /* broadwell digital audio interface glue - connects codec <--> CPU */
@@ -225,7 +222,11 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
 		.ops = &broadwell_rt286_ops,
 		.dpcm_playback = 1,
 		.dpcm_capture = 1,
+#if !IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
+		SND_SOC_DAILINK_REG(dummy, codec, dummy),
+#else
 		SND_SOC_DAILINK_REG(ssp0_port, codec, platform),
+#endif
 	},
 };
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Cezary Rojewski

Commit:
"ASoC: Intel: broadwell: change cpu_dai and platform components for SOF

checkpatch.pl probably reports the format doesn't follow conventions?

Quoted 8 lines

while enabling bdw on SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.

While harmless so far, this flow ain't right and should be corrected.

isn't

Quoted 2 lines

The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.

If we want to be consistent, the same use of a dummy platform component needs to be applied to bdw-rt5677.c and bdw-rt5650.c

Quoted 38 lines

Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54

Fixes 64df6afa0dab ("ASoC: Intel: broadwell: change cpu_dai and platform components for SOF")
---
  sound/soc/intel/boards/broadwell.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/broadwell.c +4 -3
index 0776ea2d4f36..9b639475e99f 100644
@@ -167,9 +167,6 @@ SND_SOC_DAILINK_DEF(codec,
  #if IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
  SND_SOC_DAILINK_DEF(ssp0_port,
  	    DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));
-#else
-SND_SOC_DAILINK_DEF(ssp0_port,
-	    DAILINK_COMP_ARRAY(COMP_DUMMY()));
  #endif
 
  /* broadwell digital audio interface glue - connects codec <--> CPU */
@@ -225,7 +222,11 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
  		.ops = &broadwell_rt286_ops,
  		.dpcm_playback = 1,
  		.dpcm_capture = 1,
+#if !IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
+		SND_SOC_DAILINK_REG(dummy, codec, dummy),
+#else
  		SND_SOC_DAILINK_REG(ssp0_port, codec, platform),
+#endif
  	},
  };
 
author maintainer
#2 lore raw
Quoted 8 lines · Pierre-Louis Bossart
Quoted 2 lines · Cezary Rojewski

Commit:
"ASoC: Intel: broadwell: change cpu_dai and platform components for SOF

checkpatch.pl probably reports the format doesn't follow conventions?

It does not. Reworded anyway so it's not bothering anyone.

Quoted 11 lines
Quoted 8 lines

while enabling bdw on SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.

While harmless so far, this flow ain't right and should be corrected.

isn't

Reworded.

Quoted 5 lines
Quoted 2 lines

The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.

If we want to be consistent, the same use of a dummy platform component needs to be applied to bdw-rt5677.c and bdw-rt5650.c

Agreed. Combined all three into one series.

Czarek

#3 lore raw
In reply to Cezary Rojewski
Quoted 3 lines · Cezary Rojewski

Commit:
"ASoC: Intel: broadwell: change cpu_dai and platform components for SOF

Where does this quote end?

Quoted 3 lines

while enabling bdw on SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes

author maintainer
#4 lore raw
Quoted 6 lines · Curtis Malainey
Quoted 3 lines · Cezary Rojewski

Commit:
"ASoC: Intel: broadwell: change cpu_dai and platform components for SOF

Where does this quote end?

I'm afraid, it doesn't. Does it matter, though? You're not looking at the newest version - one that is part of: "[PATCH 0/3] ASoC: Intel: boards: Revert SSP0 links to use dummy" series.

Regards,
Czarek