interconnect: qcom: Fix uninitialized tcs_cmd::wait
Subsystems (2)
PATCH 1/1 interconnect: qcom: Fix uninitialized tcs_cmd::wait
Currently, if tcs_cmd_gen is called with commit=false, then tcs_cmd::wait is left uninitialized. Since the tcs_cmd structures passed to this function aren't zero-initialized, then we're left with random wait values. This results in waiting for completion for more commands than is necessary, depending on what's on the stack at the time.
Removing the unnecessary if-condition fixes this, but add an explicit memset of the tcs_cmd structure as well to ensure predictable behavior if more tcs_cmd members are added in the future.
--- drivers/interconnect/qcom/bcm-voter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/interconnect/qcom/bcm-voter.c +3 -2
@@ -96,6 +96,8 @@ static inline void tcs_cmd_gen(struct tcs_cmd *cmd, u64 vote_x, u64 vote_y,if (!cmd)return ; +memset (cmd,0 ,sizeof (*cmd)); +if (vote_x ==0 && vote_y ==0 ) valid = false;
@@ -112,8 +114,7 @@ static inline void tcs_cmd_gen(struct tcs_cmd *cmd, u64 vote_x, u64 vote_y,* Set the wait for completion flag on command that need to be completed * before the next command. */ -if (commit) - cmd->wait = true; + cmd->wait = commit; } static void tcs_list_gen(struct list_head *bcm_list, int bucket,
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 6 lines · Mike Tipton
Currently, if
tcs_cmd_genis called with commit=false, thentcs_cmd::waitis left uninitialized. Since thetcs_cmdstructures passed to this function aren't zero-initialized, then we're left with random wait values. This results in waiting for completion for more commands than is necessary, depending on what's on the stack at the time.
Quoted 6 lines
Removing the unnecessary if-condition fixes this, but add an explicit memset of the
tcs_cmdstructure as well to ensure predictable behavior if moretcs_cmdmembers are added in the future.Fixes 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support")Signed-off-by Mike Tipton <[email protected]>
Regards,
Bjorn
Quoted 30 lines
--- drivers/interconnect/qcom/bcm-voter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/interconnect/qcom/bcm-voter.c +3
-2@@ -96,6 +96,8 @@ static inline void tcs_cmd_gen(struct tcs_cmd *cmd, u64 vote_x, u64 vote_y,if (!cmd)return ; +memset (cmd,0 ,sizeof (*cmd)); +if (vote_x ==0 && vote_y ==0 ) valid = false;@@ -112,8 +114,7 @@ static inline void tcs_cmd_gen(struct tcs_cmd *cmd, u64 vote_x, u64 vote_y,* Set the wait for completion flag on command that need to be completed * before the next command. */ -if (commit) - cmd->wait = true; + cmd->wait = commit; } static void tcs_list_gen(struct list_head *bcm_list, int bucket,Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project