Skip to contentSkip to conversation

Add Support for Marvell OcteonTX Cryptographic

PATCH In review Srujana Challa 5 participants 12 messages Mar 13, 2020 – Apr 13, 2020

Subsystems (2)
lore
Share & tools
lore

Srujana Challa

author maintainer
#0 lore raw

v2 cover Add Support for Marvell OcteonTX Cryptographic

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

 MAINTAINERS                                        |    1 +
 drivers/crypto/Kconfig                             |   15 +-
 drivers/crypto/Makefile                            |    2 +-
 drivers/crypto/marvell/Kconfig                     |   37 +
 drivers/crypto/marvell/Makefile                    |    7 +-
 drivers/crypto/marvell/cesa.c                      |  615 -------
 drivers/crypto/marvell/cesa.h                      |  880 ----------
 drivers/crypto/marvell/cesa/Makefile               |    3 +
 drivers/crypto/marvell/cesa/cesa.c                 |  615 +++++++
 drivers/crypto/marvell/cesa/cesa.h                 |  881 ++++++++++
 drivers/crypto/marvell/cesa/cipher.c               |  801 +++++++++
 drivers/crypto/marvell/cesa/hash.c                 | 1448 ++++++++++++++++
 drivers/crypto/marvell/cesa/tdma.c                 |  352 ++++
 drivers/crypto/marvell/cipher.c                    |  798 ---------
 drivers/crypto/marvell/hash.c                      | 1442 ----------------
 drivers/crypto/marvell/octeontx/Makefile           |    6 +
 drivers/crypto/marvell/octeontx/otx_cpt_common.h   |   51 +
 drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h |  824 +++++++++
 drivers/crypto/marvell/octeontx/otx_cptpf.h        |   34 +
 drivers/crypto/marvell/octeontx/otx_cptpf_main.c   |  307 ++++
 drivers/crypto/marvell/octeontx/otx_cptpf_mbox.c   |  253 +++
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c  | 1686 +++++++++++++++++++
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h  |  180 ++
 drivers/crypto/marvell/octeontx/otx_cptvf.h        |  104 ++
 drivers/crypto/marvell/octeontx/otx_cptvf_algs.c   | 1744 ++++++++++++++++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_algs.h   |  188 +++
 drivers/crypto/marvell/octeontx/otx_cptvf_main.c   |  985 +++++++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_mbox.c   |  247 +++
 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c |  612 +++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.h |  227 +++
 drivers/crypto/marvell/tdma.c                      |  350 ----
 31 files changed, 11592 insertions(+), 4103 deletions(-)
 create mode 100644 drivers/crypto/marvell/Kconfig
 delete mode 100644 drivers/crypto/marvell/cesa.c
 delete mode 100644 drivers/crypto/marvell/cesa.h
 create mode 100644 drivers/crypto/marvell/cesa/Makefile
 create mode 100644 drivers/crypto/marvell/cesa/cesa.c
 create mode 100644 drivers/crypto/marvell/cesa/cesa.h
 create mode 100644 drivers/crypto/marvell/cesa/cipher.c
 create mode 100644 drivers/crypto/marvell/cesa/hash.c
 create mode 100644 drivers/crypto/marvell/cesa/tdma.c
 delete mode 100644 drivers/crypto/marvell/cipher.c
 delete mode 100644 drivers/crypto/marvell/hash.c
 create mode 100644 drivers/crypto/marvell/octeontx/Makefile
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cpt_common.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_main.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_mbox.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_algs.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_algs.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_main.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_mbox.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.h
 delete mode 100644 drivers/crypto/marvell/tdma.c
Signature · 1 line
1.9.1
author maintainer
#1 lore raw

PATCH v2 1/4 drivers: crypto: create common Kconfig and Makefile for Marvell

From: SrujanaChalla <[email protected]>

Creats common Kconfig and Makefile for Marvell crypto drivers.

---
 drivers/crypto/Kconfig               |   15 +-
 drivers/crypto/Makefile              |    2 +-
 drivers/crypto/marvell/Kconfig       |   21 +
 drivers/crypto/marvell/Makefile      |    6 +-
 drivers/crypto/marvell/cesa.c        |  615 ---------------
 drivers/crypto/marvell/cesa.h        |  880 ---------------------
 drivers/crypto/marvell/cesa/Makefile |    3 +
 drivers/crypto/marvell/cesa/cesa.c   |  615 +++++++++++++++
 drivers/crypto/marvell/cesa/cesa.h   |  881 +++++++++++++++++++++
 drivers/crypto/marvell/cesa/cipher.c |  801 +++++++++++++++++++
 drivers/crypto/marvell/cesa/hash.c   | 1448 ++++++++++++++++++++++++++++++++++
 drivers/crypto/marvell/cesa/tdma.c   |  352 +++++++++
 drivers/crypto/marvell/cipher.c      |  798 -------------------
 drivers/crypto/marvell/hash.c        | 1442 ---------------------------------
 drivers/crypto/marvell/tdma.c        |  350 --------
 15 files changed, 4126 insertions(+), 4103 deletions(-)
 create mode 100644 drivers/crypto/marvell/Kconfig
 delete mode 100644 drivers/crypto/marvell/cesa.c
 delete mode 100644 drivers/crypto/marvell/cesa.h
 create mode 100644 drivers/crypto/marvell/cesa/Makefile
 create mode 100644 drivers/crypto/marvell/cesa/cesa.c
 create mode 100644 drivers/crypto/marvell/cesa/cesa.h
 create mode 100644 drivers/crypto/marvell/cesa/cipher.c
 create mode 100644 drivers/crypto/marvell/cesa/hash.c
 create mode 100644 drivers/crypto/marvell/cesa/tdma.c
 delete mode 100644 drivers/crypto/marvell/cipher.c
 delete mode 100644 drivers/crypto/marvell/hash.c
 delete mode 100644 drivers/crypto/marvell/tdma.c
drivers/crypto/Kconfig +1 -14
index c2767ed..a829f94 100644
@@ -233,20 +233,6 @@ config CRYPTO_CRC32_S390
 
 	  It is available with IBM z13 or later.
 
-config CRYPTO_DEV_MARVELL_CESA
-	tristate "Marvell's Cryptographic Engine driver"
-	depends on PLAT_ORION || ARCH_MVEBU
-	select CRYPTO_LIB_AES
-	select CRYPTO_LIB_DES
-	select CRYPTO_SKCIPHER
-	select CRYPTO_HASH
-	select SRAM
-	help
-	  This driver allows you to utilize the Cryptographic Engines and
-	  Security Accelerator (CESA) which can be found on MVEBU and ORION
-	  platforms.
-	  This driver supports CPU offload through DMA transfers.
-
 config CRYPTO_DEV_NIAGARA2
 	tristate "Niagara2 Stream Processing Unit driver"
 	select CRYPTO_LIB_DES
@@ -606,6 +592,7 @@ config CRYPTO_DEV_MXS_DCP
 source "drivers/crypto/qat/Kconfig"
 source "drivers/crypto/cavium/cpt/Kconfig"
 source "drivers/crypto/cavium/nitrox/Kconfig"
+source "drivers/crypto/marvell/Kconfig"
 
 config CRYPTO_DEV_CAVIUM_ZIP
 	tristate "Cavium ZIP driver"
drivers/crypto/Makefile +1 -1
index 40229d4..2306d41 100644
@@ -18,7 +18,7 @@ obj-$(CONFIG_CRYPTO_DEV_GEODE) += geode-aes.o
 obj-$(CONFIG_CRYPTO_DEV_HIFN_795X) += hifn_795x.o
 obj-$(CONFIG_CRYPTO_DEV_IMGTEC_HASH) += img-hash.o
 obj-$(CONFIG_CRYPTO_DEV_IXP4XX) += ixp4xx_crypto.o
-obj-$(CONFIG_CRYPTO_DEV_MARVELL_CESA) += marvell/
+obj-$(CONFIG_CRYPTO_DEV_MARVELL) += marvell/
 obj-$(CONFIG_CRYPTO_DEV_MEDIATEK) += mediatek/
 obj-$(CONFIG_CRYPTO_DEV_MXS_DCP) += mxs-dcp.o
 obj-$(CONFIG_CRYPTO_DEV_NIAGARA2) += n2_crypto.o
drivers/crypto/marvell/Kconfig new file +21 -0
new file mode 100644
index 0000000..8262b14
@@ -0,0 +1,21 @@
+#
+# Marvell crypto drivers configuration
+#
+
+config CRYPTO_DEV_MARVELL
+	tristate
+
+config CRYPTO_DEV_MARVELL_CESA
+	tristate "Marvell's Cryptographic Engine driver"
+	depends on PLAT_ORION || ARCH_MVEBU
+	select CRYPTO_LIB_AES
+	select CRYPTO_LIB_DES
+	select CRYPTO_SKCIPHER
+	select CRYPTO_HASH
+	select SRAM
+	select CRYPTO_DEV_MARVELL
+	help
+	  This driver allows you to utilize the Cryptographic Engines and
+	  Security Accelerator (CESA) which can be found on MVEBU and ORION
+	  platforms.
+	  This driver supports CPU offload through DMA transfers.
drivers/crypto/marvell/Makefile +3 -3
index b27cab6..2030b0b 100644
@@ -1,3 +1,3 @@
-# SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_CRYPTO_DEV_MARVELL_CESA) += marvell-cesa.o
-marvell-cesa-objs := cesa.o cipher.o hash.o tdma.o
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_CRYPTO_DEV_MARVELL_CESA) += cesa/
drivers/crypto/marvell/cesa.c deleted +0 -615

615 lines not on this page · raw message

drivers/crypto/marvell/cesa.h deleted +0 -880

880 lines not on this page · raw message

drivers/crypto/marvell/cesa/Makefile new file +3 -0
new file mode 100644
index 0000000..b27cab6
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_CRYPTO_DEV_MARVELL_CESA) += marvell-cesa.o
+marvell-cesa-objs := cesa.o cipher.o hash.o tdma.o
drivers/crypto/marvell/cesa/cesa.c new file +615 -0

615 lines not on this page · raw message

drivers/crypto/marvell/cesa/cesa.h new file +881 -0

825 lines not on this page · raw message

drivers/crypto/marvell/cesa/cipher.c new file +801 -0

801 lines not on this page · raw message

drivers/crypto/marvell/cesa/hash.c new file +1448 -0

1,448 lines not on this page · raw message

drivers/crypto/marvell/cesa/tdma.c new file +352 -0

352 lines not on this page · raw message

drivers/crypto/marvell/cipher.c deleted +0 -798

798 lines not on this page · raw message

drivers/crypto/marvell/hash.c deleted +0 -1442

1,442 lines not on this page · raw message

drivers/crypto/marvell/tdma.c deleted +0 -350

350 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.9.1

Part of the diff is not shown here. View the raw message.

author maintainer
#2 lore raw

PATCH v2 2/4 drivers: crypto: add support for OCTEON TX CPT engine

In reply to Srujana Challa

From: SrujanaChalla <[email protected]>

Add support for the cryptographic acceleration unit (CPT) on OcteonTX CN83XX SoC.

---
 MAINTAINERS                                        |    1 +
 drivers/crypto/marvell/octeontx/Makefile           |    4 +
 drivers/crypto/marvell/octeontx/otx_cpt_common.h   |   51 +
 drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h |  249 +++
 drivers/crypto/marvell/octeontx/otx_cptpf.h        |   34 +
 drivers/crypto/marvell/octeontx/otx_cptpf_main.c   |  307 ++++
 drivers/crypto/marvell/octeontx/otx_cptpf_mbox.c   |  253 +++
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c  | 1686 ++++++++++++++++++++
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h  |  180 +++
 9 files changed, 2765 insertions(+)
 create mode 100644 drivers/crypto/marvell/octeontx/Makefile
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cpt_common.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_main.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_mbox.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
MAINTAINERS +1 -0
index a0c1618..41b616e 100644
@@ -9906,6 +9906,7 @@ F:	Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt
 MARVELL CRYPTO DRIVER
 M:	Boris Brezillon <[email protected]>
 M:	Arnaud Ebalard <[email protected]>
+M:	Srujana Challa <[email protected]>
 F:	drivers/crypto/marvell/
 S:	Maintained
 L:	[email protected]
drivers/crypto/marvell/octeontx/Makefile new file +4 -0
new file mode 100644
index 0000000..627d00e
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_CRYPTO_DEV_OCTEONTX_CPT) += octeontx-cpt.o
+
+octeontx-cpt-objs := otx_cptpf_main.o otx_cptpf_mbox.o otx_cptpf_ucode.o
drivers/crypto/marvell/octeontx/otx_cpt_common.h new file +51 -0

51 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h new file +249 -0

249 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptpf.h new file +34 -0
new file mode 100644
index 0000000..73cd0a9
@@ -0,0 +1,34 @@
+/* SPDX-License-Identifier: GPL-2.0
+ * Marvell OcteonTX CPT driver
+ *
+ * Copyright (C) 2019 Marvell International Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __OTX_CPTPF_H
+#define __OTX_CPTPF_H
+
+#include <linux/types.h>
+#include <linux/device.h>
+#include "otx_cptpf_ucode.h"
+
+/*
+ * OcteonTX CPT device structure
+ */
+struct otx_cpt_device {
+	void __iomem *reg_base; /* Register start address */
+	struct pci_dev *pdev;	/* Pci device handle */
+	struct otx_cpt_eng_grps eng_grps;/* Engine groups information */
+	struct list_head list;
+	u8 pf_type;	/* PF type SE or AE */
+	u8 max_vfs;	/* Maximum number of VFs supported by the CPT */
+	u8 vfs_enabled;	/* Number of enabled VFs */
+};
+
+void otx_cpt_mbox_intr_handler(struct otx_cpt_device *cpt, int mbx);
+void otx_cpt_disable_all_cores(struct otx_cpt_device *cpt);
+
+#endif /* __OTX_CPTPF_H */
drivers/crypto/marvell/octeontx/otx_cptpf_main.c new file +307 -0

307 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptpf_mbox.c new file +253 -0

253 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c new file +1686 -0

1,686 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h new file +180 -0

180 lines not on this page · raw message

Signature · 1 line
1.9.1
author maintainer
#3 lore raw

PATCH v2 3/4 drivers: crypto: add the Virtual Function driver for CPT

In reply to Srujana Challa

From: SrujanaChalla <[email protected]>

Add support for the cryptographic accelerator unit virtual functions on OcteonTX 83XX SoC.

---
 drivers/crypto/marvell/octeontx/Makefile           |    4 +-
 drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h |  577 ++++++-
 drivers/crypto/marvell/octeontx/otx_cptvf.h        |  104 ++
 drivers/crypto/marvell/octeontx/otx_cptvf_algs.c   | 1744 ++++++++++++++++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_algs.h   |  188 +++
 drivers/crypto/marvell/octeontx/otx_cptvf_main.c   |  985 +++++++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_mbox.c   |  247 +++
 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c |  612 +++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.h |  227 +++
 9 files changed, 4686 insertions(+), 2 deletions(-)
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_algs.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_algs.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_main.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_mbox.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.h
drivers/crypto/marvell/octeontx/Makefile +3 -1
index 627d00e..5e956fe 100644
@@ -1,4 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_CRYPTO_DEV_OCTEONTX_CPT) += octeontx-cpt.o
+obj-$(CONFIG_CRYPTO_DEV_OCTEONTX_CPT) += octeontx-cpt.o octeontx-cptvf.o
 
 octeontx-cpt-objs := otx_cptpf_main.o otx_cptpf_mbox.o otx_cptpf_ucode.o
+octeontx-cptvf-objs := otx_cptvf_main.o otx_cptvf_mbox.o otx_cptvf_reqmgr.o \
+		       otx_cptvf_algs.o
drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h +576 -1

603 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptvf.h new file +104 -0

104 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptvf_algs.c new file +1744 -0

1,744 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptvf_algs.h new file +188 -0

188 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptvf_main.c new file +985 -0

354 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptvf_mbox.c new file +247 -0

247 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c new file +612 -0

612 lines not on this page · raw message

drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.h new file +227 -0

227 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.9.1

Part of the diff is not shown here. View the raw message.

author maintainer
#4 lore raw

PATCH v2 4/4 crypto: marvell: enable OcteonTX cpt options for build

In reply to Srujana Challa

From: SrujanaChalla <[email protected]>

Add the OcteonTX cpt options in crypto Kconfig and Makefile

---
 drivers/crypto/marvell/Kconfig  | 16 ++++++++++++++++
 drivers/crypto/marvell/Makefile |  1 +
 2 files changed, 17 insertions(+)
drivers/crypto/marvell/Kconfig +16 -0
index 8262b14..1306338 100644
@@ -19,3 +19,19 @@ config CRYPTO_DEV_MARVELL_CESA
 	  Security Accelerator (CESA) which can be found on MVEBU and ORION
 	  platforms.
 	  This driver supports CPU offload through DMA transfers.
+
+config CRYPTO_DEV_OCTEONTX_CPT
+	tristate "Support for Marvell OcteonTX CPT driver"
+	depends on ARCH_THUNDER || COMPILE_TEST
+	depends on PCI_MSI && 64BIT
+	depends on CRYPTO_LIB_AES
+	select CRYPTO_SKCIPHER
+	select CRYPTO_HASH
+	select CRYPTO_AEAD
+	select CRYPTO_DEV_MARVELL
+	help
+		This driver allows you to utilize the Marvell Cryptographic
+		Accelerator Unit(CPT) found in OcteonTX series of processors.
+
+		To compile this driver as module, choose M here:
+		the modules will be called octeontx-cpt and octeontx-cptvf
drivers/crypto/marvell/Makefile +1 -0
index 2030b0b..6c6a151 100644
@@ -1,3 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0
 
 obj-$(CONFIG_CRYPTO_DEV_MARVELL_CESA) += cesa/
+obj-$(CONFIG_CRYPTO_DEV_OCTEONTX_CPT) += octeontx/
Signature · 1 line
1.9.1
maintainer
#5 lore raw
In reply to Srujana Challa
Quoted 63 lines · Srujana Challa

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

 MAINTAINERS                                        |    1 +
 drivers/crypto/Kconfig                             |   15 +-
 drivers/crypto/Makefile                            |    2 +-
 drivers/crypto/marvell/Kconfig                     |   37 +
 drivers/crypto/marvell/Makefile                    |    7 +-
 drivers/crypto/marvell/cesa.c                      |  615 -------
 drivers/crypto/marvell/cesa.h                      |  880 ----------
 drivers/crypto/marvell/cesa/Makefile               |    3 +
 drivers/crypto/marvell/cesa/cesa.c                 |  615 +++++++
 drivers/crypto/marvell/cesa/cesa.h                 |  881 ++++++++++
 drivers/crypto/marvell/cesa/cipher.c               |  801 +++++++++
 drivers/crypto/marvell/cesa/hash.c                 | 1448 ++++++++++++++++
 drivers/crypto/marvell/cesa/tdma.c                 |  352 ++++
 drivers/crypto/marvell/cipher.c                    |  798 ---------
 drivers/crypto/marvell/hash.c                      | 1442 ----------------
 drivers/crypto/marvell/octeontx/Makefile           |    6 +
 drivers/crypto/marvell/octeontx/otx_cpt_common.h   |   51 +
 drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h |  824 +++++++++
 drivers/crypto/marvell/octeontx/otx_cptpf.h        |   34 +
 drivers/crypto/marvell/octeontx/otx_cptpf_main.c   |  307 ++++
 drivers/crypto/marvell/octeontx/otx_cptpf_mbox.c   |  253 +++
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c  | 1686 +++++++++++++++++++
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h  |  180 ++
 drivers/crypto/marvell/octeontx/otx_cptvf.h        |  104 ++
 drivers/crypto/marvell/octeontx/otx_cptvf_algs.c   | 1744 ++++++++++++++++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_algs.h   |  188 +++
 drivers/crypto/marvell/octeontx/otx_cptvf_main.c   |  985 +++++++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_mbox.c   |  247 +++
 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c |  612 +++++++
 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.h |  227 +++
 drivers/crypto/marvell/tdma.c                      |  350 ----
 31 files changed, 11592 insertions(+), 4103 deletions(-)
 create mode 100644 drivers/crypto/marvell/Kconfig
 delete mode 100644 drivers/crypto/marvell/cesa.c
 delete mode 100644 drivers/crypto/marvell/cesa.h
 create mode 100644 drivers/crypto/marvell/cesa/Makefile
 create mode 100644 drivers/crypto/marvell/cesa/cesa.c
 create mode 100644 drivers/crypto/marvell/cesa/cesa.h
 create mode 100644 drivers/crypto/marvell/cesa/cipher.c
 create mode 100644 drivers/crypto/marvell/cesa/hash.c
 create mode 100644 drivers/crypto/marvell/cesa/tdma.c
 delete mode 100644 drivers/crypto/marvell/cipher.c
 delete mode 100644 drivers/crypto/marvell/hash.c
 create mode 100644 drivers/crypto/marvell/octeontx/Makefile
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cpt_common.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cpt_hw_types.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_main.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_mbox.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
Quoted 8 lines
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_algs.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_algs.h
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_main.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_mbox.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
 create mode 100644 drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.h
 delete mode 100644 drivers/crypto/marvell/tdma.c

All applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#6 lore raw
In reply to Srujana Challa
Quoted 11 lines · Srujana Challa

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

There's no mention of testing. Did you try CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?

- Eric

author maintainer
#7 lore raw
Quoted 7 lines · Srujana Challa
Quoted 6 lines

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Quoted 9 lines
Quoted 5 lines

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

There's no mention of testing. Did you try
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?

Yes, the crypto self-tests are passed.

Quoted 1 line

- Eric

#8 lore raw
Quoted 14 lines · Srujana Challa
Quoted 14 lines · Srujana Challa
Quoted 11 lines

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

Quoted 4 lines
Quoted 3 lines

There's no mention of testing. Did you try
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?

Yes, the crypto self-tests are passed.

*which* selftests are passed? Please confirm that they all passed with that kconfig option set

author maintainer
#9 lore raw
Quoted 15 lines · Srujana Challa
Quoted 14 lines
Quoted 14 lines · Srujana Challa
Quoted 11 lines

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

There's no mention of testing. Did you try
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?

Yes, the crypto self-tests are passed.

*which* selftests are passed? Please confirm that they all passed with that kconfig option set

Apologies. I have overlooked the config option, I thought it was CONFIG_CRYPTO_MANAGER_DISABLE_TESTS, all crypto self-tests are passed with this option disabled. I have started verifying with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, I am getting few errors for unsupported input lengths, will submit the patch with fixes.

author maintainer
#10 lore raw
Quoted 23 lines

Subject: RE: [EXT] Re: [PATCH v2 0/4] Add Support for Marvell OcteonTX Cryptographic

Quoted 20 lines · Srujana Challa
Quoted 18 lines
Quoted 8 lines · Srujana Challa
Quoted 6 lines

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Quoted 9 lines
Quoted 5 lines

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

There's no mention of testing. Did you try
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?

Yes, the crypto self-tests are passed.

Quoted 7 lines
Quoted 2 lines

*which* selftests are passed? Please confirm that they all passed with that kconfig option set

Apologies. I have overlooked the config option, I thought it was CONFIG_CRYPTO_MANAGER_DISABLE_TESTS, all crypto self-tests are passed with this option disabled. I have started verifying with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, I am getting few errors for unsupported input lengths, will submit the patch with fixes.

We confirmed that the failures are with unsupported lengths on our hardware, for some lengths we can resolve the issue by having validation checks in the driver but for some unsupported cases "testmgr.c" is excepting always success, I am still unsure how to fix/prevent these kind of failures. Can anyone please kindly help me out how to proceed on this issue. Thanks for your help.

#11 lore raw
Quoted 26 lines · Srujana Challa
Quoted 26 lines

Subject: RE: [EXT] Re: [PATCH v2 0/4] Add Support for Marvell OcteonTX Cryptographic

Quoted 22 lines · Srujana Challa
Quoted 14 lines
Quoted 14 lines · Srujana Challa
Quoted 11 lines

The following series adds support for Marvell Cryptographic Accelerarion Unit (CPT) on OcteonTX CN83XX SoC.

Changes since v1:
* Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.

Srujana Challa (4):
drivers: crypto: create common Kconfig and Makefile for Marvell
drivers: crypto: add support for OCTEON TX CPT engine
drivers: crypto: add the Virtual Function driver for CPT
crypto: marvell: enable OcteonTX cpt options for build

Quoted 4 lines
Quoted 3 lines

There's no mention of testing. Did you try
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?

Yes, the crypto self-tests are passed.

*which* selftests are passed? Please confirm that they all passed with that kconfig option set

Quoted 8 lines
Quoted 5 lines

Apologies. I have overlooked the config option, I thought it was CONFIG_CRYPTO_MANAGER_DISABLE_TESTS, all crypto self-tests are passed with this option disabled. I have started verifying with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, I am getting few errors for unsupported input lengths, will submit the patch with fixes.

We confirmed that the failures are with unsupported lengths on our hardware, for some lengths we can resolve the issue by having validation checks in the driver but for some unsupported cases "testmgr.c" is excepting always success, I am still unsure how to fix/prevent these kind of failures. Can anyone please kindly help me out how to proceed on this issue. Thanks for your help.

You need to allocate fallbacks for the modes that your driver cannot support. There are plenty of examples of that in the kernel tree.