edd: Use scnprintf() for avoiding potential buffer overflow
PATCH 1/1 edd: Use scnprintf() for avoiding potential buffer overflow
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf().
Signed-off-by Takashi Iwai <[email protected]>
---
This driver looks like an orphan. If no one takes it, I'm willing to merge the patch through my tree.
drivers/firmware/edd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/edd.c +3 -3
@@ -341,7 +341,7 @@ edd_show_legacy_max_cylinder(struct edd_device *edev, char *buf)if (!info || !buf)return -EINVAL ; - p +=snprintf (p, left,"%u\n" , info->legacy_max_cylinder); + p +=scnprintf (p, left,"%u\n" , info->legacy_max_cylinder);return (p - buf); }
@@ -356,7 +356,7 @@ edd_show_legacy_max_head(struct edd_device *edev, char *buf)if (!info || !buf)return -EINVAL ; - p +=snprintf (p, left,"%u\n" , info->legacy_max_head); + p +=scnprintf (p, left,"%u\n" , info->legacy_max_head);return (p - buf); }
@@ -371,7 +371,7 @@ edd_show_legacy_sectors_per_track(struct edd_device *edev, char *buf)if (!info || !buf)return -EINVAL ; - p +=snprintf (p, left,"%u\n" , info->legacy_sectors_per_track); + p +=scnprintf (p, left,"%u\n" , info->legacy_sectors_per_track);return (p - buf); }
Signature · 1 line
2.16.4