Skip to contentSkip to conversation

net/mlx5e: Fix actions_match_supported() return

PATCH In review Dan Carpenter 4 participants 5 messages Mar 20, 2020 – Mar 23, 2020

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5e: Fix actions_match_supported() return

The actions_match_supported() function returns a bool, true for success and false for failure. This error path is returning a negative which is cast to true but it should return false.

Fixes 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking")
---
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +1 -1
index 044891a03be3..e5de7d2bac2b 100644
@@ -3058,7 +3058,7 @@ static bool actions_match_supported(struct mlx5e_priv *priv,
 			 */
 			NL_SET_ERR_MSG_MOD(extack,
 					   "Can't offload mirroring with action ct");
-			return -EOPNOTSUPP;
+			return false;
 		}
 	} else {
 		actions = flow->nic_attr->action;
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Dan Carpenter

The actions_match_supported() function returns a bool, true for success and false for failure. This error path is returning a negative which is cast to true but it should return false.

Fixes 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking")
---
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,

#2 lore raw
In reply to Dan Carpenter

T24gRnJpLCAyMDIwLTAzLTIwIGF0IDE2OjIzICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K PiBUaGUgYWN0aW9uc19tYXRjaF9zdXBwb3J0ZWQoKSBmdW5jdGlvbiByZXR1cm5zIGEgYm9vbCwg dHJ1ZSBmb3INCj4gc3VjY2Vzcw0KPiBhbmQgZmFsc2UgZm9yIGZhaWx1cmUuICBUaGlzIGVycm9y IHBhdGggaXMgcmV0dXJuaW5nIGEgbmVnYXRpdmUgd2hpY2gNCj4gaXMgY2FzdCB0byB0cnVlIGJ1 dCBpdCBzaG91bGQgcmV0dXJuIGZhbHNlLg0KPiANCj4gRml4ZXM6IDRjMzg0NGQ5ZTk3ZSAoIm5l dC9tbHg1ZTogQ1Q6IEludHJvZHVjZSBjb25uZWN0aW9uIHRyYWNraW5nIikNCj4gU2lnbmVkLW9m Zi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPg0KPiAtLS0NCj4g IGRyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29yZS9lbl90Yy5jIHwgMiArLQ0K PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NS9jb3JlL2VuX3Rj LmMNCj4gYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZW5fdGMuYw0K PiBpbmRleCAwNDQ4OTFhMDNiZTMuLmU1ZGU3ZDJiYWMyYiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NS9jb3JlL2VuX3RjLmMNCj4gKysrIGIvZHJpdmVy cy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NS9jb3JlL2VuX3RjLmMNCj4gQEAgLTMwNTgsNyAr MzA1OCw3IEBAIHN0YXRpYyBib29sIGFjdGlvbnNfbWF0Y2hfc3VwcG9ydGVkKHN0cnVjdA0KPiBt bHg1ZV9wcml2ICpwcml2LA0KPiAgCQkJICovDQo+ICAJCQlOTF9TRVRfRVJSX01TR19NT0QoZXh0 YWNrLA0KPiAgCQkJCQkgICAiQ2FuJ3Qgb2ZmbG9hZCBtaXJyb3JpbmcNCj4gd2l0aCBhY3Rpb24g Y3QiKTsNCj4gLQkJCXJldHVybiAtRU9QTk9UU1VQUDsNCj4gKwkJCXJldHVybiBmYWxzZTsNCj4g IAkJfQ0KPiAgCX0gZWxzZSB7DQo+ICAJCWFjdGlvbnMgPSBmbG93LT5uaWNfYXR0ci0+YWN0aW9u Ow0KDQphcHBsaWVkIHRvIG5ldC1uZXh0LW1seDUgDQoNClRoYW5rcywNClNhZWVkLg0K

#3 lore raw
Quoted 22 lines · Saeed Mahameed
Quoted 21 lines · Dan Carpenter

The actions_match_supported() function returns a bool, true for success
and false for failure. This error path is returning a negative which is cast to true but it should return false.

Fixes 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking")
---
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +0 -0
index 044891a03be3..e5de7d2bac2b 100644
@@ -3058,7 +3058,7 @@ static bool actions_match_supported(struct
 mlx5e_priv *priv,
 			 */
 			NL_SET_ERR_MSG_MOD(extack,
 					   "Can't offload mirroring
Quoted 8 lines

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c static bool actions_match_supported(struct mlx5e_priv *priv, · line 3064

Quoted 6 lines
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +1 -1
 with action ct");
-			return -EOPNOTSUPP;
+			return false;
 		}
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +0 -0
 	} else {
 		actions = flow->nic_attr->action;

applied to net-next-mlx5

I can never figure out which tree these are supposed to be applied to. :( Is there a trick to it?

regards,
dan carpenter

maintainer
#4 lore raw
Quoted 32 lines · On Mon, 23 Mar 2020 13:02:16 +0300 Dan Carpenter wrote:
Quoted 22 lines · Saeed Mahameed
Quoted 21 lines · Dan Carpenter

The actions_match_supported() function returns a bool, true for success
and false for failure. This error path is returning a negative which is cast to true but it should return false.

Fixes 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking")
---
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +0 -0
index 044891a03be3..e5de7d2bac2b 100644
@@ -3058,7 +3058,7 @@ static bool actions_match_supported(struct
 mlx5e_priv *priv,
 			 */
 			NL_SET_ERR_MSG_MOD(extack,
 					   "Can't offload mirroring
Quoted 8 lines

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c static bool actions_match_supported(struct mlx5e_priv *priv, · line 3064

Quoted 6 lines
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +1 -1
 with action ct");
-			return -EOPNOTSUPP;
+			return false;
 		}
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +0 -0
 	} else {
 		actions = flow->nic_attr->action;  

applied to net-next-mlx5

Quoted 2 lines

I can never figure out which tree these are supposed to be applied to. :( Is there a trick to it?

Not as far as I know :/ Upstream maintainers usually know which sub-maintainers like to take patches into their own tree first.

Tagging things as "net-next" is perfectly fine in this case.

We could ask all maintainers who want to funnel patches via their own trees to add T: entries in MAINTAINERS, but I'm not sure how practical that is.