Skip to contentSkip to conversation

acpi: Add NHLT table signature

PATCH RESEND In review Cezary Rojewski 3 participants 3 messages Mar 20, 2020 – Mar 23, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 acpi: Add NHLT table signature

NHLT (Non-HDAudio Link Table) provides configuration of audio endpoints for Intel SST (Smart Sound Technology) DSP products. Similarly to other ACPI tables, data provided by BIOS may not describe it correctly, thus overriding is required.

ACPI override mechanism checks for unknown signature before proceeding. Update known signatures array to support NHLT.

Cc Erik Kaneda <[email protected]>
Cc Robert Moore <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
---
 drivers/acpi/tables.c | 2 +-
 include/acpi/actbl2.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +1 -1
index 180ac4329763..0e905c3d1645 100644
@@ -501,7 +501,7 @@ static const char * const table_sigs[] = {
 	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
 	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
 	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-	NULL };
+	ACPI_SIG_NHLT, NULL };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
include/acpi/actbl2.h +1 -0
index e45ced27f4c3..876ccf50ec36 100644
@@ -43,6 +43,7 @@
 #define ACPI_SIG_SBST           "SBST"	/* Smart Battery Specification Table */
 #define ACPI_SIG_SDEI           "SDEI"	/* Software Delegated Exception Interface Table */
 #define ACPI_SIG_SDEV           "SDEV"	/* Secure Devices table */
+#define ACPI_SIG_NHLT           "NHLT"	/* Non-HDAudio Link Table */
 
 /*
  * All tables must be byte-packed to match the ACPI specification, since
Signature · 1 line
2.17.1
#1 lore raw
Quoted 36 lines · CET Cezary Rojewski

NHLT (Non-HDAudio Link Table) provides configuration of audio endpoints for Intel SST (Smart Sound Technology) DSP products. Similarly to other ACPI tables, data provided by BIOS may not describe it correctly, thus overriding is required.

ACPI override mechanism checks for unknown signature before proceeding. Update known signatures array to support NHLT.

Cc Erik Kaneda <[email protected]>
Cc Robert Moore <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
---
 drivers/acpi/tables.c | 2 +-
 include/acpi/actbl2.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +1 -1
index 180ac4329763..0e905c3d1645 100644
@@ -501,7 +501,7 @@ static const char * const table_sigs[] = {
 	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
 	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
 	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-	NULL };
+	ACPI_SIG_NHLT, NULL };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
include/acpi/actbl2.h +0 -0
index e45ced27f4c3..876ccf50ec36 100644

include/acpi/actbl2.h line 49

Quoted 7 lines
include/acpi/actbl2.h +1 -0
@@ -43,6 +43,7 @@
 #define ACPI_SIG_SBST           "SBST"	/* Smart Battery Specification Table */
 #define ACPI_SIG_SDEI           "SDEI"	/* Software Delegated Exception Interface Table */
 #define ACPI_SIG_SDEV           "SDEV"	/* Secure Devices table */
+#define ACPI_SIG_NHLT           "NHLT"	/* Non-HDAudio Link Table */
 
 /*
  * All tables must be byte-packed to match the ACPI specification, since

This should go in through the ACPICA upstream IMO.

#2 lore raw
Quoted 58 lines

-----Original Message-----
From: [email protected] <linux-acpi- [email protected]> On Behalf Of Rafael J. Wysocki
Sent: Saturday, March 21, 2020 3:36 AM
To: Rojewski, Cezary <[email protected]>
Cc: [email protected]; [email protected]; Kaneda, Erik <[email protected]>; [email protected]; [email protected]; Kaneda, Erik <[email protected]>; Moore, Robert <[email protected]>; Wysocki, Rafael J <[email protected]>
Subject: Re: [RESEND PATCH] acpi: Add NHLT table signature

Quoted 6 lines · CET Cezary Rojewski

NHLT (Non-HDAudio Link Table) provides configuration of audio endpoints for Intel SST (Smart Sound Technology) DSP products. Similarly to other ACPI tables, data provided by BIOS may not describe it correctly, thus overriding is required.

ACPI override mechanism checks for unknown signature before

proceeding.

Quoted 16 lines

Update known signatures array to support NHLT.

Cc Erik Kaneda <[email protected]>
Cc Robert Moore <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
---
 drivers/acpi/tables.c | 2 +-
 include/acpi/actbl2.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/tables.c index renamed from drivers/acpi/tables.c +0 -0

180ac4329763..0e905c3d1645 100644

drivers/acpi/tables.c static const char * const table_sigs[] = { · line 501

Quoted 1 line
drivers/acpi/tables.c +0 -0
@@ -501,7 +501,7 @@ static const char * const table_sigs[] = {
 	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT,

ACPI_SIG_FADT,

include/acpi/actbl2.h line 43

Quoted 13 lines
drivers/acpi/tables.c +1 -1
 	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
 	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-	NULL };
+	ACPI_SIG_NHLT, NULL };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
include/acpi/actbl2.h index renamed from include/acpi/actbl2.h +0 -0

e45ced27f4c3..876ccf50ec36 100644

include/acpi/actbl2.h +0 -0
@@ -43,6 +43,7 @@
 #define ACPI_SIG_SBST           "SBST"	/* Smart Battery Specification Table

*/

include/acpi/actbl2.h line 44

Quoted 1 line
include/acpi/actbl2.h +0 -0
 #define ACPI_SIG_SDEI           "SDEI"	/* Software Delegated Exception

Interface Table */

Quoted 3 lines
include/acpi/actbl2.h +1 -0
 #define ACPI_SIG_SDEV           "SDEV"	/* Secure Devices table */
+#define ACPI_SIG_NHLT           "NHLT"	/* Non-HDAudio Link Table */
 
Quoted 7 lines
Quoted 4 lines
include/acpi/actbl2.h +0 -0
 /*
  * All tables must be byte-packed to match the ACPI specification,

since

This should go in through the ACPICA upstream IMO.

I'll add this to ACPICA for now and we'll work on implementing table compiler support for ACPICA in the near future.

Erik

Quoted 2 lines