Skip to contentSkip to conversation

stagin: hp100: space prohibited between function name and open parenthesis '('

PATCH In review Gokce Kuler 3 participants 3 messages Mar 21, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stagin: hp100: space prohibited between function name and open parenthesis '('

Delete space between funtion name and open parenthesis

---
 drivers/staging/hp/hp100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/hp/hp100.c +1 -1
index b89c4dc..551cd52 100644
@@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
 static void __exit hp100_module_exit(void)
 {
 	hp100_isa_cleanup();
-	eisa_driver_unregister (&hp100_eisa_driver);
+	eisa_driver_unregister(&hp100_eisa_driver);
 	pci_unregister_driver (&hp100_pci_driver);
 }
 
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 12 lines · Gokce Kuler

Delete space between funtion name and open parenthesis

---
 drivers/staging/hp/hp100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/hp/hp100.c +0 -0
index b89c4dc..551cd52 100644

drivers/staging/hp/hp100.c static int __init hp100_module_init(void) · line 3024

Quoted 6 lines
drivers/staging/hp/hp100.c +1 -1
@@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
 static void __exit hp100_module_exit(void)
 {
 	hp100_isa_cleanup();
-	eisa_driver_unregister (&hp100_eisa_driver);
+	eisa_driver_unregister(&hp100_eisa_driver);
 	pci_unregister_driver (&hp100_pci_driver);

Why did you just do this to only 1 line and not both in this function? How about this whole file?

thanks,

greg k-h

#2 lore raw
In reply to Gokce Kuler
Quoted 1 line · Gokce Kuler

Delete space between funtion name and open parenthesis

Greg made another comment on this, but you also have a typo in the log
message: funtion -> function

julia

Quoted 27 lines
---
 drivers/staging/hp/hp100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/hp/hp100.c +1 -2
index b89c4dc..551cd52 100644
@@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
 static void __exit hp100_module_exit(void)
 {
 	hp100_isa_cleanup();
-	eisa_driver_unregister (&hp100_eisa_driver);
+	eisa_driver_unregister(&hp100_eisa_driver);
 	pci_unregister_driver (&hp100_pci_driver);
 }
 
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200321014123.GA17832%40siyah2.