Skip to contentSkip to conversation

dt-bindings: leds: common: fix example for gpio-leds

PATCH Applied Johan Jonker 3 participants 3 messages Mar 13, 2020 – Mar 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: leds: common: fix example for gpio-leds

The preferred form for gpio-leds compatible subnodes is:
^led-[0-9a-f]$
Fix example by changing led0 and led1 to led-0 and led-1.

---
 Documentation/devicetree/bindings/leds/common.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/leds/common.yaml +2 -2
index c60b994fe..4c270fde4 100644
@@ -167,13 +167,13 @@ examples:
     led-controller {
         compatible = "gpio-leds";
 
-        led0 {
+        led-0 {
             function = LED_FUNCTION_STATUS;
             linux,default-trigger = "heartbeat";
             gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>;
         };
 
-        led1 {
+        led-1 {
             function = LED_FUNCTION_USB;
             gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
             trigger-sources = <&ohci_port1>, <&ehci_port1>;
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Johan Jonker

The preferred form for gpio-leds compatible subnodes is:
^led-[0-9a-f]$
Fix example by changing led0 and led1 to led-0 and led-1.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer Applied
#2 lore raw
In reply to Johan Jonker
Quoted 9 lines · Johan Jonker

The preferred form for gpio-leds compatible subnodes is:
^led-[0-9a-f]$
Fix example by changing led0 and led1 to led-0 and led-1.

---
 Documentation/devicetree/bindings/leds/common.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Rob