Skip to contentSkip to conversation

package/rcw: add missing host-python dependency

PATCH Superseded Laurent Hartanerot 3 participants 5 messages Mar 19, 2020 – Apr 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rcw: add missing host-python dependency

From: Laurent Hartanerot <[email protected]>

The rcw tool that compiles RCW sources file need host-python

---
 package/rcw/rcw.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/rcw/rcw.mk +5 -1
index 81e22fff93..be239a7957 100644
@@ -10,6 +10,8 @@ RCW_SITE_METHOD = git
 RCW_LICENSE = BSD-3-Clause
 RCW_LICENSE_FILES = LICENSE
 
+RCW_DEPENDENCIES = host-python
+
 RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))
 
 ifneq ($(RCW_FILES),)
@@ -39,7 +41,9 @@ endef
 HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES
 
 define HOST_RCW_BUILD_CMDS
-	python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin
+	$(HOST_DIR)/bin/python $(@D)/rcw.py \
+		-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \
+		-I $(@D)/custom_board -o $(@D)/PBL.bin
 endef
 
 define HOST_RCW_INSTALL_DELIVERY_FILE
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/rcw: add missing host-python dependency

Quoted 14 lines · On Thu, 19 Mar 2020 07:56:50 +0100 Laurent Hartanerot…

From: Laurent Hartanerot <[email protected]>

The rcw tool that compiles RCW sources file need host-python

---
 package/rcw/rcw.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/rcw/rcw.mk +0 -0
index 81e22fff93..be239a7957 100644

package/rcw/rcw.mk RCW_SITE_METHOD = git · line 13

Quoted 4 lines
package/rcw/rcw.mk +1 -0
@@ -10,6 +10,8 @@ RCW_SITE_METHOD = git
 RCW_LICENSE = BSD-3-Clause
 RCW_LICENSE_FILES = LICENSE
 
+RCW_DEPENDENCIES = host-python

This should be:

HOST_RCW_DEPENDENCIES = host-python

Indeed, rcw is only available as host package.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/rcw: add missing host-python dependency

In reply to Laurent Hartanerot

From: Laurent Hartanerot <[email protected]>

The rcw tool that compiles RCW sources file need host-python

---
 package/rcw/rcw.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/rcw/rcw.mk +5 -1
index 81e22fff93..dbfeae7b21 100644
@@ -10,6 +10,8 @@ RCW_SITE_METHOD = git
 RCW_LICENSE = BSD-3-Clause
 RCW_LICENSE_FILES = LICENSE
 
+HOST_RCW_DEPENDENCIES = host-python
+
 RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))
 
 ifneq ($(RCW_FILES),)
@@ -39,7 +41,9 @@ endef
 HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES
 
 define HOST_RCW_BUILD_CMDS
-	python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin
+	$(HOST_DIR)/bin/python $(@D)/rcw.py \
+		-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \
+		-I $(@D)/custom_board -o $(@D)/PBL.bin
 endef
 
 define HOST_RCW_INSTALL_DELIVERY_FILE
Signature · 1 line
2.20.1
#3 lore raw

PATCH v2 1/1 package/rcw: add missing host-python dependency

Quoted 8 lines · On Thu, 19 Mar 2020 10:30:57 +0100 Laurent Hartanerot…

From: Laurent Hartanerot <[email protected]>

The rcw tool that compiles RCW sources file need host-python

---
 package/rcw/rcw.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com