Skip to contentSkip to conversation

rtc: bd70528: Avoid double error messaging when IRQ absent

PATCH Applied Keyur Patel 2 participants 2 messages Mar 21, 2020 – Mar 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: bd70528: Avoid double error messaging when IRQ absent

Since the commit 7723f4c ("driver core: platform: Add an error message to platform_get_irq*()") platform_get_irq() started issuing an error message. Thus, there is no need to have the same in the driver.

---
 drivers/rtc/rtc-bd70528.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/rtc/rtc-bd70528.c +1 -3
index bbbb1f07c91f..4492b770422c 100644
@@ -542,10 +542,8 @@ static int bd70528_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq_byname(pdev, irq_name);
 
-	if (irq < 0) {
-		dev_err(&pdev->dev, "Failed to get irq\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	platform_set_drvdata(pdev, bd_rtc);
 
Signature · 1 line
2.25.0
maintainer Applied
#1 lore raw
Quoted 9 lines · Keyur Patel

Since the commit 7723f4c ("driver core: platform: Add an error message to platform_get_irq*()") platform_get_irq() started issuing an error message. Thus, there is no need to have the same in the driver.

---
 drivers/rtc/rtc-bd70528.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com