drm/vkms: enable cursor by default
Melissa Wen
reviewerPATCH 1/1 drm/vkms: enable cursor by default
This patch proposes a change in the behavior of the cursor to enable it as soon as the vkms module is added. Enabling the cursor by default appears to be an expected and more friendly behavior, especially when running IGT tests.
--- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vkms/vkms_drv.c +1 -1
@@ -34,7 +34,7 @@static struct vkms_device *vkms_device; -bool enable_cursor; +bool enable_cursor = true;module_param_named (enable_cursor, enable_cursor, bool,0444 );MODULE_PARM_DESC (enable_cursor,"Enable/Disable cursor support" );
Signature · 6 lines
2.25.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Melissa,
First of all, thanks for your patch.
I agree with you, it makes more sense to me if we enable cursors by default. I don't remember why we decided to add it as a disabled by default.
Quoted 26 lines · Melissa Wen
This patch proposes a change in the behavior of the cursor to enable it as soon as the vkms module is added. Enabling the cursor by default appears to be an expected and more friendly behavior, especially when running IGT tests.
Signed-off-by Melissa Wen <[email protected]>--- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vkms/vkms_drv.c +1
-1@@ -34,7 +34,7 @@static struct vkms_device *vkms_device; -bool enable_cursor; +bool enable_cursor = true;module_param_named (enable_cursor, enable_cursor, bool,0444 );MODULE_PARM_DESC (enable_cursor,"Enable/Disable cursor support" );Signature · 1 line
2.25.1
Signature · 2 lines
Rodrigo Siqueira https://siqueira.tech
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rodrigo Siqueira
AppliedApplied to drm-misc-next.
Quoted 41 lines · Rodrigo Siqueira
Hi Melissa,
First of all, thanks for your patch.
I agree with you, it makes more sense to me if we enable cursors by default. I don't remember why we decided to add it as a disabled by default.
Reviewed-by Rodrigo Siqueira <[email protected]>Quoted 26 lines · Melissa Wen
This patch proposes a change in the behavior of the cursor to enable it as soon as the vkms module is added. Enabling the cursor by default appears to be an expected and more friendly behavior, especially when running IGT tests.
Signed-off-by Melissa Wen <[email protected]>--- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vkms/vkms_drv.c +1
-1@@ -34,7 +34,7 @@static struct vkms_device *vkms_device; -bool enable_cursor; +bool enable_cursor = true;module_param_named (enable_cursor, enable_cursor, bool,0444 );MODULE_PARM_DESC (enable_cursor,"Enable/Disable cursor support" );Signature · 1 line
2.25.1Signature · 2 lines
Rodrigo Siqueira https://siqueira.tech
Signature · 2 lines
Rodrigo Siqueira https://siqueira.tech
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel