Skip to contentSkip to conversation

staging: hp100: rearrange line exceeding 80 characters

PATCH In review Gokce Kuler 2 participants 2 messages Mar 22, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: hp100: rearrange line exceeding 80 characters

moved to the bottom line after && operator for it exceeds 80 character

---
 drivers/staging/hp/hp100.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/hp/hp100.c +2 -1
index 61b891d..8aadb5b 100644
@@ -1407,7 +1407,8 @@ static void hp100_BM_shutdown(struct net_device *dev)
 			for (time = 0; time < 10000; time++) {
 				/* RX_PDL: PDLs not executed. */
 				/* RX_PKT_CNT: RX'd packets on card. */
-				if ((hp100_inb(RX_PDL) == 0) && (hp100_inb(RX_PKT_CNT) == 0))
+				if ((hp100_inb(RX_PDL) == 0) &&
+			       	    (hp100_inb(RX_PKT_CNT) == 0))
 					break;
 			}
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 1 line · Gokce Kuler

moved to the bottom line after && operator for it exceeds 80 character

Sentences need to begin with a capital letter and end with a period. It may seem picky, but in an open source setting, this is the only form of communication available, so things need to be done in an expected way.

Maybe the tests could be rewritten with ! and then the whole thing could stay on one line.

julia

Quoted 28 lines
---
 drivers/staging/hp/hp100.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/hp/hp100.c +2 -2
index 61b891d..8aadb5b 100644
@@ -1407,7 +1407,8 @@ static void hp100_BM_shutdown(struct net_device *dev)
 			for (time = 0; time < 10000; time++) {
 				/* RX_PDL: PDLs not executed. */
 				/* RX_PKT_CNT: RX'd packets on card. */
-				if ((hp100_inb(RX_PDL) == 0) && (hp100_inb(RX_PKT_CNT) == 0))
+				if ((hp100_inb(RX_PDL) == 0) &&
+			       	    (hp100_inb(RX_PKT_CNT) == 0))
 					break;
 			}
 
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322011612.GA4357%40siyah2.