package/rcw : bump to LSDK-19.09
PATCH 1/1 package/rcw : bump to LSDK-19.09
From: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
package/rcw/rcw.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE
package/rcw/rcw.mk +2 -2
@@ -4,7 +4,7 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause
@@ -39,7 +39,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin + python3 $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin endef define HOST_RCW_INSTALL_DELIVERY_FILE
Signature · 1 line
2.20.1
PATCH 1/1 package/rcw : bump to LSDK-19.09
Hello Laurent,
Thanks for your contribution, see below for a review.
Quoted 33 lines · On Wed, 18 Mar 2020 08:14:27 +0100 Laurent Hartanerot…
From: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
Signed-off-by Laurent Hartanerot <[email protected]>--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)package/rcw/rcw.hash +1
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSEpackage/rcw/rcw.mk +1
-1@@ -4,7 +4,7 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause
package/rcw/rcw.mk endef · line 42
Quoted 5 lines
package/rcw/rcw.mk +1
-1@@ -39,7 +39,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin + python3 $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin
We don't have any guarantee that python3 is available on the build machine. And in fact, since commit 9c0c7846cdb63f3ed62563c4f532ad02ad0a1c98 we also don't have the guarantee that python is available on the build machine.
So, here, we would need two patches:
- A first patch that is a fix to the package in its current version. It should add host-python to its dependencies, and make sure $(HOST_DIR)/bin/python gets used. This way, the patch can be backported to our LTS branch 2020.02.
- A second patch that bumps the package to LSDK-19.09, switches to using $(BR2_PYTHON3_HOST_DEPENDENCY) in HOST_RCW_DEPENDENCIES, and then be careful to use python3, but with $(HOST_DIR)/bin in the PATH, so that either the system-wide python3 is used, or the one built by Buildroot.
Could you look into doing this ?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/rcw : bump to LSDK-19.09
In reply to Laurent HartanerotFrom: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
package/rcw/rcw.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE
package/rcw/rcw.mk +3 -3
@@ -4,13 +4,13 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = host-python3 RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))
@@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + $(HOST_DIR)/bin/python3 $(@D)/rcw.py \ -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endef
Signature · 1 line
2.20.1
PATCH v2 1/1 package/rcw : bump to LSDK-19.09
Laurent, All,
On 2020-03-22 11:31 +0100, Laurent Hartanerot spake thusly:
Quoted 26 lines
From: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
Signed-off-by Laurent Hartanerot <[email protected]>--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)package/rcw/rcw.hash +1
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSEpackage/rcw/rcw.mk +0
-0@@ -4,13 +4,13 @@ # ################################################################################
package/rcw/rcw.mk line 13
Quoted 10 lines
package/rcw/rcw.mk +2
-2-RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = host-python3
As far as I can see, that's not what Thomas requested in his previous review http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html
Thomas requested that the bump be split in two changes:
- a first patch that does not update the version, but adds the missing
dependency to host-python, making sure to use by replacing the call
to 'python' by a call to $(HOST_DIR)/bin/python, so that we can
backport that fix into our LTS branch, 2020.02;- a second patch that does the version bump, and in the process, changes the dependency on host-python to using the conditional depednency set in the variable $(BR2_PYTHON3_HOST_DEPENDENCY).
If you have issues with the above, then do not hesitate to explain your concerns, instead of re-sending almost exactly the same change.
In the meantime, I've marked the patch as changes-requested in patchwork.
Regards,
Yann E. MORIN.
Quoted 18 lines
package/rcw/rcw.mk +1
-1RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))@@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + $(HOST_DIR)/bin/python3 $(@D)/rcw.py \ -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endefSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/rcw : bump to LSDK-19.09
Hello Yann,
Thank you for the feedback,
- I thought I followed the explanations by making a first patch :
https://patchwork.ozlabs.org/patch/1258063/
and the second patch (this) for the version bump...
Maybe, I shouldn't have done it in response to this email (--in-reply-to=)
- I take this opportunity to explain why I have not used +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) but
+HOST_RCW_DEPENDENCIES = host-python3
in the first case the host-python3 dependency is not added
When I check the varaibles (in the first case) I get :
$ make printvars "VARS=HOST_RCW_DEPENDENCIES" HOST_RCW_DEPENDENCIES= host-skeleton $ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY"
but in the second case :
$ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY" $ make printvars "VARS=HOST_RCW_DEPENDENCIES" HOST_RCW_DEPENDENCIES=host-python3 host-skeleton
I don't find the reason why $(BR2_PYTHON3_HOST_DEPENDENCY) is not equals to host-python3.
Thanks for support
Le dim. 22 mars 2020 ? 14:13, Yann E. MORIN <[email protected]> a ?crit :
Quoted 100 lines
Laurent, All,
On 2020-03-22 11:31 +0100, Laurent Hartanerot spake thusly:
Quoted 15 lines
From: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
Signed-off-by Laurent Hartanerot <[email protected]>--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)package/rcw/rcw.hash +0
-0package/rcw/rcw.hash line 2
Quoted 2 lines
package/rcw/rcw.hash +0
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3rcw-LSDK-18.12.tar.gz
package/rcw/rcw.hash line 2
Quoted 1 line
package/rcw/rcw.hash +1
-0+sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1rcw-LSDK-19.09.tar.gz
package/rcw/rcw.hash line 3
Quoted 1 line
package/rcw/rcw.hash +0
-0sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcdLICENSE
package/rcw/rcw.mk line 5
Quoted 7 lines
package/rcw/rcw.mk +0
-0@@ -4,13 +4,13 @@ #################################################################################
package/rcw/rcw.mk
Quoted 4 lines
package/rcw/rcw.mk +1
-1-RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE =https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
package/rcw/rcw.mk line 13
Quoted 6 lines
package/rcw/rcw.mk +1
-1RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = host-python3As far as I can see, that's not what Thomas requested in his previous review http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html
Thomas requested that the bump be split in two changes:
- a first patch that does not update the version, but adds the missing
dependency to host-python, making sure to use by replacing the call to 'python' by a call to $(HOST_DIR)/bin/python, so that we can backport that fix into our LTS branch, 2020.02;- a second patch that does the version bump, and in the process, changes the dependency on host-python to using the conditional depednency set in the variable $(BR2_PYTHON3_HOST_DEPENDENCY).
If you have issues with the above, then do not hesitate to explain your concerns, instead of re-sending almost exactly the same change.
In the meantime, I've marked the patch as changes-requested in patchwork.
Regards,
Yann E. MORIN.Quoted 14 lines
package/rcw/rcw.mk +1
-2RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))@@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + $(HOST_DIR)/bin/python3 $(@D)/rcw.py \ -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endef --2.20.1
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
Signature · 6 lines
Laurent HARTANEROT Laurent.Hartanerot at gmail.com tel : 06 49 14 93 74 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200322/8f66a89c/attachment.html>
PATCH v2 1/1 package/rcw : bump to LSDK-19.09
Laurent, All,
On 2020-03-22 15:51 +0100, Laurent Hartanerot spake thusly:
Quoted 6 lines
Hello Yann,
Thank you for the feedback,
- I thought I followed the explanations by making a first patch :
[1]https://patchwork.ozlabs.org/patch/1258063/
and the second patch (this) for the version bump...
Maybe, I shouldn't have done it in response to this email (--in-reply-to=)
Ah, sorry, I had missed that one (and so did not completely understand where the existing dependency on host-python came from... My bad.
Quoted 6 lines
- I take this opportunity to explain why I have not used +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) but
+HOST_RCW_DEPENDENCIES = host-python3
in the first case the host-python3 dependency is not added When I check the varaibles (in the first case) I get :
Quoted 8 lines
$ make printvars "VARS=HOST_RCW_DEPENDENCIES" HOST_RCW_DEPENDENCIES= host-skeleton $ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY" but in the second case : $ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY" $ make printvars "VARS=HOST_RCW_DEPENDENCIES" HOST_RCW_DEPENDENCIES=host-python3 host-skeleton I don't find the reason why $(BR2_PYTHON3_HOST_DEPENDENCY) is not equals to host-python3.
That's probably because you already have a python3 installed in your machine?
That's exactly the purpose of BR2_PYTHON3_HOST_DEPENDENCY: if the build machine already has a python3 (3.4 or later), then there is no need to build our own. If the build machine does not already have python3 or it is older than 3.4, then we need to build our own.
See:
support/dependencies/check-host-python3.mk
support/dependencies/check-host-python3.sh
Regards,
Yann E. MORIN.
Quoted 114 lines
Thanks for support
Le?dim. 22 mars 2020 ??14:13, Yann E. MORIN < [2][email protected]> a ?crit?:Laurent, All,
On 2020-03-22 11:31 +0100, Laurent Hartanerot spake thusly:
Quoted 34 lines
From: Laurent Hartanerot < [3][email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
Signed-off-by Laurent Hartanerot < [4][email protected]>---
? package/rcw/rcw.hash | 2 +-
? package/rcw/ [5]rcw.mk? ?| 6 +++---
? 2 files changed, 4 insertions(+), 4 deletions(-)package/rcw/rcw.hash +0
-0@@ -1,3 +1,3 @@? # Locally calculated
package/rcw/rcw.hash +1
-1-sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz? sha256
a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcdLICENSEpackage/rcw/ [9]rcw.mk renamed from package/rcw/ [8]rcw.mk +0
-0@@ -4,13 +4,13 @@? #
? ################################################################################ ?package/rcw/ [9]rcw.mk renamed from package/rcw/ [8]rcw.mk +1
-1-RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09?
RCW_SITE= [10]https://source.codeaurora.org/external/qoriq/qoriq-components/rcw ?RCW_SITE_METHOD= git
?RCW_LICENSE= BSD-3-Clause
?RCW_LICENSE_FILES= LICENSE
?package/rcw/ [9]rcw.mk
Quoted 2 lines
package/rcw/ [9]rcw.mk renamed from package/rcw/ [8]rcw.mk +1
-1-HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = host-python3As far as I can see, that's not what Thomas requested in his previous review [11]http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html
Thomas requested that the bump be split in two changes:
? - a first patch that does not update the version, but adds the missing ? ? dependency to host-python, making sure to use by replacing the call ? ? to 'python' by a call to $(HOST_DIR)/bin/python, so that we can ? ? backport that fix into our LTS branch, 2020.02;
? - a second patch that does the version bump, and in the process, ? ? changes the dependency on host-python to using the conditional ? ? depednency set in the variable $(BR2_PYTHON3_HOST_DEPENDENCY).
If you have issues with the above, then do not hesitate to explain your concerns, instead of re-sending almost exactly the same change.
In the meantime, I've marked the patch as changes-requested in patchwork.
Regards,
Yann E. MORIN.Quoted 14 lines
?
RCW_FILES= $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) ?package/rcw/ [9]rcw.mk renamed from package/rcw/ [8]rcw.mk +0
-0@@ -41,7 +41,7 @@ endef?
HOST_RCW_POST_PATCH_HOOKS+=HOST_RCW_ADD_CUSTOM_RCW_FILES?
? defineHOST_RCW_BUILD_CMDS
-? ? ?$(HOST_DIR)/bin/python $(@D)/rcw.py \
+? ? ?$(HOST_DIR)/bin/python3 $(@D)/rcw.py \
? ? ? ? ? ? ? ?-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \
? ? ? ? ? ? ? ?-I $(@D)/custom_board -o $(@D)/PBL.bin ? endef
--
2.20.1Quoted 4 lines
_______________________________________________
buildroot mailing list
[12]buildroot at busybox.net [13]http://lists.busybox.net/mailman/listinfo/buildroot--
.-----------------.--------------------.------------------.--------------------.|? Yann E. MORIN? | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software? Designer | \ / CAMPAIGN? ? ?|? ___? ? ? ? ? ? ? ?| | +33 561 099 427 `------------.-------:? X? AGAINST? ? ? |? \e/? There is no? | | [14]http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL? ? |? ?v? ?conspiracy.? |'------------------------------^-------^------------------^--------------------'
--
Laurent HARTANEROT
[15]Laurent.Hartanerot at gmail.com
tel : 06 49 14 93 74Links:
1. https://patchwork.ozlabs.org/patch/1258063/
2. mailto:yann.morin.1998 at free.fr
3. mailto:laurent.hartanerot at atos.net
4. mailto:laurent.hartanerot at atos.net
5. http://rcw.mk
6. http://rcw.mk
7. http://rcw.mk
8. http://rcw.mk
9. http://rcw.mk
10. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
11. http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html
12. mailto:buildroot at busybox.net
13. http://lists.busybox.net/mailman/listinfo/buildroot
14. http://ymorin.is-a-geek.org/
15. mailto:Laurent.Hartanerot at gmail.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/rcw : bump to LSDK-19.09
Yann, All,
That's probably because you already have a python3 installed in your
Quoted 2 lines
machine?
Yes it is.
Quoted 10 lines
That's exactly the purpose of
BR2_PYTHON3_HOST_DEPENDENCY: if the build machine already has a python3 (3.4 or later), then there is no need to build our own. If the build machine does not already have python3 or it is older than 3.4, then we need to build our own.See:
support/dependencies/check-host-python3.mk
support/dependencies/check-host-python3.sh
I understand that.
But, in this case, we cannot use the syntax ($(HOST_DIR)/bin/python3). What is the correct syntax ?
Quoted 16 lines
Links:
Quoted 15 lines
1. https://patchwork.ozlabs.org/patch/1258063/
2. mailto:yann.morin.1998 at free.fr
3. mailto:laurent.hartanerot at atos.net
4. mailto:laurent.hartanerot at atos.net
5. http://rcw.mk
6. http://rcw.mk
7. http://rcw.mk
8. http://rcw.mk
9. http://rcw.mk
10. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
11. http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html
12. mailto:buildroot at busybox.net
13. http://lists.busybox.net/mailman/listinfo/buildroot
14. http://ymorin.is-a-geek.org/
15. mailto:Laurent.Hartanerot at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200322/9f4db92f/attachment.html>
PATCH v2 1/1 package/rcw : bump to LSDK-19.09
Laurent, All,
On 2020-03-22 16:29 +0100, Laurent Hartanerot spake thusly:
Quoted 5 lines
That's exactly the purpose of
BR2_PYTHON3_HOST_DEPENDENCY: if the build machine already has a python3 (3.4 or later), then there is no need to build our own. If the build machine does not already have python3 or it is older than 3.4, then we need to build our own.
Quoted 8 lines
See:
? ? support/dependencies/ [1]check-host-python3.mk ? ?support/dependencies/check-host-python3.sh?
I understand that.
But, in this case, we cannot use the syntax ($(HOST_DIR)/bin/python3). What is the correct syntax ?
Ah, right, I see your problem: you are calling directly to python3. What you should be able to do then, is something like:
PATH="$(BR_PATH)"; \
python3 blablabla...Regards,
Yann E. MORIN.
Quoted 34 lines
Quoted 8 lines
Links:
1. [2]https://patchwork.ozlabs.org/patch/1258063/
2. mailto: [3]yann.morin.1998 at free.fr
3. mailto: [4]laurent.hartanerot at atos.net
4. mailto: [5]laurent.hartanerot at atos.net
5. [6]http://rcw.mk
6. [7]http://rcw.mk
7. [8]http://rcw.mkQuoted 8 lines
8. [9]http://rcw.mk
9. [10]http://rcw.mk
10. [11]https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
11. [12]http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html
12. mailto: [13]buildroot at busybox.net
13. [14]http://lists.busybox.net/mailman/listinfo/buildroot
14. [15]http://ymorin.is-a-geek.org/
15. mailto: [16]Laurent.Hartanerot at gmail.comLinks:
1. http://check-host-python3.mk
2. https://patchwork.ozlabs.org/patch/1258063/
3. mailto:yann.morin.1998 at free.fr
4. mailto:laurent.hartanerot at atos.net
5. mailto:laurent.hartanerot at atos.net
6. http://rcw.mk
7. http://rcw.mk
8. http://rcw.mk
9. http://rcw.mk
10. http://rcw.mk
11. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
12. http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html
13. mailto:buildroot at busybox.net
14. http://lists.busybox.net/mailman/listinfo/buildroot
15. http://ymorin.is-a-geek.org/
16. mailto:Laurent.Hartanerot at gmail.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v3 1/1 package/rcw : bump to LSDK-19.09
In reply to Laurent HartanerotFrom: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
package/rcw/rcw.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE
package/rcw/rcw.mk +3 -3
@@ -4,13 +4,13 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))
@@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + python3 $(@D)/rcw.py \ -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endef
Signature · 1 line
2.20.1
PATCH v3 1/1 package/rcw : bump to LSDK-19.09
Laurent, All,
On 2020-03-22 17:24 +0100, Laurent Hartanerot spake thusly:
Quoted 40 lines
From: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
Signed-off-by Laurent Hartanerot <[email protected]>--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)package/rcw/rcw.hash +1
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSEpackage/rcw/rcw.mk +2
-2@@ -4,13 +4,13 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))
package/rcw/rcw.mk endef · line 44
Quoted 5 lines
package/rcw/rcw.mk +1
-1@@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + python3 $(@D)/rcw.py \
This would not work if building our own host-python3, because it most probably is not in the default PATH, which by the way I explained in a previous mail.
Furthermore, this can all be highyl simplified, because the script is not a direct python3 script, it uses /usr/bin/env as shebang, so will properly find the appropriate python3 from the PATH.
I've fixed that and pushed to master. Please review my commit and verify it also still works for you, please. Thanks!
Regards,
Yann E. MORIN.
Quoted 10 lines
package/rcw/rcw.mk +0
-0-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endefSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v3 1/1 package/rcw : bump to LSDK-19.09
Yann, All,
Sorry, I did not understand what you wanted me to do in your previous email.
Now, looking at your patch, it's clearer.
I just tested the modification. It's ok for me.
Thank's Yann
Le dim. 22 mars 2020 ? 22:09, Yann E. MORIN <[email protected]> a ?crit :
Quoted 93 lines
Laurent, All,
On 2020-03-22 17:24 +0100, Laurent Hartanerot spake thusly:
Quoted 15 lines
From: Laurent Hartanerot <[email protected]>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
Signed-off-by Laurent Hartanerot <[email protected]>--- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)package/rcw/rcw.hash +0
-0package/rcw/rcw.hash line 2
Quoted 2 lines
package/rcw/rcw.hash +0
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3rcw-LSDK-18.12.tar.gz
package/rcw/rcw.hash line 2
Quoted 1 line
package/rcw/rcw.hash +1
-0+sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1rcw-LSDK-19.09.tar.gz
package/rcw/rcw.hash line 3
Quoted 1 line
package/rcw/rcw.hash +0
-0sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcdLICENSE
package/rcw/rcw.mk line 5
Quoted 7 lines
package/rcw/rcw.mk +0
-0@@ -4,13 +4,13 @@ #################################################################################
package/rcw/rcw.mk
Quoted 4 lines
package/rcw/rcw.mk +1
-1-RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE =https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
Quoted 10 lines
package/rcw/rcw.mk +1
-1RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH))package/rcw/rcw.mk endef · line 44
Quoted 5 lines
package/rcw/rcw.mk +1
-1@@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + python3 $(@D)/rcw.py \This would not work if building our own host-python3, because it most probably is not in the default PATH, which by the way I explained in a previous mail.
Furthermore, this can all be highyl simplified, because the script is not a direct python3 script, it uses
/usr/bin/envas shebang, so will properly find the appropriate python3 from the PATH.I've fixed that and pushed to master. Please review my commit and verify it also still works for you, please. Thanks!
Regards,
Yann E. MORIN.Quoted 10 lines
package/rcw/rcw.mk +0
-1-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endef --2.20.1
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
Signature · 6 lines
Laurent HARTANEROT Laurent.Hartanerot at gmail.com tel : 06 49 14 93 74 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200323/aedaea9a/attachment.html>
PATCH v3 1/1 package/rcw : bump to LSDK-19.09
Laurent, All,
On 2020-03-23 07:56 +0100, Laurent Hartanerot spake thusly:
Quoted 4 lines
Yann, All,
Sorry, I did not understand what you wanted me to do in your previous email. Now, looking at your patch, it's clearer.
I just tested the modification. It's ok for me.
Thanks for the feedback, and sorry for my messy explanations...
Regards,
Yann E. MORIN.
Quoted 105 lines
Thank's Yann
Le?dim. 22 mars 2020 ??22:09, Yann E. MORIN < [1][email protected]> a ?crit?:Laurent, All,
On 2020-03-22 17:24 +0100, Laurent Hartanerot spake thusly: > From: Laurent Hartanerot < [2][email protected]> > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > Signed-off-by: Laurent Hartanerot < [3][email protected]> > --- >? package/rcw/rcw.hash | 2 +- >? package/rcw/ [4]rcw.mk? ?| 6 +++--- >? 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > index 7de1ec659a..76b6373942 100644 > --- a/package/rcw/rcw.hash > +++ b/package/rcw/rcw.hash > @@ -1,3 +1,3 @@ >? # Locally calculated > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz >? sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE > diff --git a/package/rcw/ [5]rcw.mk b/package/rcw/ [6]rcw.mk > index dbfeae7b21..10e357ed69 100644 > --- a/package/rcw/ [7]rcw.mk > +++ b/package/rcw/ [8]rcw.mk > @@ -4,13 +4,13 @@ >? # >? ################################################################################ >? > -RCW_VERSION = LSDK-18.12 > +RCW_VERSION = LSDK-19.09 >? RCW_SITE = [9]https://source.codeaurora.org/external/qoriq/qoriq-components/rcw >? RCW_SITE_METHOD = git >? RCW_LICENSE = BSD-3-Clause >? RCW_LICENSE_FILES = LICENSE >? > -HOST_RCW_DEPENDENCIES = host-python > +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) >? >? RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) >? > @@ -41,7 +41,7 @@ endef >? HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES >? >? define HOST_RCW_BUILD_CMDS > -? ? ?$(HOST_DIR)/bin/python $(@D)/rcw.py \ > +? ? ?python3 $(@D)/rcw.py \This would not work if building our own host-python3, because it most probably is not in the default PATH, which by the way I explained in a previous mail.
Furthermore, this can all be highyl simplified, because the script is not a direct python3 script, it uses
/usr/bin/envas shebang, so will properly find the appropriate python3 from the PATH.I've fixed that and pushed to master. Please review my commit and verify it also still works for you, please. Thanks!
Regards,
Yann E. MORIN.Quoted 10 lines
? ? ? ? ? ? ? ?-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \
? ? ? ? ? ? ? ?-I $(@D)/custom_board -o $(@D)/PBL.bin ? endef
--
2.20.1_______________________________________________
buildroot mailing list
[10]buildroot at busybox.net [11]http://lists.busybox.net/mailman/listinfo/buildroot--
.-----------------.--------------------.------------------.--------------------.|? Yann E. MORIN? | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software? Designer | \ / CAMPAIGN? ? ?|? ___? ? ? ? ? ? ? ?| | +33 561 099 427 `------------.-------:? X? AGAINST? ? ? |? \e/? There is no? | | [12]http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL? ? |? ?v? ?conspiracy.? |'------------------------------^-------^------------------^--------------------'
--
Laurent HARTANEROT
[13]Laurent.Hartanerot at gmail.com
tel : 06 49 14 93 74Links:
1. mailto:yann.morin.1998 at free.fr
2. mailto:laurent.hartanerot at atos.net
3. mailto:laurent.hartanerot at atos.net
4. http://rcw.mk
5. http://rcw.mk
6. http://rcw.mk
7. http://rcw.mk
8. http://rcw.mk
9. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
10. mailto:buildroot at busybox.net
11. http://lists.busybox.net/mailman/listinfo/buildroot
12. http://ymorin.is-a-geek.org/
13. mailto:Laurent.Hartanerot at gmail.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'