Skip to contentSkip to conversation

Remove space after * in pointer declarations

PATCH In review Soumyajit Deb 2 participants 2 messages Mar 22, 2020 – Mar 23, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove space after * in pointer declarations

Remove space after * in pointer declaration to improve code readability and to adhere to the standard coding style.
Reported by checkpatch.pl

---
 drivers/staging/hp/hp100.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/hp/hp100.c +5 -5
index 00b3db8144c3..2cf1104cd2dd 100644
@@ -246,11 +246,11 @@ static void hp100_BM_shutdown(struct net_device *dev);
 static void hp100_mmuinit(struct net_device *dev);
 static void hp100_init_pdls(struct net_device *dev);
 static int hp100_init_rxpdl(struct net_device *dev,
-			    register hp100_ring_t * ringptr,
-			    register u_int * pdlptr);
+			    register hp100_ring_t *ringptr,
+			    register u_int *pdlptr);
 static int hp100_init_txpdl(struct net_device *dev,
-			    register hp100_ring_t * ringptr,
-			    register u_int * pdlptr);
+			    register hp100_ring_t *ringptr,
+			    register u_int *pdlptr);
 static void hp100_rxfill(struct net_device *dev);
 static void hp100_hwinit(struct net_device *dev);
 static void hp100_clean_txring(struct net_device *dev);
@@ -264,7 +264,7 @@ static void hp100_RegisterDump(struct net_device *dev);
  * because it was properly DMA allocated via pci_alloc_consistent(),
  * so we just need to "retrieve" the original mapping to bus/phys/dma
  * address - Jean II */
-static inline dma_addr_t virt_to_whatever(struct net_device *dev, u32 * ptr)
+static inline dma_addr_t virt_to_whatever(struct net_device *dev, u32 *ptr)
 {
 	struct hp100_private *lp = netdev_priv(dev);
 	return ((u_long) ptr) + lp->whatever_offset;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 8 lines · Soumyajit Deb

Remove space after * in pointer declaration to improve code readability and to adhere to the standard coding style.
Reported by checkpatch.pl

---
 drivers/staging/hp/hp100.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

There is no "staging" or driver name in the subject line here :(

Please fix up and resend.

thanks,

greg k-h