package/collectd: make network crypto support discoverable
PATCH 1/1 package/collectd: make network crypto support discoverable
before it was completely non-obvious how to get crypto support in collectd's network module
this introduces a collectd config option which makes sure gcrypt is built, and can't be accidentally unselected resulting in an accidental non-crypto build of collectd
--- package/collectd/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)
package/collectd/Config.in +7 -0
@@ -603,6 +603,13 @@ config BR2_PACKAGE_COLLECTD_NETWORK help Send/receive values from other instances of collectd. +config BR2_PACKAGE_COLLECTD_NETWORK_GCRYPT + bool "crypto support" + depends on BR2_PACKAGE_COLLECTD_NETWORK + select BR2_PACKAGE_LIBGCRYPT + help + Enable crypto support + config BR2_PACKAGE_COLLECTD_RRDTOOL bool "rrdtool" depends on BR2_USE_WCHAR # rrdtool
Signature · 1 line
2.17.1
Thomas Petazzoni
AppliedPATCH 1/1 package/collectd: make network crypto support discoverable
Quoted 11 lines · On Wed, 11 Mar 2020 14:35:04 +0100 Pascal de Bruijn <[email protected]>…
before it was completely non-obvious how to get crypto support in collectd's network module
this introduces a collectd config option which makes sure gcrypt is built, and can't be accidentally unselected resulting in an accidental non-crypto build of collectd
Signed-off-by Pascal de Bruijn <[email protected]>--- package/collectd/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/collectd: make network crypto support discoverable
In reply to Pascal de BruijnQuoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Pascal" == Pascal de Bruijn <[email protected]> writes:
before it was completely non-obvious how to get crypto support in collectd's network module
this introduces a collectd config option which makes sure gcrypt is built, and can't be accidentally unselected resulting in an accidental non-crypto build of collectd
Signed-off-by Pascal de Bruijn <[email protected]>--- package/collectd/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)package/collectd/Config.in +0
-0
package/collectd/Config.in config BR2_PACKAGE_COLLECTD_NETWORK · line 611
Quoted 9 lines
package/collectd/Config.in +6
-0@@ -603,6 +603,13 @@ config BR2_PACKAGE_COLLECTD_NETWORK help Send/receive values from other instances of collectd. +config BR2_PACKAGE_COLLECTD_NETWORK_GCRYPT + bool "crypto support" + depends on BR2_PACKAGE_COLLECTD_NETWORK + select BR2_PACKAGE_LIBGCRYPT + help + Enable crypto support
It would IMHO also make sense to change the conditional in collectd.mk to use this symbol so crypto support is really disabled if this option is turned off, otherwise it is just confusing in the other direction now.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/collectd: make network crypto support discoverable
Quoted 11 lines · On Tue, 07 Apr 2020 18:06:19 +0200 Peter Korsgaard <[email protected]> wrote:
package/collectd/Config.in config BR2_PACKAGE_COLLECTD_NETWORK · line 611
Quoted 6 lines
package/collectd/Config.in +6
-0+config BR2_PACKAGE_COLLECTD_NETWORK_GCRYPT + bool "crypto support" + depends on BR2_PACKAGE_COLLECTD_NETWORK + select BR2_PACKAGE_LIBGCRYPT + help + Enable crypto supportIt would IMHO also make sense to change the conditional in collectd.mk to use this symbol so crypto support is really disabled if this option is turned off, otherwise it is just confusing in the other direction now.
Indeed. Pascal, could you send a patch implementing this?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com