Skip to contentSkip to conversation

rtc: fsl-ftm-alarm: remove the useless variable

PATCH In review Peng Ma 2 participants 3 messages Mar 23, 2020 Real time clock (RTC)

lore
Share & tools
lore

Peng Ma

author
#0 lore raw

PATCH 1/1 rtc: fsl-ftm-alarm: remove the useless variable

Remove the useless variable to fixed the below build warning:
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
struct device_node *np = pdev->dev.of_node;

---
 drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-fsl-ftm-alarm.c +0 -1
index c572044..0f4142b 100644
@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
 
 static int ftm_rtc_probe(struct platform_device *pdev)
 {
-	struct device_node *np = pdev->dev.of_node;
 	int irq;
 	int ret;
 	struct ftm_rtc *rtc;
Signature · 1 line
2.9.5
#1 lore raw
Quoted 10 lines · Peng Ma

Remove the useless variable to fixed the below build warning:
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
struct device_node *np = pdev->dev.of_node;

---
 drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
 1 file changed, 1 deletion(-)

I squashed it in the offending commit.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw
Quoted 20 lines

-----Original Message-----
From: Alexandre Belloni <[email protected]>
Sent: 2020年3月23日 16:29
To: Peng Ma <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Leo Li <[email protected]>; Ran Wang <[email protected]>; Biwen Li <[email protected]>
Subject: [EXT] Re: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable

Caution: EXT Email

Quoted 3 lines · Peng Ma

Remove the useless variable to fixed the below build warning:
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'

[-Wunused-variable]

Quoted 2 lines
  struct device_node *np = pdev->dev.of_node;
Quoted 7 lines
Quoted 5 lines
---
 drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
 1 file changed, 1 deletion(-)

I squashed it in the offending commit.

[Peng Ma] OK,Got it, thanks

Best Regards,
Peng

Quoted 8 lines

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&amp;data=02%7C01%7Cpeng.ma%40nxp.com%7Cd3d60d9c26524805b352 08d7cf043999%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6372054 89372736346&amp;sdata=wb4bBcP8dMbriAdZFnSgl44JokZ0AK6MsGa7z6CWGlg %3D&amp;reserved=0