drivers: new helper for ioremapping memory resources
Subsystems (4)
v4 cover drivers: new helper for ioremapping memory resources
Since commit "drivers: provide devm_platform_ioremap_resource()", It was wrap platform_get_resource() and devm_ioremap_resource() as single helper devm_platform_ioremap_resource(). but now, many drivers still used platform_get_resource() and devm_ioremap_resource() together in the kernel tree. The reason can not be replaced is they still need use the resource variables obtained by platform_get_resource(). so provide this helper.
The first patch in this series adds a wrapper for these two calls and the other uses it in a driver.
v3 -> v4:
- modified the description of a parameter res in patch 1.
- modified patch 5's commit comment.
v2 -> v3:
- rename the function to devm_platform_get_and_ioremap_resource() by Sergei's suggestion.
- make the last parameter res as optional by Geert's suggestion.
- Reimplement devm_platform_ioremap_resource by calling devm_platform_get_and_ioremap_resource() by Geert's suggestion.
v1 -> v2:
- add some real users of this function (Thanks for greg k-h's reminder)
Dejin Zheng (5):
drivers: provide devm_platform_get_and_ioremap_resource()
usb: host: xhci-plat: convert to
devm_platform_get_and_ioremap_resource
usb: host: hisilicon: convert to
devm_platform_get_and_ioremap_resource
usb: dwc2: convert to devm_platform_get_and_ioremap_resource driver core: platform: Reimplement devm_platform_ioremap_resource
drivers/base/platform.c | 27 +++++++++++++++++++++++---- drivers/usb/dwc2/platform.c | 3 +-- drivers/usb/host/xhci-histb.c | 3 +-- drivers/usb/host/xhci-plat.c | 3 +-- include/linux/platform_device.h | 3 +++ 5 files changed, 29 insertions(+), 10 deletions(-)
Signature · 1 line
2.25.0
PATCH v4 1/5 drivers: provide devm_platform_get_and_ioremap_resource()
Since commit "drivers: provide devm_platform_ioremap_resource()", it was wrap platform_get_resource() and devm_ioremap_resource() as single helper devm_platform_ioremap_resource(). but now, many drivers still used platform_get_resource() and devm_ioremap_resource() together in the kernel tree. The reason can not be replaced is they still need use the resource variables obtained by platform_get_resource(). so provide this helper.
---
v3 -> v4:
- modified the description of the parameter res in this patch.
v2 -> v3:
- rename the function to devm_platform_get_and_ioremap_resource() by Sergei's suggestion.
- make the last parameter res as optional by Geert's suggestion.
v1 -> v2:
- No change.
drivers/base/platform.c | 22 ++++++++++++++++++++++ include/linux/platform_device.h | 3 +++ 2 files changed, 25 insertions(+)
drivers/base/platform.c +22 -0
@@ -62,6 +62,28 @@ struct resource *platform_get_resource(struct platform_device *dev,EXPORT_SYMBOL_GPL (platform_get_resource);#ifdef CONFIG_HAS_IOMEM +/** +* devm_platform_get_and_ioremap_resource - call devm_ioremap_resource() for a +* platform device and get resource +* +* @pdev: platform device to use both for memory resource lookup as well as +* resource management +* @index: resource index +* @res: optional output parameter to store a pointer to the obtained resource. +*/ +void __iomem * +devm_platform_get_and_ioremap_resource (struct platform_device *pdev, +unsigned int index,struct resource **res) +{ +struct resource *r; + + r =platform_get_resource (pdev,IORESOURCE_MEM , index); +if (res) + *res = r; +return devm_ioremap_resource (&pdev->dev, r); +} +EXPORT_SYMBOL_GPL (devm_platform_get_and_ioremap_resource); +/** * devm_platform_ioremap_resource - call devm_ioremap_resource() for a platform * device
include/linux/platform_device.h +3 -0
@@ -55,6 +55,9 @@ extern struct device * platform_find_device_by_driver(struct device *start, const struct device_driver *drv);extern void __iomem * +devm_platform_get_and_ioremap_resource (struct platform_device *pdev, +unsigned int index,struct resource **res); +extern void __iomem *devm_platform_ioremap_resource (struct platform_device *pdev,unsigned int index); extern void __iomem *
Signature · 1 line
2.25.0
PATCH v4 2/5 usb: host: xhci-plat: convert to devm_platform_get_and_ioremap_resource
In reply to Dejin ZhengUse devm_platform_get_and_ioremap_resource() to simplify code, which contains platform_get_resource() and devm_ioremap_resource(), it also get the resource for use by the following code.
---
v3 -> v4:
- no changed.
v2 -> v3:
- call the rename function devm_platform_get_and_ioremap_resource()
v1 -> v2:
- add this patch for add some real users of this function.
drivers/usb/host/xhci-plat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/host/xhci-plat.c +1 -2
@@ -219,8 +219,7 @@ static int xhci_plat_probe(struct platform_device *pdev) goto disable_runtime; } - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - hcd->regs =devm_ioremap_resource (&pdev->dev, res); + hcd->regs =devm_platform_get_and_ioremap_resource (pdev,0 , &res);if (IS_ERR (hcd->regs)) { ret =PTR_ERR (hcd->regs); goto put_hcd;
Signature · 1 line
2.25.0
PATCH v4 3/5 usb: host: hisilicon: convert to devm_platform_get_and_ioremap_resource
In reply to Dejin ZhengUse devm_platform_get_and_ioremap_resource() to simplify code, which contains platform_get_resource() and devm_ioremap_resource(), it also get the resource for use by the following code.
---
v3 -> v4:
- no changed.
v2 -> v3:
- call the rename function devm_platform_get_and_ioremap_resource()
v1 -> v2:
- add this patch for add some real users of this function.
drivers/usb/host/xhci-histb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/host/xhci-histb.c +1 -2
@@ -219,8 +219,7 @@ static int xhci_histb_probe(struct platform_device *pdev)if (irq <0 )return irq; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - histb->ctrl =devm_ioremap_resource (&pdev->dev, res); + histb->ctrl =devm_platform_get_and_ioremap_resource (pdev,0 , &res);if (IS_ERR (histb->ctrl))return PTR_ERR (histb->ctrl);
Signature · 1 line
2.25.0
PATCH v4 4/5 usb: dwc2: convert to devm_platform_get_and_ioremap_resource
In reply to Dejin ZhengUse devm_platform_get_and_ioremap_resource() to simplify code, which contains platform_get_resource() and devm_ioremap_resource(), it also get the resource for use by the following code.
---
v2 -> v3:
- no changed.
v2 -> v3:
- call the rename function devm_platform_get_and_ioremap_resource()
v1 -> v2:
- add this patch for add some real users of this function.
drivers/usb/dwc2/platform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/dwc2/platform.c +1 -2
@@ -392,8 +392,7 @@ static int dwc2_driver_probe(struct platform_device *dev)return retval; } - res =platform_get_resource (dev,IORESOURCE_MEM ,0 ); - hsotg->regs =devm_ioremap_resource (&dev->dev, res); + hsotg->regs =devm_platform_get_and_ioremap_resource (dev,0 , &res);if (IS_ERR (hsotg->regs))return PTR_ERR (hsotg->regs);
Signature · 1 line
2.25.0
PATCH v4 5/5 driver core: platform: Reimplement devm_platform_ioremap_resource
In reply to Dejin ZhengReimplement devm_platform_ioremap_resource() by calling devm_platform_ioremap_and_get_resource() with res = NULL to simplify the code.
---
v3 -> v4:
- modified this patch's commit comment.
v2 -> v3:
- add this patch to simplify the code by Geert's suggestion.
drivers/base/platform.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/base/platform.c +1 -4
@@ -95,10 +95,7 @@ EXPORT_SYMBOL_GPL(devm_platform_get_and_ioremap_resource);void __iomem *devm_platform_ioremap_resource (struct platform_device *pdev,unsigned int index) { -struct resource *res; - - res =platform_get_resource (pdev,IORESOURCE_MEM , index); -return devm_ioremap_resource (&pdev->dev, res); +return devm_platform_get_and_ioremap_resource (pdev, index,NULL ); }EXPORT_SYMBOL_GPL (devm_platform_ioremap_resource);
Signature · 1 line
2.25.0