package/mediastreamer: portaudio needs speexdsp
PATCH v2 1/2 package/mediastreamer: portaudio needs speexdsp
Commit 8f5562ed7c227f29dbfa6897f54dccda0dfbf656 wrongly removed speexdsp dependency from portaudio
Fixes:
- http://autobuild.buildroot.org/results/e6adf151141ae56f5194165fd5b74b52164bfb17
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- portaudio only needs speexdsp, not speex
package/mediastreamer/mediastreamer.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/mediastreamer/mediastreamer.mk +2 -1
@@ -80,7 +80,8 @@ else MEDIASTREAMER_CONF_OPTS += -DENABLE_OPUS=OFF endif -ifeq ($(BR2_PACKAGE_PORTAUDIO),y) +# portaudio backend needs speexdsp as well +ifeq ($(BR2_PACKAGE_PORTAUDIO)$(BR2_PACKAGE_SPEEXDSP),yy) MEDIASTREAMER_CONF_OPTS += \ -DENABLE_PORTAUDIO=ON \ -DENABLE_SOUND=ON
Signature · 1 line
2.25.1
PATCH v2 2/2 package/mediastreamer: resample needs speex and speexdsp
resample needs speex and speexdsp as spotted by Thomas Petazzoni during review of https://patchwork.ozlabs.org/patch/1252391/
Fixes:
- http://autobuild.buildroot.org/results/32d06517a5470f71d9b7dc99139f6c3071e7d77d
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- resample needs speex and speexdsp
package/mediastreamer/mediastreamer.mk | 6 ++++++ 1 file changed, 6 insertions(+)
package/mediastreamer/mediastreamer.mk +6 -0
@@ -113,6 +113,12 @@ else MEDIASTREAMER_CONF_OPTS += -DENABLE_SPEEX_DSP=OFF endif +ifeq ($(BR2_PACKAGE_SPEEX)$(BR2_PACKAGE_SPEEXDSP),yy) +MEDIASTREAMER_CONF_OPTS += -DENABLE_RESAMPLE=ON +else +MEDIASTREAMER_CONF_OPTS += -DENABLE_RESAMPLE=OFF +endif + ifeq ($(BR2_PACKAGE_FFMPEG_SWSCALE),y) MEDIASTREAMER_CONF_OPTS += -DENABLE_FFMPEG=ON MEDIASTREAMER_DEPENDENCIES += ffmpeg
Signature · 1 line
2.25.1
PATCH v2 1/2 package/mediastreamer: portaudio needs speexdsp
In reply to Fabrice FontaineQuoted 10 lines · On Mon, 23 Mar 2020 19:01:20 +0100 Fabrice Fontaine…
Commit
8f5562ed7c227f29dbfa6897f54dccda0dfbf656wrongly removed speexdsp dependency from portaudioFixes:
- http://autobuild.buildroot.org/results/e6adf151141ae56f5194165fd5b74b52164bfb17Signed-off-by Fabrice Fontaine <[email protected]>---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- portaudio only needs speexdsp, not speex
Thanks, I've applied both. Could you report both bugs upstream? Indeed these issues should not lead to compilation failure: it should be handled in CMakeLists.txt, either by disabling the feature, or erroring out at configure time.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com