tests/migration: Reduce autoconverge initial bandwidth
PATCH v3 1/1 tests/migration: Reduce autoconverge initial bandwidth
When using max-bandwidth=~100Mb/s, this test fails on Travis-CI s390x when configured with --disable-tcg:
$ make check-qtest
TEST check-qtest-s390x: tests/qtest/boot-serial-test
qemu-system-s390x: -accel tcg: invalid accelerator tcg
qemu-system-s390x: falling back to KVM
TEST check-qtest-s390x: tests/qtest/pxe-test
TEST check-qtest-s390x: tests/qtest/test-netfilter
TEST check-qtest-s390x: tests/qtest/test-filter-mirror
TEST check-qtest-s390x: tests/qtest/test-filter-redirector
TEST check-qtest-s390x: tests/qtest/drive_del-test
TEST check-qtest-s390x: tests/qtest/device-plug-test
TEST check-qtest-s390x: tests/qtest/virtio-ccw-test
TEST check-qtest-s390x: tests/qtest/cpu-plug-test
TEST check-qtest-s390x: tests/qtest/migration-test
**
ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1Per David Gilbert, "it could just be the writing is slow on s390 and the migration thread fast; in which case the autocomplete wouldn't be needed. Perhaps we just need to reduce the bandwidth limit."
Tuning the threshold by reducing the initial bandwidth makes the autoconverge test pass.
---
v3: really reduce =)
--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qtest/migration-test.c +1 -1
@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);
Signature · 1 line
2.21.1
Quoted 26 lines · * Philippe Mathieu-Daudé ([email protected]) wrote:
When using max-bandwidth=~100Mb/s, this test fails on Travis-CI s390x when configured with --disable-tcg:
$ make check-qtest TEST check-qtest-s390x: tests/qtest/boot-serial-test qemu-system-s390x: -accel tcg: invalid accelerator tcg qemu-system-s390x: falling back to KVM TEST check-qtest-s390x: tests/qtest/pxe-test TEST check-qtest-s390x: tests/qtest/test-netfilter TEST check-qtest-s390x: tests/qtest/test-filter-mirror TEST check-qtest-s390x: tests/qtest/test-filter-redirector TEST check-qtest-s390x: tests/qtest/drive_del-test TEST check-qtest-s390x: tests/qtest/device-plug-test TEST check-qtest-s390x: tests/qtest/virtio-ccw-test TEST check-qtest-s390x: tests/qtest/cpu-plug-test TEST check-qtest-s390x: tests/qtest/migration-test ** ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1Per David Gilbert, "it could just be the writing is slow on s390 and the migration thread fast; in which case the autocomplete wouldn't be needed. Perhaps we just need to reduce the bandwidth limit."
Quoted 5 lines
Tuning the threshold by reducing the initial bandwidth makes the autoconverge test pass.
Suggested-by Dr. David Alan Gilbert <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>
This is what I'm expecting to help, so if it passes testing lets try it.
'got_stop' being true just indicates the migration managed to complete.
Quoted 22 lines
---
v3: really reduce =)--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
2.21.1
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 42 lines · Philippe Mathieu-Daudé
When using max-bandwidth=~100Mb/s, this test fails on Travis-CI s390x when configured with --disable-tcg:
$ make check-qtest TEST check-qtest-s390x: tests/qtest/boot-serial-test qemu-system-s390x: -accel tcg: invalid accelerator tcg qemu-system-s390x: falling back to KVM TEST check-qtest-s390x: tests/qtest/pxe-test TEST check-qtest-s390x: tests/qtest/test-netfilter TEST check-qtest-s390x: tests/qtest/test-filter-mirror TEST check-qtest-s390x: tests/qtest/test-filter-redirector TEST check-qtest-s390x: tests/qtest/drive_del-test TEST check-qtest-s390x: tests/qtest/device-plug-test TEST check-qtest-s390x: tests/qtest/virtio-ccw-test TEST check-qtest-s390x: tests/qtest/cpu-plug-test TEST check-qtest-s390x: tests/qtest/migration-test ** ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1Per David Gilbert, "it could just be the writing is slow on s390 and the migration thread fast; in which case the autocomplete wouldn't be needed. Perhaps we just need to reduce the bandwidth limit."
Tuning the threshold by reducing the initial bandwidth makes the autoconverge test pass.
Suggested-by Dr. David Alan Gilbert <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
v3: really reduce =)--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +0
-0
tests/qtest/migration-test.c static void test_migrate_auto_converge(void) · line 1217
Quoted 8 lines
tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);
The vm-build tests work again.
Signature · 1 line
Alex Bennée
Quoted 26 lines · * Philippe Mathieu-Daudé ([email protected]) wrote:
When using max-bandwidth=~100Mb/s, this test fails on Travis-CI s390x when configured with --disable-tcg:
$ make check-qtest TEST check-qtest-s390x: tests/qtest/boot-serial-test qemu-system-s390x: -accel tcg: invalid accelerator tcg qemu-system-s390x: falling back to KVM TEST check-qtest-s390x: tests/qtest/pxe-test TEST check-qtest-s390x: tests/qtest/test-netfilter TEST check-qtest-s390x: tests/qtest/test-filter-mirror TEST check-qtest-s390x: tests/qtest/test-filter-redirector TEST check-qtest-s390x: tests/qtest/drive_del-test TEST check-qtest-s390x: tests/qtest/device-plug-test TEST check-qtest-s390x: tests/qtest/virtio-ccw-test TEST check-qtest-s390x: tests/qtest/cpu-plug-test TEST check-qtest-s390x: tests/qtest/migration-test ** ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1Per David Gilbert, "it could just be the writing is slow on s390 and the migration thread fast; in which case the autocomplete wouldn't be needed. Perhaps we just need to reduce the bandwidth limit."
Quoted 5 lines
Tuning the threshold by reducing the initial bandwidth makes the autoconverge test pass.
Suggested-by Dr. David Alan Gilbert <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Queued
Quoted 23 lines
---
v3: really reduce =)--- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qtest/migration-test.c +1
-1@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)* without throttling. */ migrate_set_parameter_int (from,"downtime-limit" ,1 ); -migrate_set_parameter_int (from,"max-bandwidth" ,100000000 );/* ~100Mb/s */ +migrate_set_parameter_int (from,"max-bandwidth" ,1000000 );/* ~1Mb/s */ /* To check remaining size after precopy */ migrate_set_capability (from,"pause-before-switchover" , true);Signature · 1 line
2.21.1
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK