xen: expand BALLOON_MEMORY_HOTPLUG description
PATCH 1/2 xen: expand BALLOON_MEMORY_HOTPLUG description
To mention it's also useful for PVH or HVM domains that require mapping foreign memory or grants.
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]
--- drivers/xen/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)
drivers/xen/Kconfig +4 -0
@@ -19,6 +19,10 @@ config XEN_BALLOON_MEMORY_HOTPLUG It is very useful on critical systems which require long run without rebooting. + It's also very useful for translated domains (PVH or HVM) to obtain + unpopulated physical memory ranges to use in order to map foreign + memory or grants. + Memory could be hotplugged in following steps: 1) target domain: ensure that memory auto online policy is in
Signature · 1 line
2.25.0
PATCH 2/2 xen: enable BALLOON_MEMORY_HOTPLUG by default
Without it a PVH dom0 is mostly useless, as it would balloon down huge amounts of RAM in order get physical address space to map foreign memory and grants, ultimately leading to an out of memory situation.
Such option is also needed for HVM or PVH driver domains, since they also require mapping grants into physical memory regions.
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]
--- drivers/xen/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/xen/Kconfig +1 -0
@@ -13,6 +13,7 @@ config XEN_BALLOON config XEN_BALLOON_MEMORY_HOTPLUG bool "Memory hotplug support for Xen balloon driver" depends on XEN_BALLOON && MEMORY_HOTPLUG + default y help Memory hotplug support for Xen balloon driver allows expanding memory available for the system above limit declared at system startup.
Signature · 1 line
2.25.0
Re: [PATCH 2/2] xen: enable BALLOON_MEMORY_HOTPLUG by default
Quoted 24 lines · Roger Pau Monne
Without it a PVH dom0 is mostly useless, as it would balloon down huge amounts of RAM in order get physical address space to map foreign memory and grants, ultimately leading to an out of memory situation.
Such option is also needed for HVM or PVH driver domains, since they also require mapping grants into physical memory regions.
Suggested-by Ian Jackson <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]--- drivers/xen/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/xen/Kconfig +0
-0
drivers/xen/Kconfig config XEN_BALLOON · line 19
Quoted 7 lines
drivers/xen/Kconfig +1
-0@@ -13,6 +13,7 @@ config XEN_BALLOON config XEN_BALLOON_MEMORY_HOTPLUG bool "Memory hotplug support for Xen balloon driver" depends on XEN_BALLOON && MEMORY_HOTPLUG + default y help Memory hotplug support for Xen balloon driver allows expanding memory available for the system above limit declared at system startup.
Another variant would be to set: default XEN_BACKEND
This would match the reasoning for switching it on.
Either way would be fine with me, so you can add
Juergen
Re: [PATCH 2/2] xen: enable BALLOON_MEMORY_HOTPLUG by default
Quoted 35 lines · Jürgen Groß
Quoted 24 lines · Roger Pau Monne
Without it a PVH dom0 is mostly useless, as it would balloon down huge amounts of RAM in order get physical address space to map foreign memory and grants, ultimately leading to an out of memory situation.
Such option is also needed for HVM or PVH driver domains, since they also require mapping grants into physical memory regions.
Suggested-by Ian Jackson <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]--- drivers/xen/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/xen/Kconfig +0
-0drivers/xen/Kconfig config XEN_BALLOON · line 19
Quoted 7 lines
drivers/xen/Kconfig +1
-0@@ -13,6 +13,7 @@ config XEN_BALLOON config XEN_BALLOON_MEMORY_HOTPLUG bool "Memory hotplug support for Xen balloon driver" depends on XEN_BALLOON && MEMORY_HOTPLUG + default y help Memory hotplug support for Xen balloon driver allows expanding memory available for the system above limit declared at system startup.Another variant would be to set: default
XEN_BACKEND
Quoted 1 line
This would match the reasoning for switching it on.
I would rather have it always on if possible, as gntdev or privcmd (when used to map foreign pages from user-space) will also require it, and they are not gated on XEN_BACKEND AFAICT.
Quoted 3 lines
Either way would be fine with me, so you can add
Reviewed-by Juergen Gross <[email protected]>
Thanks!
Roger.
Re: [PATCH 2/2] xen: enable BALLOON_MEMORY_HOTPLUG by default
Roger Pau Monne writes ("Re: [PATCH 2/2] xen: enable BALLOON_MEMORY_HOTPLUG by default"):
Quoted 3 lines
I would rather have it always on if possible, as gntdev or privcmd (when used to map foreign pages from user-space) will also require it, and they are not gated on
XEN_BACKENDAFAICT.
Currently there seem to be problems with this:
http://logs.test-lab.xenproject.org/osstest/logs/149014/test-amd64-amd64-dom0pvh-xl-intel/info.html
For now I have rolled back the change in osstest to enable this option explicitly.
Ian.
Quoted 18 lines · Roger Pau Monne
To mention it's also useful for PVH or HVM domains that require mapping foreign memory or grants.
Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]--- drivers/xen/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)drivers/xen/Kconfig +0
-0
drivers/xen/Kconfig config XEN_BALLOON_MEMORY_HOTPLUG · line 22
Quoted 4 lines
drivers/xen/Kconfig +1
-0@@ -19,6 +19,10 @@ config XEN_BALLOON_MEMORY_HOTPLUG It is very useful on critical systems which require long run without rebooting. + It's also very useful for translated domains (PVH or HVM) to obtain
I'd rather say "(non PV)" or "(PVH, HVM or Arm)".
drivers/xen/Kconfig config XEN_BALLOON_MEMORY_HOTPLUG · line 28
Quoted 7 lines
drivers/xen/Kconfig +3
-0+ unpopulated physical memory ranges to use in order to map foreign + memory or grants. + Memory could be hotplugged in following steps: 1) target domain: ensure that memory auto online policy is in
With that:
Juergen
Quoted 14 lines · Jürgen Groß
Quoted 13 lines · Roger Pau Monne
To mention it's also useful for PVH or HVM domains that require mapping foreign memory or grants.
Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]--- drivers/xen/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)
Quoted 10 lines
drivers/xen/Kconfig config XEN_BALLOON_MEMORY_HOTPLUG · line 21
Quoted 8 lines
drivers/xen/Kconfig +1
-0@@ -19,6 +19,10 @@ config XEN_BALLOON_MEMORY_HOTPLUG It is very useful on critical systems which require long run without rebooting. + It's also very useful for translated domains (PVH or HVM) to obtainI'd rather say "(non PV)" or "(PVH, HVM or Arm)".
I'm fine with any of the variants. Would you mind adjusting when picking it up or would you like me to resend?
Quoted 10 lines
drivers/xen/Kconfig config XEN_BALLOON_MEMORY_HOTPLUG
Quoted 6 lines
drivers/xen/Kconfig +3
-0+ unpopulated physical memory ranges to use in order to map foreign + memory or grants. + Memory could be hotplugged in following steps: 1) target domain: ensure that memory auto online policy is inWith that:
Reviewed-by Juergen Gross <[email protected]>
Thanks!
Jürgen Groß
maintainerQuoted 26 lines · Roger Pau Monné
Quoted 14 lines · Jürgen Groß
Quoted 13 lines · Roger Pau Monne
To mention it's also useful for PVH or HVM domains that require mapping foreign memory or grants.
Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]--- drivers/xen/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)Quoted 10 lines
drivers/xen/Kconfig config XEN_BALLOON_MEMORY_HOTPLUG · line 21
Quoted 8 lines
drivers/xen/Kconfig +1
-0@@ -19,6 +19,10 @@ config XEN_BALLOON_MEMORY_HOTPLUG It is very useful on critical systems which require long run without rebooting. + It's also very useful for translated domains (PVH or HVM) to obtainI'd rather say "(non PV)" or "(PVH, HVM or Arm)".
Quoted 2 lines
I'm fine with any of the variants. Would you mind adjusting when picking it up or would you like me to resend?
No need to resend. I'll use the "non PV" variant.
Juergen